From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01660C433DF for ; Thu, 9 Jul 2020 00:16:36 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 0DD5820775 for ; Thu, 9 Jul 2020 00:16:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="J7ZWVtD1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DD5820775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=partner.samsung.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BA4E1D921; Thu, 9 Jul 2020 02:16:33 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 219651D920 for ; Thu, 9 Jul 2020 02:16:31 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200709001631euoutp02f6d3e9113f966a2ba7812e154d08976f~f7WBS_WvU0994709947euoutp02b for ; Thu, 9 Jul 2020 00:16:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200709001631euoutp02f6d3e9113f966a2ba7812e154d08976f~f7WBS_WvU0994709947euoutp02b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594253791; bh=QglnL2rOwTHy4jjaBIvrjC6shrUdcsKcAfb/YtIJfKk=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=J7ZWVtD17ZNWi1J1/Y6kQMY5tg3GzkjOnFrnEfy11sD/R7Su+Vpb/MyEzupkPC92E 2AKX/9cFsRhSXtAActLSlGCZQwEFqqcYfdTHT20LXgGrnA/BFFgS2cROPiWW5axvFo jrReLg1rKfI5Ut6m4Y2vt9DGU0XZbyXlefuDKXmE= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200709001630eucas1p24b55f8ed8c9df2d90e9b9629532595b2~f7WAg8x0q1321413214eucas1p2T; Thu, 9 Jul 2020 00:16:30 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 02.18.06318.ED1660F5; Thu, 9 Jul 2020 01:16:30 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200709001629eucas1p2b057d1ec528b54a2621c43f730befc56~f7V-x1qdC1321313213eucas1p2L; Thu, 9 Jul 2020 00:16:29 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200709001629eusmtrp2517a108a5578f025022350a419372184~f7V-xS7TI0889308893eusmtrp2e; Thu, 9 Jul 2020 00:16:29 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-4c-5f0661de3d68 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id D0.73.06314.DD1660F5; Thu, 9 Jul 2020 01:16:29 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200709001628eusmtip17aa25cc1231e1ae58b48c81693cdfbff~f7V_2PTJB1680916809eusmtip1f; Thu, 9 Jul 2020 00:16:28 +0000 (GMT) To: Andrew Rybchenko , David Marchand , dev@dpdk.org Cc: Ilya Maximets From: Lukasz Wojciechowski Message-ID: <1f3ca39a-1814-0b3a-39d2-445056a0352e@partner.samsung.com> Date: Thu, 9 Jul 2020 02:16:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsWy7djPc7r3EtniDea/4bR4MOUum8X2FV1s Fu8+bWeyuPu8gcmBxePXgqWsHs+v9bB4vN93lc1j9ZMfbAEsUVw2Kak5mWWpRfp2CVwZCxu2 sRY84ar42rOfvYHxM0cXIyeHhICJxNbe66xdjFwcQgIrGCUm/XjLBuF8YZT40dXIBlIlJPCZ UeL0GX2Yjr1PWhghipYzSnxpWg/lvGWUOLF/BQtIlbCAg8S//1vAukUEciTuXv0GFmcWUJNY uHw2WJxNwFbiyMyvrCA2r4CbRNf5j+wgNouAisTndY+YQWxRgTiJ9S+3M0HUCEqcnPkEbA6n gJPErbNfGSFmyks0b53NDGGLS9x6Mp8J5CAJgcnsEluOT2CFONtFYkL3VyhbWOLV8S3sELaM xP+dMA3bGCWu/v7JCOHsZ5S43rsCqspa4vC/30BncwCt0JRYvwsaFo4S55b8ZgUJSwjwSdx4 KwhxBJ/EpG3TmSHCvBIdbUIQ1XoST3umMsKs/bP2CcsERqVZSF6bheSdWUjemYWwdwEjyypG 8dTS4tz01GLjvNRyveLE3OLSvHS95PzcTYzA9HL63/GvOxj3/Uk6xCjAwajEw/tiE2u8EGti WXFl7iFGCQ5mJRFep7On44R4UxIrq1KL8uOLSnNSiw8xSnOwKInzGi96GSskkJ5YkpqdmlqQ WgSTZeLglGpgZGTnk0xZE/Xn1urn953DOxzFdFmW8jK3F+4NMLhmYlft8ouvvfL/D6eQxkt9 yYwP5ndZLcs5+vby7BgNVy2jOpXba25WlVRMvNTm0nm7wiXpy+xHfx4J3uf85sPw54npQ5HN ka9aXL26S1zO6zR9yDouWJ5nF3ug/UWMd6u/p+rck0b5s44osRRnJBpqMRcVJwIAx2XtrysD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsVy+t/xu7p3E9niDQ7PFLN4MOUum8X2FV1s Fu8+bWeyuPu8gcmBxePXgqWsHs+v9bB4vN93lc1j9ZMfbAEsUXo2RfmlJakKGfnFJbZK0YYW RnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWpRfp2CXoZCxu2sRY84ar42rOfvYHxM0cXIyeH hICJxN4nLYxdjFwcQgJLGSV+3P/A0sXIAZSQkfhwSQCiRljiz7UuNoia14wSDV13WUASwgIO Ev/+b2EDsUUEciQ+r93ACmIzC6hJLFw+G6rhFKPEqe5GdpAEm4CtxJGZX8GKeAXcJLrOfwSL swioSHxe94gZxBYViJNYvmU+O0SNoMTJmU/AlnEKOEncOvuVEWKBmcS8zQ+ZIWx5ieats6Fs cYlbT+YzTWAUmoWkfRaSlllIWmYhaVnAyLKKUSS1tDg3PbfYUK84Mbe4NC9dLzk/dxMjMJ62 Hfu5eQfjpY3BhxgFOBiVeHhfbGKNF2JNLCuuzD3EKMHBrCTC63T2dJwQb0piZVVqUX58UWlO avEhRlOg5yYyS4km5wNjPa8k3tDU0NzC0tDc2NzYzEJJnLdD4GCMkEB6YklqdmpqQWoRTB8T B6dUA2P0/zeu0skzM+JjPXcdKtt93n/rltDXjMo75jhJXHA73yO64M6EIMd2q3VTgtvOhS2s W5rz90h1vXdd3e/NIu6CG9uVvCRizU95Bd6O8ldLCljve3Xth/eXsj3CcgTOR0QaH489pvoz tcuLXd3+tUeS5XWdNeJbvOVmBx5n1mm6sTl19iTveCWW4oxEQy3mouJEALF9pJG9AgAA X-CMS-MailID: 20200709001629eucas1p2b057d1ec528b54a2621c43f730befc56 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200626144637eucas1p276dc0e7e479d6ed0c64549b8a30d2bff X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200626144637eucas1p276dc0e7e479d6ed0c64549b8a30d2bff References: <20200626114751.22523-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [RFC PATCH] log: track log level changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 26.06.2020 o 16:46, Andrew Rybchenko pisze: > On 6/26/20 2:47 PM, David Marchand wrote: >> Add a log message when changing log levels to be sure of which logtype >> is enabled. >> >> Suggested-by: Ilya Maximets >> Signed-off-by: David Marchand > Acked-by: Andrew Rybchenko > I also like the idea so: Acked-by: Lukasz Wojciechowski although I think there is one place that can be smoothed a bit. Every newly registered type's loglevel is set to RTE_LOG_INFO in __rte_log_register(), so: * if new type is registered with rte_log_register_type_and_pick_level() and level is set to INFO, nothing will be printed (as current is equal to new level); * any registration made with rte_log_register() won't be seen either as there is no call to newly introduced function logtype_set_level(). How about additionally changing behavior so any registration will print change from "disabled" (level=0) to new level: * in case of rte_log_register_type_and_pick_level() to chosen level * in case of rte_log_register() to default level which is "info" Best regards -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com