From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCHv2] ARM64: KVM: use lm_alias() for kvm_ksym_ref() Date: Fri, 25 May 2018 12:08:28 +0100 Message-ID: <1f54d71c-6ae1-732f-3ee0-99e38287a3b0@arm.com> References: <20180510111347.32253-1-mark.rutland@arm.com> <20180525105010.qswcppfkybznmzka@lakrids.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 055794070F for ; Fri, 25 May 2018 06:58:12 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gy32a2-F4k3P for ; Fri, 25 May 2018 06:57:49 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C6E9640683 for ; Fri, 25 May 2018 06:57:49 -0400 (EDT) In-Reply-To: <20180525105010.qswcppfkybznmzka@lakrids.cambridge.arm.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Mark Rutland , linux-arm-kernel@lists.infradead.org Cc: kvmarm@lists.cs.columbia.edu List-Id: kvmarm@lists.cs.columbia.edu On 25/05/18 11:50, Mark Rutland wrote: > On Thu, May 10, 2018 at 12:13:47PM +0100, Mark Rutland wrote: >> For historical reasons, we open-code lm_alias() in kvm_ksym_ref(). >> >> Let's use lm_alias() to avoid duplication and make things clearer. >> >> As we have to pull this from (which is not safe for >> inclusion in assembly), we may as well move the kvm_ksym_ref() >> definition into the existing !__ASSEMBLY__ block. >> >> Signed-off-by: Mark Rutland >> Cc: Christoffer Dall >> Cc: Marc Zyngier >> Cc: kvmarm@lists.cs.columbia.edu >> --- >> arch/arm64/include/asm/kvm_asm.h | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) > > Marc, Christoffer, are you happy to pick this up? I've queued it some time ago (see kvmarm/queue), but failed to mention it on the list... Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Fri, 25 May 2018 12:08:28 +0100 Subject: [PATCHv2] ARM64: KVM: use lm_alias() for kvm_ksym_ref() In-Reply-To: <20180525105010.qswcppfkybznmzka@lakrids.cambridge.arm.com> References: <20180510111347.32253-1-mark.rutland@arm.com> <20180525105010.qswcppfkybznmzka@lakrids.cambridge.arm.com> Message-ID: <1f54d71c-6ae1-732f-3ee0-99e38287a3b0@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 25/05/18 11:50, Mark Rutland wrote: > On Thu, May 10, 2018 at 12:13:47PM +0100, Mark Rutland wrote: >> For historical reasons, we open-code lm_alias() in kvm_ksym_ref(). >> >> Let's use lm_alias() to avoid duplication and make things clearer. >> >> As we have to pull this from (which is not safe for >> inclusion in assembly), we may as well move the kvm_ksym_ref() >> definition into the existing !__ASSEMBLY__ block. >> >> Signed-off-by: Mark Rutland >> Cc: Christoffer Dall >> Cc: Marc Zyngier >> Cc: kvmarm at lists.cs.columbia.edu >> --- >> arch/arm64/include/asm/kvm_asm.h | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) > > Marc, Christoffer, are you happy to pick this up? I've queued it some time ago (see kvmarm/queue), but failed to mention it on the list... Thanks, M. -- Jazz is not dead. It just smells funny...