From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F7EC433ED for ; Tue, 18 May 2021 06:33:46 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F1D26124C for ; Tue, 18 May 2021 06:33:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F1D26124C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.128736.241630 (Exim 4.92) (envelope-from ) id 1litIO-00018O-DR; Tue, 18 May 2021 06:33:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 128736.241630; Tue, 18 May 2021 06:33:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1litIO-00018H-9j; Tue, 18 May 2021 06:33:36 +0000 Received: by outflank-mailman (input) for mailman id 128736; Tue, 18 May 2021 06:33:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1litIM-000187-7f for xen-devel@lists.xenproject.org; Tue, 18 May 2021 06:33:34 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8951687a-a21a-4ab7-bbc5-a26f613f3890; Tue, 18 May 2021 06:33:33 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A0C5AAFEF; Tue, 18 May 2021 06:33:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8951687a-a21a-4ab7-bbc5-a26f613f3890 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1621319612; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hl44uEQtqJbnIvb/ZnExV6o4e3Y1rACn6HN7F+6vs8E=; b=C5ThG2csbrrjGMIetdHXRKuyYipdYp0UAsvz2mDPkf4r6wAwyMGFXYOuX+Y0sK41bBi/3M mczsLvGrFvarrCEOERTcVEpWVVKZsSrkVBapyXZB5ebSSYa0+0uD2DdeLaksr/J54/Bxh7 RoJnnrSauTALcGcwCAkjHGqvHogwYgw= Subject: Re: [PATCH v3 4/5] xen: Add files needed for minimal riscv build To: Connor Davis Cc: Bobby Eshleman , Alistair Francis , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <95399fcf-54b0-828f-b3cb-9332ad779f68@gmail.com> From: Jan Beulich Message-ID: <1f551526-dde9-8641-ea41-915dbaac9c46@suse.com> Date: Tue, 18 May 2021 08:33:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <95399fcf-54b0-828f-b3cb-9332ad779f68@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 18.05.2021 06:58, Connor Davis wrote: > On 5/17/21 5:51 AM, Jan Beulich wrote: >> On 14.05.2021 20:53, Connor Davis wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/configs/riscv64_defconfig >>> @@ -0,0 +1,12 @@ >>> +# CONFIG_SCHED_CREDIT is not set >>> +# CONFIG_SCHED_RTDS is not set >>> +# CONFIG_SCHED_NULL is not set >>> +# CONFIG_SCHED_ARINC653 is not set >>> +# CONFIG_TRACEBUFFER is not set >>> +# CONFIG_DEBUG is not set >>> +# CONFIG_DEBUG_INFO is not set >>> +# CONFIG_HYPFS is not set >>> +# CONFIG_GRANT_TABLE is not set >>> +# CONFIG_SPECULATIVE_HARDEN_ARRAY is not set >>> + >>> +CONFIG_EXPERT=y >> These are rather odd defaults, more like for a special purpose >> config than a general purpose one. None of what you turn off here >> will guarantee to be off for people actually trying to build >> things, so it's not clear to me what the idea here is. As a >> specific remark, especially during bringup work I think it is >> quite important to not default DEBUG to off: You definitely want >> to see whether any assertions trigger. > The idea was to turn off as much stuff as possible to get a minimal > build (involving xen/common) working. Although now that we're focused on > only a few files at a time, they could be enabled without adding any > undue burden (at least for now). > > Perhaps it would be best to rename the file to include "tiny" or something, > and then add a normal defconfig once things are actually running? Yes please. Jan