From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1BA0C433FE for ; Fri, 14 Oct 2022 15:48:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A63E38456E; Fri, 14 Oct 2022 17:48:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=siemens.com header.i=@siemens.com header.b="fLxQajt6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 11C2D8456E; Fri, 14 Oct 2022 17:48:19 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2083.outbound.protection.outlook.com [40.107.20.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1868680384 for ; Fri, 14 Oct 2022 17:48:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P1F45Ccxs0W4ae3X6HZsYRD0XqSmGmsOzFEokO79PKP0KOWd5rJK3ctEA4okIhrqVExTcq/4ybgW+u9RHkjV43X+urNdGw6UNaaMiYfO9cnueNPwxhYwhfCKQWcFuKN7QKYIGUMBehDkMEu+Lvjwch+2+ZiEKRuWvDOI1dFwTru1Zet9ls5uZjN4wPWlj/4566AOKVygtoaKfognT3kQtuULVH2mx44L8igo/pTyX6hYd1m134H5GL6ctzmdJLcvKmZHG9+57/4GR3nUQBe6DJe6F87eYhsXFjML/+M7qJXYaeHr8IiuIUwAhX3IqPN5q+yM+wyerq3kXHgFTzG/rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SSXETiBS9no4oRxgmzQ+hDV/qoVImRyb//hLDLpyYik=; b=RW9RlnBtYuj24pGBV7XDhBE6VOf5JHHtI4UKyJn6F1RxL9bbn91uAAfCyJqX7z+kxaIMAiD5xdUImlMoX2nDXpgBi3z1Kw5kI/QFZ2CcZ0DfDBaVWPjyXjINf/Elv+HKLx4t2/+ChYW8eFht8e7SYHsiPRootpaH9z0YiXaCQN7tX5KuX0+Q9FqvnTOwhjvCFlERAApfZOyiHIaiiplHLfzCKoC6q6a1BM1OGbY7+s6j0P5C2wMQkdTt/sJS6UKKvlVZgLQokKQEWLy2chtX+GT5gkIZOsq1fw4wGTZaq6IT9gfxpI74s2YlM6MrS5RM4naG/O56EyV6CfWXtjANHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.76) smtp.rcpttodomain=konsulko.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SSXETiBS9no4oRxgmzQ+hDV/qoVImRyb//hLDLpyYik=; b=fLxQajt6MyT4wsG5otzUyTCeTroXD7GNyrcG+RC8ftgXntuhuqeLCtASM/Ksk0mCYyGw+dBnv/HhkCiiwKcMZ7In3IlU/0KXRzC/3H40qX1YOF2aoDfWcFO/+rdP8hC0CmBoINaSs+HorDjyES6lrYGprSND2onYJzgIPyy0/laqZjBEMzEYeWz2TmlkgbziOpABSj9uxfKKaFDYgMRgOX+qVTyXuigiKAdV8xSiGUqrltvijNK0labFsumWmSRf2hsyhN5WPpcG3vy14N2VwlrqSYIJmo1i7jYi9FxpwvDC24evPX/xPIbbphwGM6HBOGzhyRdpDiXK37d6AY1vbA== Received: from FR3P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::15) by AS8PR10MB6650.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:564::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Fri, 14 Oct 2022 15:48:09 +0000 Received: from VE1EUR01FT005.eop-EUR01.prod.protection.outlook.com (2603:10a6:d10:1f:cafe::45) by FR3P281CA0080.outlook.office365.com (2603:10a6:d10:1f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.9 via Frontend Transport; Fri, 14 Oct 2022 15:48:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.76) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.76 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.76; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.76) by VE1EUR01FT005.mail.protection.outlook.com (10.152.2.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.20 via Frontend Transport; Fri, 14 Oct 2022 15:48:09 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8VSA.ad011.siemens.net (194.138.21.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Fri, 14 Oct 2022 17:48:08 +0200 Received: from [139.21.18.154] (139.21.18.154) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Fri, 14 Oct 2022 17:48:08 +0200 Message-ID: <1f5dddfc-1345-ad50-53b7-ef53da774f3b@siemens.com> Date: Fri, 14 Oct 2022 17:47:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Content-Language: en-US To: Tom Rini , Simon Glass CC: Heinrich Schuchardt , Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> <20221014131315.GM2020586@bill-the-cat> <20221014153948.GW2020586@bill-the-cat> From: Jan Kiszka In-Reply-To: <20221014153948.GW2020586@bill-the-cat> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [139.21.18.154] X-ClientProxiedBy: DEMCHDC8WBA.ad011.siemens.net (139.25.226.105) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--18.844700-8.000000 X-TMASE-MatchedRID: OMk5Q+H0IT45QaOxwNGfvo9bHfxDWoibW6eKzKKCgnPBjbyj5wYDmv6l pfpte41hWAuSz3ewb220QygafZjV1RvER19e8+LDuWcLt7UQTIALyuqgPh8WPp3bt4XlQMWjecm 5MLY/474da1Vk3RqxOIgnLdHU7oiOHPbzAuybsHyFvwEmnsW3vcHVNeDWrWSGdhnFihmbnwVp4x orO9dSmdzONa1Rspx34rl+FHG3VoDu6gyVCKrNt/5nI8KIHQ65Xnan/9QqlwtfvuAR8NI0nOJc6 hKWj0C1dQ3YO1g+ITKfTJvnqXF8K3mN0n5wvdMIY3SO8OGlRUbmo04fDUc7SyAI8aJmq0jw2FA7 wK9mP9ctferJ/d7Abz+tNnCph+AvYBA+EGmViA60mQYyW97dCMEElERnDJHCyPPRU9ScEDXyCvI CuK46cntTo0P1ssT+51bo3ctX+2YH/+DcPzl6R83bMMsSC2Rh7gp3lniZRi8ZSUX8zcPGn02NGi KkOvdnvStYzicikmtRnmmAY+cHohAd0qQY/h4zLxxHBMdDc7oy7wvC8Uc6Hfbta0OAYFzyfS0Ip 2eEHnzUHQeTVDUrItRnEQCUU+jzjoczmuoPCq2wmwXUP9aNX45oFsDQzeyMbU3KrBW4JCCjMa4g WRa4Rej1vEDP+NR0 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--18.844700-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: 9A3FA255A197BA94D3819005F2CCCCAAF88CB5A9286430B7531D170F734F3DE92000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1EUR01FT005:EE_|AS8PR10MB6650:EE_ X-MS-Office365-Filtering-Correlation-Id: 1dfcb2b7-d5f4-4a24-4722-08daadfb7e75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gjphkYDhMK59798RI7DSrgXyzPGIr3yKzXxaa1+GnV8qj7qu2/P0WsubBffugEqF3FtDMtCxSDR0VcjFx4Q1/sSE6OFi/jSjdKT7JoRHrJcaoewZFRQnv0Nw1mQXTQgisFlmCLt4CwGEdM0jNbjWqPgaMhwXnhalOtzBzId/NnaLRBVqum3BBvw/3VGQn0EBmziKyJzhOY1hPbNYk3rJUfRVPRVn/6Rx/3gnh2O5FHsyvOUKrK58RCwiQFJTfQHt0HiN/4T7VZreDh3sxbn+Gx8RSR1mHTPsaqUNor6HSgWIi76A7uERLtxJtnyrhcCG3VwghJabKog3zSAKIc9DDIQXnFWrJ0OaiX7wU8AiTdpnCAkz6bHAPXaDQKFut/evvi/TVRF3XNfC1rMkwyhdZ5kQnnPgUbBzZvuRgCqAeASuz+Zk26ECCxqSn5zmrCG/CAcf9VhmD1fsHIhcPK6ihvnQ2cis5LBHA0IQyLdO0x9Nf985qM5T1Z/w5pLrpT5TlCo+4bE+thRQ6tUrBqYIjjiSKSZmnfGva21yqmP2TMsbMq+nUnVCU5IJSIB39RoD0z0/js7a9kV+ypcg1605L9qNG3qVCFEvJV/PdK/EYYZS/1pcAnfDQ1X6mOA0iwsI/BN4gdDjI62p6mLWx5GLTdls5EdQd++XkhKPdGtJKe2YnQzZCisZHdXLBBTdnfM2i1mtPaGKFoUX/BL4ajzj5T/fx5Ay9+BQ6PJ9nfh7ngkVfjYjtFqwbxm6McxZ2BYqkDd167d9CihBKl2s1XYa+PqNtIixZn6eEPhuP0hKu/v0G+f76AAkEj/OXkOCvjU2oP2rXXiD+ar8wjqI7wMoiNcEtw3a0VlD+oEagjQ7bZrccQR99AlBGhGSjiZcnZbFwn1DPiIxVVh8GD9jiuP2lg== X-Forefront-Antispam-Report: CIP:194.138.21.76; CTRY:DE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:hybrid.siemens.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(40470700004)(36840700001)(46966006)(336012)(478600001)(956004)(2616005)(2906002)(16576012)(54906003)(6706004)(316002)(110136005)(66899015)(31686004)(83380400001)(5660300002)(82310400005)(82740400003)(6666004)(8676002)(4326008)(81166007)(41300700001)(356005)(82960400001)(26005)(70206006)(53546011)(47076005)(186003)(8936002)(16526019)(86362001)(70586007)(31696002)(40460700003)(36860700001)(34070700002)(40480700001)(44832011)(36756003)(3940600001)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 15:48:09.5889 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1dfcb2b7-d5f4-4a24-4722-08daadfb7e75 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; Ip=[194.138.21.76]; Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT005.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB6650 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 14.10.22 17:39, Tom Rini wrote: > On Fri, Oct 14, 2022 at 09:36:46AM -0600, Simon Glass wrote: >> Hi Jan, >> >> On Fri, 14 Oct 2022 at 09:35, Jan Kiszka wrote: >>> >>> On 14.10.22 17:33, Simon Glass wrote: >>>> Hi Tom, >>>> >>>> On Fri, 14 Oct 2022 at 07:13, Tom Rini wrote: >>>>> >>>>> On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote: >>>>>> On 21.10.21 01:34, Heinrich Schuchardt wrote: >>>>>>> On 9/25/21 2:30 AM, Simon Glass wrote: >>>>>>>> This code should never have been added as it builds a new feature on top >>>>>>>> of legacy code. This has already been improved with the dependency on >>>>>>>> BLK. >>>>>>>> >>>>>>>> Add a dependency on DM_ETH also, to avoid needing to deal with this old >>>>>>>> code. >>>>>>>> >>>>>>>> Boards which want EFI_LOADER should migrate to driver model first. >>>>>>>> >>>>>>>> Note this patch is included to resolve the following build error: >>>>>>>> >>>>>>>> lib/efi_loader/efi_runtime.c:680:16: error: ‘CONFIG_SYS_TEXT_BASE’ >>>>>>>> undeclared (first use in this function); did you mean >>>>>>>> ‘CONFIG_SYS_SRAM_BASE’? >>>>>>>> 680 | ulong base = CONFIG_SYS_TEXT_BASE; >>>>>>>> | ^~~~~~~~~~~~~~~~~~~~ >>>>>>>> | CONFIG_SYS_SRAM_BASE >>>>>>>> >>>>>>>> Signed-off-by: Simon Glass >>>>>>> >>>>>>> Reviewed-by: Heinrich Schuchardt >>>>>>> >>>>>> >>>>>> How to deal with boards that need CONFIG_NET but do not actually >>>>>> implement any driver (yet)? This now broke UEFI for the IOT2050 which >>>>>> needs NET for network-related device tree setup (see also [1]) and >>>>>> enforces a local hack for us. >>>>> >>>>> Yes, looking at the patch, this should probably use NETDEVICES and not >>>>> NET as the test? Would that fix your problem, Jan? >>>> >>>> But that selects DM_ETH. You can still enable DM_ETH when there are no >>>> devices, so I'm not sure what the problem is. Can you post an error? >>>> >>>> Things should be migrated to DM_ETH by now (end of 2020). >>>> >>> >>> I am enable DM_ETH now at board-level, just to make EFI_LOADER happy, >>> but that feels wrong. >> >> I agree, but I wonder if this might need some code refactoring. >> Perhaps EFI_LOADER_NET needs to be created, net functionality can be >> disabled? > > I think we should be able to leverage existing flags already for this > and not need a new one. The issue is that CONFIG_NET does not mean "we > have network devices" but CONFIG_NETDEVICES does. > So, you mean fixing up the efi-loader code to use CONFIG_NETDEVICES, rather than CONFIG_NET? Then we could drop that Kconfig check. Jan -- Siemens AG, Technology Competence Center Embedded Linux