From: Mario Limonciello <mario.limonciello@amd.com>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: Basavaraj Natikar <basavaraj.natikar@amd.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] AMD_SFH: Add a DMI quirk entry for Chromebooks
Date: Thu, 14 Jul 2022 06:38:57 -0500 [thread overview]
Message-ID: <1f62503a-6615-b49a-db4d-fff02c1d1087@amd.com> (raw)
In-Reply-To: <20220714053752.5124-1-akihiko.odaki@gmail.com>
On 7/14/22 00:37, Akihiko Odaki wrote:
> Google Chromebooks use Chrome OS Embedded Controller Sensor Hub instead
> of Sensor Hub Fusion and leaves MP2 uninitialized, which disables all
> functionalities, even including the registers necessary for feature
> detections.
>
> The behavior was observed with Lenovo ThinkPad C13 Yoga.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> index dadc491bbf6b..b91e1c95e543 100644
> --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> @@ -197,6 +197,18 @@ static const struct dmi_system_id dmi_sensor_mask_overrides[] = {
> },
> .driver_data = (void *)(ACEL_EN | MAGNO_EN),
> },
> + {
> + /*
> + * Google Chromebooks use Chrome OS Embedded Controller Sensor
> + * Hub instead of Sensor Hub Fusion and leaves MP2
> + * uninitialized, which disables all functionalities, even
> + * including the registers necessary for feature detections.
> + */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Google"),
> + },
> + .driver_data = (void *)0,
> + },
> { }
> };
>
Did you miss my other comment on v1 on discovery sensor probing or is it
not a problem?
next prev parent reply other threads:[~2022-07-14 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 5:37 [PATCH v2] AMD_SFH: Add a DMI quirk entry for Chromebooks Akihiko Odaki
2022-07-14 11:38 ` Mario Limonciello [this message]
2022-07-14 18:44 ` Basavaraj Natikar
2022-07-15 4:41 ` Basavaraj Natikar
2022-07-15 4:45 ` Akihiko Odaki
2022-08-15 18:36 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f62503a-6615-b49a-db4d-fff02c1d1087@amd.com \
--to=mario.limonciello@amd.com \
--cc=akihiko.odaki@gmail.com \
--cc=basavaraj.natikar@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.