From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
matwey.kornilov@gmail.com, lukas@wunner.de,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
christoph.muellner@theobroma-systems.com,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Subject: Re: [PATCH v3 5/5] serial: 8250_dw: add em485 support
Date: Tue, 2 Feb 2021 01:31:17 +0100 [thread overview]
Message-ID: <1f7881b5-f900-dbbe-3f8d-f990d2bdf5a7@micronovasrl.com> (raw)
In-Reply-To: <20200518152103.GI1634618@smile.fi.intel.com>
Hi Andy,
Il 18/05/2020 17:21, Andy Shevchenko ha scritto:
> On Sun, May 17, 2020 at 11:56:10PM +0200, Heiko Stuebner wrote:
>> From: Giulio Benetti <giulio.benetti@micronovasrl.com>
>>
>> Need to use rs485 transceiver so let's use existing em485 485 emulation
>> layer on top of 8250.
>>
>> Add rs485_config callback to port and uses the standard em485 start and
>> stop helpers.
>
> Would it prevent to use native RS485 support?
8250_dw doesn't have a native RS485 support, do you mean using hardware
RTS assertion? Anyway at the moment it's not present. This would be the
first rs485 support added to 8250_dw.
Best regards
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
> ...
>
>> p->serial_out = dw8250_serial_out;
>> p->set_ldisc = dw8250_set_ldisc;
>> p->set_termios = dw8250_set_termios;
>> + p->rs485_config = serial8250_em485_config;
>> + up->rs485_start_tx = serial8250_em485_start_tx;
>> + up->rs485_stop_tx = serial8250_em485_stop_tx;
>
next prev parent reply other threads:[~2021-02-02 0:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 21:56 [PATCH v3 0/5] serial: 8250: Add rs485 emulation to 8250_dw Heiko Stuebner
2020-05-17 21:56 ` [PATCH v3 1/5] serial: 8520_port: Fix function param documentation Heiko Stuebner
2020-05-18 15:09 ` Andy Shevchenko
2020-05-17 21:56 ` [PATCH v3 2/5] dt-bindings: serial: Add binding for rs485 receiver enable GPIO Heiko Stuebner
2020-05-17 21:56 ` [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO Heiko Stuebner
2020-05-18 4:50 ` Lukas Wunner
2020-05-18 8:04 ` Heiko Stübner
2020-05-18 9:19 ` Lukas Wunner
2020-05-18 15:12 ` Andy Shevchenko
2020-05-18 15:22 ` Lukas Wunner
2020-05-18 15:24 ` Lukas Wunner
2020-05-18 16:13 ` Maarten Brock
2020-05-18 16:35 ` Andy Shevchenko
2020-05-18 17:05 ` Maarten Brock
2020-05-18 17:16 ` Andy Shevchenko
2024-01-24 10:29 ` Farouk Bouabid
2020-05-17 21:56 ` [PATCH v3 4/5] serial: 8250: Handle implementations not having TEMT interrupt using em485 Heiko Stuebner
2020-05-18 15:19 ` Andy Shevchenko
2020-05-17 21:56 ` [PATCH v3 5/5] serial: 8250_dw: add em485 support Heiko Stuebner
2020-05-18 15:21 ` Andy Shevchenko
2021-02-02 0:31 ` Giulio Benetti [this message]
2021-02-02 11:22 ` Andy Shevchenko
2021-02-05 17:46 ` Giulio Benetti
2021-02-05 19:29 ` Andy Shevchenko
2022-09-22 9:56 ` [PATCH v3 0/5] serial: 8250: Add rs485 emulation to 8250_dw Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f7881b5-f900-dbbe-3f8d-f990d2bdf5a7@micronovasrl.com \
--to=giulio.benetti@micronovasrl.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=matwey.kornilov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.