From: Paul Durrant <Paul.Durrant@citrix.com>
To: "'Joe Perches'" <joe@perches.com>, Wei Liu <wei.liu2@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] xen-netback: Fix logging message with spurious period after newline
Date: Wed, 6 Dec 2017 09:30:17 +0000 [thread overview]
Message-ID: <1f7b9f45512d4b84b1775efe88a3eb98@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <7884b866cbeba808b63d9de871ace53970561f41.1512542267.git.joe@perches.com>
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: 06 December 2017 06:40
> To: Wei Liu <wei.liu2@citrix.com>; Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] xen-netback: Fix logging message with spurious period
> after newline
>
> Using a period after a newline causes bad output.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> drivers/net/xen-netback/interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-
> netback/interface.c
> index d6dff347f896..78ebe494fef0 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -186,7 +186,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct
> net_device *dev)
> /* Obtain the queue to be used to transmit this packet */
> index = skb_get_queue_mapping(skb);
> if (index >= num_queues) {
> - pr_warn_ratelimited("Invalid queue %hu for packet on
> interface %s\n.",
> + pr_warn_ratelimited("Invalid queue %hu for packet on
> interface %s\n",
> index, vif->dev->name);
> index %= num_queues;
> }
> --
> 2.15.0
next prev parent reply other threads:[~2017-12-06 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 6:40 [PATCH] xen-netback: Fix logging message with spurious period after newline Joe Perches
2017-12-06 9:30 ` Paul Durrant
2017-12-06 9:30 ` Paul Durrant [this message]
2017-12-06 20:10 ` David Miller
2017-12-06 20:10 ` David Miller
2017-12-06 6:40 Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f7b9f45512d4b84b1775efe88a3eb98@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.