From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 117F1C432BE for ; Tue, 24 Aug 2021 13:46:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED98C6103B for ; Tue, 24 Aug 2021 13:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237687AbhHXNq7 (ORCPT ); Tue, 24 Aug 2021 09:46:59 -0400 Received: from foss.arm.com ([217.140.110.172]:35908 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237683AbhHXNqz (ORCPT ); Tue, 24 Aug 2021 09:46:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 008941042; Tue, 24 Aug 2021 06:46:10 -0700 (PDT) Received: from [10.57.15.112] (unknown [10.57.15.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F18B3F5A1; Tue, 24 Aug 2021 06:46:07 -0700 (PDT) Subject: Re: [PATCH v4 15/24] iommu/io-pgtable: Remove non-strict quirk To: Geert Uytterhoeven Cc: Joerg Roedel , Will Deacon , Linux IOMMU , Linux ARM , Linux Kernel Mailing List , suravee.suthikulpanit@amd.com, baolu.lu@linux.intel.com, John Garry , Doug Anderson , rajatja@google.com, chenxiang , Linux-Renesas References: <155b5c621cd8936472e273a8b07a182f62c6c20d.1628682049.git.robin.murphy@arm.com> From: Robin Murphy Message-ID: <1f7de684-c646-cda9-b246-3712f046f2b0@arm.com> Date: Tue, 24 Aug 2021 14:46:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 2021-08-24 14:25, Geert Uytterhoeven wrote: > Hi Robin, > > On Wed, Aug 11, 2021 at 2:24 PM Robin Murphy wrote: >> IO_PGTABLE_QUIRK_NON_STRICT was never a very comfortable fit, since it's >> not a quirk of the pagetable format itself. Now that we have a more >> appropriate way to convey non-strict unmaps, though, this last of the >> non-quirk quirks can also go, and with the flush queue code also now >> enforcing its own ordering we can have a lovely cleanup all round. >> >> Signed-off-by: Robin Murphy > > Thanks for your patch, which is now commit a8e5f04458c4e496 > ("iommu/io-pgtable: Remove non-strict quirk") in iommu/next. > >> --- a/drivers/iommu/io-pgtable-arm-v7s.c >> +++ b/drivers/iommu/io-pgtable-arm-v7s.c >> @@ -700,14 +700,7 @@ static size_t __arm_v7s_unmap(struct arm_v7s_io_pgtable *data, >> ARM_V7S_BLOCK_SIZE(lvl + 1)); >> ptep = iopte_deref(pte[i], lvl, data); >> __arm_v7s_free_table(ptep, lvl + 1, data); >> - } else if (iop->cfg.quirks & IO_PGTABLE_QUIRK_NON_STRICT) { >> - /* >> - * Order the PTE update against queueing the IOVA, to >> - * guarantee that a flush callback from a different CPU >> - * has observed it before the TLBIALL can be issued. >> - */ >> - smp_wmb(); >> - } else { >> + } else if (!gather->queued) { > > If CONFIG_IOMMU_API=n: > > error: ‘struct iommu_iotlb_gather’ has no member named ‘queued’ > > This can be reproduced using e.g. shmobile_defconfig with > CONFIG_IOMMU_SUPPORT=y > CONFIG_IOMMU_IO_PGTABLE_ARMV7S=y > > >> io_pgtable_tlb_add_page(iop, gather, iova, blk_size); >> } >> iova += blk_size; > >> --- a/drivers/iommu/io-pgtable-arm.c >> +++ b/drivers/iommu/io-pgtable-arm.c >> @@ -638,14 +638,7 @@ static size_t __arm_lpae_unmap(struct arm_lpae_io_pgtable *data, >> io_pgtable_tlb_flush_walk(iop, iova + i * size, size, >> ARM_LPAE_GRANULE(data)); >> __arm_lpae_free_pgtable(data, lvl + 1, iopte_deref(pte, data)); >> - } else if (iop->cfg.quirks & IO_PGTABLE_QUIRK_NON_STRICT) { >> - /* >> - * Order the PTE update against queueing the IOVA, to >> - * guarantee that a flush callback from a different CPU >> - * has observed it before the TLBIALL can be issued. >> - */ >> - smp_wmb(); >> - } else { >> + } else if (!gather->queued) { > > If CONFIG_IOMMU_API=n: > > error: ‘struct iommu_iotlb_gather’ has no member named ‘queued’ > > This can be reproduced using e.g. shmobile_defconfig with > CONFIG_IOMMU_SUPPORT=y > CONFIG_IOMMU_IO_PGTABLE_LPAE=y > >> io_pgtable_tlb_add_page(iop, gather, iova + i * size, size); >> } >> > > Perhaps "select IOMMU_API" should be added (moved from individual > drivers) to both IOMMU_IO_PGTABLE_ARMV7S and IOMMU_IO_PGTABLE_LPAE? > Or iommu_iotlb_gather.queued should not be accessed here, or the > access wrapped into a static inline helper function with a dummy for > the CONFIG_IOMMU_API=n case? Those (and worse) should be fixed by this patch: https://lore.kernel.org/linux-iommu/83672ee76f6405c82845a55c148fa836f56fbbc1.1629465282.git.robin.murphy@arm.com/ which apparently hasn't made it to -next yet. Thanks, Robin. > > Gr{oetje,eeting}s, > > Geert > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3767C4338F for ; Tue, 24 Aug 2021 13:46:18 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 297FE61246 for ; Tue, 24 Aug 2021 13:46:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 297FE61246 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E2EAF80EFD; Tue, 24 Aug 2021 13:46:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l2EdNg3EU8dS; Tue, 24 Aug 2021 13:46:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id ADED580CB3; Tue, 24 Aug 2021 13:46:13 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 802C2C0010; Tue, 24 Aug 2021 13:46:13 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 67E86C000E for ; Tue, 24 Aug 2021 13:46:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 50CA440472 for ; Tue, 24 Aug 2021 13:46:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Dl_DF4XXXVQ for ; Tue, 24 Aug 2021 13:46:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp4.osuosl.org (Postfix) with ESMTP id 2706240251 for ; Tue, 24 Aug 2021 13:46:10 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 008941042; Tue, 24 Aug 2021 06:46:10 -0700 (PDT) Received: from [10.57.15.112] (unknown [10.57.15.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F18B3F5A1; Tue, 24 Aug 2021 06:46:07 -0700 (PDT) Subject: Re: [PATCH v4 15/24] iommu/io-pgtable: Remove non-strict quirk To: Geert Uytterhoeven References: <155b5c621cd8936472e273a8b07a182f62c6c20d.1628682049.git.robin.murphy@arm.com> From: Robin Murphy Message-ID: <1f7de684-c646-cda9-b246-3712f046f2b0@arm.com> Date: Tue, 24 Aug 2021 14:46:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Cc: Linux Kernel Mailing List , Doug Anderson , Linux-Renesas , Linux IOMMU , rajatja@google.com, Will Deacon , Linux ARM X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" SGkgR2VlcnQsCgpPbiAyMDIxLTA4LTI0IDE0OjI1LCBHZWVydCBVeXR0ZXJob2V2ZW4gd3JvdGU6 Cj4gSGkgUm9iaW4sCj4gCj4gT24gV2VkLCBBdWcgMTEsIDIwMjEgYXQgMjoyNCBQTSBSb2JpbiBN dXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPiB3cm90ZToKPj4gSU9fUEdUQUJMRV9RVUlSS19O T05fU1RSSUNUIHdhcyBuZXZlciBhIHZlcnkgY29tZm9ydGFibGUgZml0LCBzaW5jZSBpdCdzCj4+ IG5vdCBhIHF1aXJrIG9mIHRoZSBwYWdldGFibGUgZm9ybWF0IGl0c2VsZi4gTm93IHRoYXQgd2Ug aGF2ZSBhIG1vcmUKPj4gYXBwcm9wcmlhdGUgd2F5IHRvIGNvbnZleSBub24tc3RyaWN0IHVubWFw cywgdGhvdWdoLCB0aGlzIGxhc3Qgb2YgdGhlCj4+IG5vbi1xdWlyayBxdWlya3MgY2FuIGFsc28g Z28sIGFuZCB3aXRoIHRoZSBmbHVzaCBxdWV1ZSBjb2RlIGFsc28gbm93Cj4+IGVuZm9yY2luZyBp dHMgb3duIG9yZGVyaW5nIHdlIGNhbiBoYXZlIGEgbG92ZWx5IGNsZWFudXAgYWxsIHJvdW5kLgo+ Pgo+PiBTaWduZWQtb2ZmLWJ5OiBSb2JpbiBNdXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPgo+ IAo+IFRoYW5rcyBmb3IgeW91ciBwYXRjaCwgd2hpY2ggaXMgbm93IGNvbW1pdCBhOGU1ZjA0NDU4 YzRlNDk2Cj4gKCJpb21tdS9pby1wZ3RhYmxlOiBSZW1vdmUgbm9uLXN0cmljdCBxdWlyayIpIGlu IGlvbW11L25leHQuCj4gCj4+IC0tLSBhL2RyaXZlcnMvaW9tbXUvaW8tcGd0YWJsZS1hcm0tdjdz LmMKPj4gKysrIGIvZHJpdmVycy9pb21tdS9pby1wZ3RhYmxlLWFybS12N3MuYwo+PiBAQCAtNzAw LDE0ICs3MDAsNyBAQCBzdGF0aWMgc2l6ZV90IF9fYXJtX3Y3c191bm1hcChzdHJ1Y3QgYXJtX3Y3 c19pb19wZ3RhYmxlICpkYXRhLAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgQVJNX1Y3U19CTE9DS19TSVpFKGx2bCArIDEpKTsKPj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcHRlcCA9IGlvcHRlX2RlcmVmKHB0ZVtpXSwgbHZsLCBk YXRhKTsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX19hcm1fdjdzX2ZyZWVf dGFibGUocHRlcCwgbHZsICsgMSwgZGF0YSk7Cj4+IC0gICAgICAgICAgICAgICAgICAgICAgIH0g ZWxzZSBpZiAoaW9wLT5jZmcucXVpcmtzICYgSU9fUEdUQUJMRV9RVUlSS19OT05fU1RSSUNUKSB7 Cj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLyoKPj4gLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKiBPcmRlciB0aGUgUFRFIHVwZGF0ZSBhZ2FpbnN0IHF1ZXVlaW5n IHRoZSBJT1ZBLCB0bwo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqIGd1YXJh bnRlZSB0aGF0IGEgZmx1c2ggY2FsbGJhY2sgZnJvbSBhIGRpZmZlcmVudCBDUFUKPj4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKiBoYXMgb2JzZXJ2ZWQgaXQgYmVmb3JlIHRoZSBU TEJJQUxMIGNhbiBiZSBpc3N1ZWQuCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICovCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc21wX3dtYigpOwo+PiAtICAg ICAgICAgICAgICAgICAgICAgICB9IGVsc2Ugewo+PiArICAgICAgICAgICAgICAgICAgICAgICB9 IGVsc2UgaWYgKCFnYXRoZXItPnF1ZXVlZCkgewo+IAo+IElmIENPTkZJR19JT01NVV9BUEk9bjoK PiAKPiBlcnJvcjog4oCYc3RydWN0IGlvbW11X2lvdGxiX2dhdGhlcuKAmSBoYXMgbm8gbWVtYmVy IG5hbWVkIOKAmHF1ZXVlZOKAmQo+IAo+IFRoaXMgY2FuIGJlIHJlcHJvZHVjZWQgdXNpbmcgZS5n LiBzaG1vYmlsZV9kZWZjb25maWcgd2l0aAo+ICAgICAgQ09ORklHX0lPTU1VX1NVUFBPUlQ9eQo+ ICAgICAgQ09ORklHX0lPTU1VX0lPX1BHVEFCTEVfQVJNVjdTPXkKPiAKPiAKPj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaW9fcGd0YWJsZV90bGJfYWRkX3BhZ2UoaW9wLCBnYXRo ZXIsIGlvdmEsIGJsa19zaXplKTsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgIH0KPj4gICAg ICAgICAgICAgICAgICAgICAgICAgIGlvdmEgKz0gYmxrX3NpemU7Cj4gCj4+IC0tLSBhL2RyaXZl cnMvaW9tbXUvaW8tcGd0YWJsZS1hcm0uYwo+PiArKysgYi9kcml2ZXJzL2lvbW11L2lvLXBndGFi bGUtYXJtLmMKPj4gQEAgLTYzOCwxNCArNjM4LDcgQEAgc3RhdGljIHNpemVfdCBfX2FybV9scGFl X3VubWFwKHN0cnVjdCBhcm1fbHBhZV9pb19wZ3RhYmxlICpkYXRhLAo+PiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpb19wZ3RhYmxlX3RsYl9mbHVzaF93YWxrKGlvcCwgaW92YSAr IGkgKiBzaXplLCBzaXplLAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIEFSTV9MUEFFX0dSQU5VTEUoZGF0YSkpOwo+PiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBfX2FybV9scGFlX2ZyZWVfcGd0YWJsZShkYXRhLCBs dmwgKyAxLCBpb3B0ZV9kZXJlZihwdGUsIGRhdGEpKTsKPj4gLSAgICAgICAgICAgICAgICAgICAg ICAgfSBlbHNlIGlmIChpb3AtPmNmZy5xdWlya3MgJiBJT19QR1RBQkxFX1FVSVJLX05PTl9TVFJJ Q1QpIHsKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvKgo+PiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAqIE9yZGVyIHRoZSBQVEUgdXBkYXRlIGFnYWluc3QgcXVl dWVpbmcgdGhlIElPVkEsIHRvCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICog Z3VhcmFudGVlIHRoYXQgYSBmbHVzaCBjYWxsYmFjayBmcm9tIGEgZGlmZmVyZW50IENQVQo+PiAt ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqIGhhcyBvYnNlcnZlZCBpdCBiZWZvcmUg dGhlIFRMQklBTEwgY2FuIGJlIGlzc3VlZC4KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKi8KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzbXBfd21iKCk7Cj4+ IC0gICAgICAgICAgICAgICAgICAgICAgIH0gZWxzZSB7Cj4+ICsgICAgICAgICAgICAgICAgICAg ICAgIH0gZWxzZSBpZiAoIWdhdGhlci0+cXVldWVkKSB7Cj4gCj4gSWYgQ09ORklHX0lPTU1VX0FQ ST1uOgo+IAo+IGVycm9yOiDigJhzdHJ1Y3QgaW9tbXVfaW90bGJfZ2F0aGVy4oCZIGhhcyBubyBt ZW1iZXIgbmFtZWQg4oCYcXVldWVk4oCZCj4gCj4gVGhpcyBjYW4gYmUgcmVwcm9kdWNlZCB1c2lu ZyBlLmcuIHNobW9iaWxlX2RlZmNvbmZpZyB3aXRoCj4gICAgICBDT05GSUdfSU9NTVVfU1VQUE9S VD15Cj4gICAgICBDT05GSUdfSU9NTVVfSU9fUEdUQUJMRV9MUEFFPXkKPiAKPj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaW9fcGd0YWJsZV90bGJfYWRkX3BhZ2UoaW9wLCBnYXRo ZXIsIGlvdmEgKyBpICogc2l6ZSwgc2l6ZSk7Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICB9 Cj4+Cj4gCj4gUGVyaGFwcyAic2VsZWN0IElPTU1VX0FQSSIgc2hvdWxkIGJlIGFkZGVkIChtb3Zl ZCBmcm9tIGluZGl2aWR1YWwKPiBkcml2ZXJzKSB0byBib3RoIElPTU1VX0lPX1BHVEFCTEVfQVJN VjdTIGFuZCBJT01NVV9JT19QR1RBQkxFX0xQQUU/Cj4gT3IgaW9tbXVfaW90bGJfZ2F0aGVyLnF1 ZXVlZCBzaG91bGQgbm90IGJlIGFjY2Vzc2VkIGhlcmUsIG9yIHRoZQo+IGFjY2VzcyB3cmFwcGVk IGludG8gYSBzdGF0aWMgaW5saW5lIGhlbHBlciBmdW5jdGlvbiB3aXRoIGEgZHVtbXkgZm9yCj4g dGhlIENPTkZJR19JT01NVV9BUEk9biBjYXNlPwoKVGhvc2UgKGFuZCB3b3JzZSkgc2hvdWxkIGJl IGZpeGVkIGJ5IHRoaXMgcGF0Y2g6CgpodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1pb21t dS84MzY3MmVlNzZmNjQwNWM4Mjg0NWE1NWMxNDhmYTgzNmY1NmZiYmMxLjE2Mjk0NjUyODIuZ2l0 LnJvYmluLm11cnBoeUBhcm0uY29tLwoKd2hpY2ggYXBwYXJlbnRseSBoYXNuJ3QgbWFkZSBpdCB0 byAtbmV4dCB5ZXQuCgpUaGFua3MsClJvYmluLgoKPiAKPiBHcntvZXRqZSxlZXRpbmd9cywKPiAK PiAgICAgICAgICAgICAgICAgICAgICAgICAgR2VlcnQKPiAKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3Rz LmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 119C3C432BE for ; Tue, 24 Aug 2021 13:47:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D576C6103B for ; Tue, 24 Aug 2021 13:47:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D576C6103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1W6lZI3vjX1grNmVOvOQiMeskX/NqhTek1Ez4SfgrKk=; b=w6DiPqDwQ0swYbnn60bObT+e0e malxD/CPq/84qNbOqRXSwnT3fsMFCt8rnRY3GFLjuMdPO28WNqmFsE11a0h+fteLaYKhNK8Fj8C0C euOWWKPqTO041GsPSm5JyAy1KM+CFs/uwQGUCVDmrzAR8cmMZw0zJ97pfWW5wwZztTDs5yn68XB6F NHU7tx5uxz1bdSCjXxCZk7xlc0LpId/tqiuH0jD0TALaKOvl2/FGckA/WI7r0iTIv52qYNXRQPQBi ZUdXvBoh2zmHoUDkBwT5gSztFFU3+ZO+3HDo5x6gH65ZsWpONsFNeWSd0MaZMHIhLp6qZ6rZRiwmS 5fbtlG9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIWku-003HtN-DZ; Tue, 24 Aug 2021 13:46:20 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIWkq-003Hri-08 for linux-arm-kernel@lists.infradead.org; Tue, 24 Aug 2021 13:46:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 008941042; Tue, 24 Aug 2021 06:46:10 -0700 (PDT) Received: from [10.57.15.112] (unknown [10.57.15.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F18B3F5A1; Tue, 24 Aug 2021 06:46:07 -0700 (PDT) Subject: Re: [PATCH v4 15/24] iommu/io-pgtable: Remove non-strict quirk To: Geert Uytterhoeven Cc: Joerg Roedel , Will Deacon , Linux IOMMU , Linux ARM , Linux Kernel Mailing List , suravee.suthikulpanit@amd.com, baolu.lu@linux.intel.com, John Garry , Doug Anderson , rajatja@google.com, chenxiang , Linux-Renesas References: <155b5c621cd8936472e273a8b07a182f62c6c20d.1628682049.git.robin.murphy@arm.com> From: Robin Murphy Message-ID: <1f7de684-c646-cda9-b246-3712f046f2b0@arm.com> Date: Tue, 24 Aug 2021 14:46:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_064616_196866_5542D94B X-CRM114-Status: GOOD ( 24.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgR2VlcnQsCgpPbiAyMDIxLTA4LTI0IDE0OjI1LCBHZWVydCBVeXR0ZXJob2V2ZW4gd3JvdGU6 Cj4gSGkgUm9iaW4sCj4gCj4gT24gV2VkLCBBdWcgMTEsIDIwMjEgYXQgMjoyNCBQTSBSb2JpbiBN dXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPiB3cm90ZToKPj4gSU9fUEdUQUJMRV9RVUlSS19O T05fU1RSSUNUIHdhcyBuZXZlciBhIHZlcnkgY29tZm9ydGFibGUgZml0LCBzaW5jZSBpdCdzCj4+ IG5vdCBhIHF1aXJrIG9mIHRoZSBwYWdldGFibGUgZm9ybWF0IGl0c2VsZi4gTm93IHRoYXQgd2Ug aGF2ZSBhIG1vcmUKPj4gYXBwcm9wcmlhdGUgd2F5IHRvIGNvbnZleSBub24tc3RyaWN0IHVubWFw cywgdGhvdWdoLCB0aGlzIGxhc3Qgb2YgdGhlCj4+IG5vbi1xdWlyayBxdWlya3MgY2FuIGFsc28g Z28sIGFuZCB3aXRoIHRoZSBmbHVzaCBxdWV1ZSBjb2RlIGFsc28gbm93Cj4+IGVuZm9yY2luZyBp dHMgb3duIG9yZGVyaW5nIHdlIGNhbiBoYXZlIGEgbG92ZWx5IGNsZWFudXAgYWxsIHJvdW5kLgo+ Pgo+PiBTaWduZWQtb2ZmLWJ5OiBSb2JpbiBNdXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPgo+ IAo+IFRoYW5rcyBmb3IgeW91ciBwYXRjaCwgd2hpY2ggaXMgbm93IGNvbW1pdCBhOGU1ZjA0NDU4 YzRlNDk2Cj4gKCJpb21tdS9pby1wZ3RhYmxlOiBSZW1vdmUgbm9uLXN0cmljdCBxdWlyayIpIGlu IGlvbW11L25leHQuCj4gCj4+IC0tLSBhL2RyaXZlcnMvaW9tbXUvaW8tcGd0YWJsZS1hcm0tdjdz LmMKPj4gKysrIGIvZHJpdmVycy9pb21tdS9pby1wZ3RhYmxlLWFybS12N3MuYwo+PiBAQCAtNzAw LDE0ICs3MDAsNyBAQCBzdGF0aWMgc2l6ZV90IF9fYXJtX3Y3c191bm1hcChzdHJ1Y3QgYXJtX3Y3 c19pb19wZ3RhYmxlICpkYXRhLAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgQVJNX1Y3U19CTE9DS19TSVpFKGx2bCArIDEpKTsKPj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcHRlcCA9IGlvcHRlX2RlcmVmKHB0ZVtpXSwgbHZsLCBk YXRhKTsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX19hcm1fdjdzX2ZyZWVf dGFibGUocHRlcCwgbHZsICsgMSwgZGF0YSk7Cj4+IC0gICAgICAgICAgICAgICAgICAgICAgIH0g ZWxzZSBpZiAoaW9wLT5jZmcucXVpcmtzICYgSU9fUEdUQUJMRV9RVUlSS19OT05fU1RSSUNUKSB7 Cj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLyoKPj4gLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKiBPcmRlciB0aGUgUFRFIHVwZGF0ZSBhZ2FpbnN0IHF1ZXVlaW5n IHRoZSBJT1ZBLCB0bwo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqIGd1YXJh bnRlZSB0aGF0IGEgZmx1c2ggY2FsbGJhY2sgZnJvbSBhIGRpZmZlcmVudCBDUFUKPj4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKiBoYXMgb2JzZXJ2ZWQgaXQgYmVmb3JlIHRoZSBU TEJJQUxMIGNhbiBiZSBpc3N1ZWQuCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICovCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc21wX3dtYigpOwo+PiAtICAg ICAgICAgICAgICAgICAgICAgICB9IGVsc2Ugewo+PiArICAgICAgICAgICAgICAgICAgICAgICB9 IGVsc2UgaWYgKCFnYXRoZXItPnF1ZXVlZCkgewo+IAo+IElmIENPTkZJR19JT01NVV9BUEk9bjoK PiAKPiBlcnJvcjog4oCYc3RydWN0IGlvbW11X2lvdGxiX2dhdGhlcuKAmSBoYXMgbm8gbWVtYmVy IG5hbWVkIOKAmHF1ZXVlZOKAmQo+IAo+IFRoaXMgY2FuIGJlIHJlcHJvZHVjZWQgdXNpbmcgZS5n LiBzaG1vYmlsZV9kZWZjb25maWcgd2l0aAo+ICAgICAgQ09ORklHX0lPTU1VX1NVUFBPUlQ9eQo+ ICAgICAgQ09ORklHX0lPTU1VX0lPX1BHVEFCTEVfQVJNVjdTPXkKPiAKPiAKPj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaW9fcGd0YWJsZV90bGJfYWRkX3BhZ2UoaW9wLCBnYXRo ZXIsIGlvdmEsIGJsa19zaXplKTsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgIH0KPj4gICAg ICAgICAgICAgICAgICAgICAgICAgIGlvdmEgKz0gYmxrX3NpemU7Cj4gCj4+IC0tLSBhL2RyaXZl cnMvaW9tbXUvaW8tcGd0YWJsZS1hcm0uYwo+PiArKysgYi9kcml2ZXJzL2lvbW11L2lvLXBndGFi bGUtYXJtLmMKPj4gQEAgLTYzOCwxNCArNjM4LDcgQEAgc3RhdGljIHNpemVfdCBfX2FybV9scGFl X3VubWFwKHN0cnVjdCBhcm1fbHBhZV9pb19wZ3RhYmxlICpkYXRhLAo+PiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpb19wZ3RhYmxlX3RsYl9mbHVzaF93YWxrKGlvcCwgaW92YSAr IGkgKiBzaXplLCBzaXplLAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIEFSTV9MUEFFX0dSQU5VTEUoZGF0YSkpOwo+PiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBfX2FybV9scGFlX2ZyZWVfcGd0YWJsZShkYXRhLCBs dmwgKyAxLCBpb3B0ZV9kZXJlZihwdGUsIGRhdGEpKTsKPj4gLSAgICAgICAgICAgICAgICAgICAg ICAgfSBlbHNlIGlmIChpb3AtPmNmZy5xdWlya3MgJiBJT19QR1RBQkxFX1FVSVJLX05PTl9TVFJJ Q1QpIHsKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvKgo+PiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAqIE9yZGVyIHRoZSBQVEUgdXBkYXRlIGFnYWluc3QgcXVl dWVpbmcgdGhlIElPVkEsIHRvCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICog Z3VhcmFudGVlIHRoYXQgYSBmbHVzaCBjYWxsYmFjayBmcm9tIGEgZGlmZmVyZW50IENQVQo+PiAt ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqIGhhcyBvYnNlcnZlZCBpdCBiZWZvcmUg dGhlIFRMQklBTEwgY2FuIGJlIGlzc3VlZC4KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKi8KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzbXBfd21iKCk7Cj4+ IC0gICAgICAgICAgICAgICAgICAgICAgIH0gZWxzZSB7Cj4+ICsgICAgICAgICAgICAgICAgICAg ICAgIH0gZWxzZSBpZiAoIWdhdGhlci0+cXVldWVkKSB7Cj4gCj4gSWYgQ09ORklHX0lPTU1VX0FQ ST1uOgo+IAo+IGVycm9yOiDigJhzdHJ1Y3QgaW9tbXVfaW90bGJfZ2F0aGVy4oCZIGhhcyBubyBt ZW1iZXIgbmFtZWQg4oCYcXVldWVk4oCZCj4gCj4gVGhpcyBjYW4gYmUgcmVwcm9kdWNlZCB1c2lu ZyBlLmcuIHNobW9iaWxlX2RlZmNvbmZpZyB3aXRoCj4gICAgICBDT05GSUdfSU9NTVVfU1VQUE9S VD15Cj4gICAgICBDT05GSUdfSU9NTVVfSU9fUEdUQUJMRV9MUEFFPXkKPiAKPj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaW9fcGd0YWJsZV90bGJfYWRkX3BhZ2UoaW9wLCBnYXRo ZXIsIGlvdmEgKyBpICogc2l6ZSwgc2l6ZSk7Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICB9 Cj4+Cj4gCj4gUGVyaGFwcyAic2VsZWN0IElPTU1VX0FQSSIgc2hvdWxkIGJlIGFkZGVkIChtb3Zl ZCBmcm9tIGluZGl2aWR1YWwKPiBkcml2ZXJzKSB0byBib3RoIElPTU1VX0lPX1BHVEFCTEVfQVJN VjdTIGFuZCBJT01NVV9JT19QR1RBQkxFX0xQQUU/Cj4gT3IgaW9tbXVfaW90bGJfZ2F0aGVyLnF1 ZXVlZCBzaG91bGQgbm90IGJlIGFjY2Vzc2VkIGhlcmUsIG9yIHRoZQo+IGFjY2VzcyB3cmFwcGVk IGludG8gYSBzdGF0aWMgaW5saW5lIGhlbHBlciBmdW5jdGlvbiB3aXRoIGEgZHVtbXkgZm9yCj4g dGhlIENPTkZJR19JT01NVV9BUEk9biBjYXNlPwoKVGhvc2UgKGFuZCB3b3JzZSkgc2hvdWxkIGJl IGZpeGVkIGJ5IHRoaXMgcGF0Y2g6CgpodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1pb21t dS84MzY3MmVlNzZmNjQwNWM4Mjg0NWE1NWMxNDhmYTgzNmY1NmZiYmMxLjE2Mjk0NjUyODIuZ2l0 LnJvYmluLm11cnBoeUBhcm0uY29tLwoKd2hpY2ggYXBwYXJlbnRseSBoYXNuJ3QgbWFkZSBpdCB0 byAtbmV4dCB5ZXQuCgpUaGFua3MsClJvYmluLgoKPiAKPiBHcntvZXRqZSxlZXRpbmd9cywKPiAK PiAgICAgICAgICAgICAgICAgICAgICAgICAgR2VlcnQKPiAKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK