From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH] nvme: change cq_vector to a bool and set to true after request_irq
Date: Sun, 23 Apr 2017 18:16:54 +0300 [thread overview]
Message-ID: <1f823755-d0d3-7294-8cc5-8ec773a544b2@grimberg.me> (raw)
In-Reply-To: <20170423074710.GB20750@lst.de>
>> + bool cq_vector;
>
> I think the field is badly misnamed now. Something like a flags
> field with an NVME_PCI_Q_IS_ALIVE flag might be more suitable now?
Agree.
next prev parent reply other threads:[~2017-04-23 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 23:24 [PATCH] nvme: change cq_vector to a bool and set to true after request_irq Sandeep Mann
2017-04-23 7:47 ` Christoph Hellwig
2017-04-23 15:16 ` Sagi Grimberg [this message]
2017-04-24 20:25 ` Sandeep Mann
2017-04-25 7:18 ` Christoph Hellwig
2017-05-10 17:16 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2017-04-21 23:23 No subject Sandeep Mann
2017-04-21 23:23 ` [PATCH] nvme: change cq_vector to a bool and set to true after request_irq Sandeep Mann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f823755-d0d3-7294-8cc5-8ec773a544b2@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.