From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: Re: [PATCH v4 17/23] drm/ast: Provide ddc symlink in connector sysfs directory Date: Thu, 11 Jul 2019 19:27:04 +0200 Message-ID: <1f8c9d07-2e53-a3b3-0c69-92715fefbc46@suse.de> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1150888931==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Pietrasiewicz , dri-devel@lists.freedesktop.org Cc: Sam Ravnborg , Neil Armstrong , Maxime Ripard , Liviu Dudau , Douglas Anderson , Thierry Reding , Laurent Pinchart , kernel@collabora.com, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Vincent Abriou , Krzysztof Kozlowski , Jonathan Hunter , David Airlie , Chen-Yu Tsai , Kukjin Kim , NXP Linux Team , Dave Airlie , intel-gfx@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, Jonas Karlman , linux-arm-msm@vger.kernel.org, Alexios Zavras , Mamta List-Id: linux-tegra@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1150888931== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4VEqS7qdrTlI9mYl0mFD0hof8AKsK115I" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4VEqS7qdrTlI9mYl0mFD0hof8AKsK115I Content-Type: multipart/mixed; boundary="kvu6iu4v0s2fkqVYpi2Nm42RkhKDkBlvT"; protected-headers="v1" From: Thomas Zimmermann To: Andrzej Pietrasiewicz , dri-devel@lists.freedesktop.org Cc: kernel@collabora.com, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , Dave Airlie , Andrzej Hajda , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Sean Paul , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , CK Hu , Matthias Brugger , Rob Clark , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Benjamin Gaignard , Vincent Abriou , Chen-Yu Tsai , Thierry Reding , Jonathan Hunter , Jyri Sarha , Tomi Valkeinen , Eric Anholt , Sam Ravnborg , Liviu Dudau , Huang Rui , Gerd Hoffmann , "Y.C. Chen" , Neil Armstrong , Douglas Anderson , Jonas Karlman , Jernej Skrabec , Thomas Gleixner , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Chris Wilson , Shashank Sharma , Ramalingam C , Alexios Zavras , Enrico Weigelt , Mamta Shukla , Todor Tomov , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org Message-ID: <1f8c9d07-2e53-a3b3-0c69-92715fefbc46@suse.de> Subject: Re: [PATCH v4 17/23] drm/ast: Provide ddc symlink in connector sysfs directory References: In-Reply-To: --kvu6iu4v0s2fkqVYpi2Nm42RkhKDkBlvT Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Acked-by: Thomas Zimmermann Am 11.07.19 um 13:26 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. >=20 > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/ast/ast_mode.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_m= ode.c > index ffccbef962a4..1ca9bc4aa3bb 100644 > --- a/drivers/gpu/drm/ast/ast_mode.c > +++ b/drivers/gpu/drm/ast/ast_mode.c > @@ -890,6 +890,11 @@ static int ast_connector_init(struct drm_device *d= ev) > return -ENOMEM; > =20 > connector =3D &ast_connector->base; > + ast_connector->i2c =3D ast_i2c_create(dev); > + if (!ast_connector->i2c) > + DRM_ERROR("failed to add ddc bus for connector\n"); > + > + connector->ddc =3D &ast_connector->i2c->adapter; > drm_connector_init(dev, connector, &ast_connector_funcs, DRM_MODE_CON= NECTOR_VGA); > =20 > drm_connector_helper_add(connector, &ast_connector_helper_funcs); > @@ -904,10 +909,6 @@ static int ast_connector_init(struct drm_device *d= ev) > encoder =3D list_first_entry(&dev->mode_config.encoder_list, struct d= rm_encoder, head); > drm_connector_attach_encoder(connector, encoder); > =20 > - ast_connector->i2c =3D ast_i2c_create(dev); > - if (!ast_connector->i2c) > - DRM_ERROR("failed to add ddc bus for connector\n"); > - > return 0; > } > =20 >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --kvu6iu4v0s2fkqVYpi2Nm42RkhKDkBlvT-- --4VEqS7qdrTlI9mYl0mFD0hof8AKsK115I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl0ncWgACgkQaA3BHVML eiPAyAf/YFgWQ1VkykOgkdx9nM3V9OMIl4P0VvUBnxUcPXIcSB7LlPK3dAi2+yXy +7oNtKQruYSFk1867Y+Z4oyCxa2kKojeJCeyOmGrytyxIdUbVlRwv9HAPzSXZIey owlceG8WA9p54+Vp6qeOtjZ9hP4HiYJuUgVsKNTMWzVQuP+gw8oeXTlNAEGzzvNy FMgBbHySEfxMx0ziW3MBf5/1bFMXoIq6jSe1vwKMB5r3I4TFbVzWxUOhDKpLp5bv WR6AVRVf6MJzcH7Fu9wxujURzZI1TyMiHectc+MmFOfHieFU1ehbSYGrYaqCQexw 4p09wd9Yua4fDLAv70vvmm5uFRnk1w== =bNp0 -----END PGP SIGNATURE----- --4VEqS7qdrTlI9mYl0mFD0hof8AKsK115I-- --===============1150888931== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1150888931==--