From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D77C433DF for ; Tue, 7 Jul 2020 12:56:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B629A20708 for ; Tue, 7 Jul 2020 12:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbgGGM4t (ORCPT ); Tue, 7 Jul 2020 08:56:49 -0400 Received: from foss.arm.com ([217.140.110.172]:47592 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726900AbgGGM4t (ORCPT ); Tue, 7 Jul 2020 08:56:49 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 17A1FC0A; Tue, 7 Jul 2020 05:56:49 -0700 (PDT) Received: from [192.168.0.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E67833F71E; Tue, 7 Jul 2020 05:56:46 -0700 (PDT) Subject: Re: [PATCH v3 07/17] KVM: arm64: hyp: Use ctxt_sys_reg/__vcpu_sys_reg instead of raw sys_regs access To: Marc Zyngier , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Cc: Andre Przywara , Christoffer Dall , Dave Martin , Jintack Lim , George Cherian , "Zengtao (B)" , Andrew Scull , Will Deacon , Mark Rutland , James Morse , Julien Thierry , Suzuki K Poulose , kernel-team@android.com References: <20200706125425.1671020-1-maz@kernel.org> <20200706125425.1671020-8-maz@kernel.org> From: Alexandru Elisei Message-ID: <1f97200e-7a0a-aae6-637b-db84481abfb9@arm.com> Date: Tue, 7 Jul 2020 13:57:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200706125425.1671020-8-maz@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi, On 7/6/20 1:54 PM, Marc Zyngier wrote: > Switch the hypervisor code to using ctxt_sys_reg/__vcpu_sys_reg instead > of raw sys_regs accesses. No intended functionnal change. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 2 +- > arch/arm64/kvm/hyp/include/hyp/debug-sr.h | 4 +- > arch/arm64/kvm/hyp/include/hyp/switch.h | 7 +- > arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h | 110 ++++++++++----------- > arch/arm64/kvm/hyp/nvhe/switch.c | 4 +- > 5 files changed, 62 insertions(+), 65 deletions(-) Looks fine to me, checked that the correct function is used (either __vcpu_sys_reg, or ctxt_sys_reg), and that the registers names match. Also did a compile test to make extra sure I didn't miss anything: Reviewed-by: Alexandru Elisei Thanks, Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 169A3C433DF for ; Tue, 7 Jul 2020 12:56:56 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 9E52520708 for ; Tue, 7 Jul 2020 12:56:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E52520708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DEF1B4B114; Tue, 7 Jul 2020 08:56:54 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yPFS9RiuwAOW; Tue, 7 Jul 2020 08:56:53 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CC1514B11E; Tue, 7 Jul 2020 08:56:53 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0C4294B115 for ; Tue, 7 Jul 2020 08:56:53 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xwi6ipx1WBUA for ; Tue, 7 Jul 2020 08:56:50 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3D17A4B114 for ; Tue, 7 Jul 2020 08:56:50 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 17A1FC0A; Tue, 7 Jul 2020 05:56:49 -0700 (PDT) Received: from [192.168.0.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E67833F71E; Tue, 7 Jul 2020 05:56:46 -0700 (PDT) Subject: Re: [PATCH v3 07/17] KVM: arm64: hyp: Use ctxt_sys_reg/__vcpu_sys_reg instead of raw sys_regs access To: Marc Zyngier , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org References: <20200706125425.1671020-1-maz@kernel.org> <20200706125425.1671020-8-maz@kernel.org> From: Alexandru Elisei Message-ID: <1f97200e-7a0a-aae6-637b-db84481abfb9@arm.com> Date: Tue, 7 Jul 2020 13:57:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200706125425.1671020-8-maz@kernel.org> Content-Language: en-US Cc: kernel-team@android.com, Andre Przywara , Dave Martin , George Cherian , "Zengtao \(B\)" , Will Deacon X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi, On 7/6/20 1:54 PM, Marc Zyngier wrote: > Switch the hypervisor code to using ctxt_sys_reg/__vcpu_sys_reg instead > of raw sys_regs accesses. No intended functionnal change. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 2 +- > arch/arm64/kvm/hyp/include/hyp/debug-sr.h | 4 +- > arch/arm64/kvm/hyp/include/hyp/switch.h | 7 +- > arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h | 110 ++++++++++----------- > arch/arm64/kvm/hyp/nvhe/switch.c | 4 +- > 5 files changed, 62 insertions(+), 65 deletions(-) Looks fine to me, checked that the correct function is used (either __vcpu_sys_reg, or ctxt_sys_reg), and that the registers names match. Also did a compile test to make extra sure I didn't miss anything: Reviewed-by: Alexandru Elisei Thanks, Alex _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 923DFC433DF for ; Tue, 7 Jul 2020 12:58:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DD1E20773 for ; Tue, 7 Jul 2020 12:58:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tgcGe6gr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DD1E20773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=faD3OBb5JoHZXPrkwcnsA+iXCU5T0kb+yJ5uTmIQ/oM=; b=tgcGe6grylt5o08NvOkb0PW1K do6LtBGYCR8ZqmrNfFOywNutctxjR3Q9ZSNqlgykYQSe1DC5DW64OTTrHJwA0JdO5TZRHjZzfNWj1 i46xL+bxrb9PS+fM/dZfVKea8hLq33nwa8dIEwEhTK0apeFIhmBfwGFzU0GzC8DdHYucpQkWGEhrF xIpAzYptqsHFIHDUakE2IIqpSxqMNnW15g3WAlDpUXpsD394EcX71cXI9QCP4BSrZ8ntVYBs7uDi4 H7N2/7JiCdaAf8mWtzVzRJemzLs1JeLlL3/lxxWCZE1MlfgrWEYxs2wWvdG1TrjrBK8Uw3cqJ6hUv PKkT2EKmA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsn9c-0006FJ-L3; Tue, 07 Jul 2020 12:56:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsn9a-0006Ec-AK for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 12:56:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 17A1FC0A; Tue, 7 Jul 2020 05:56:49 -0700 (PDT) Received: from [192.168.0.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E67833F71E; Tue, 7 Jul 2020 05:56:46 -0700 (PDT) Subject: Re: [PATCH v3 07/17] KVM: arm64: hyp: Use ctxt_sys_reg/__vcpu_sys_reg instead of raw sys_regs access To: Marc Zyngier , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org References: <20200706125425.1671020-1-maz@kernel.org> <20200706125425.1671020-8-maz@kernel.org> From: Alexandru Elisei Message-ID: <1f97200e-7a0a-aae6-637b-db84481abfb9@arm.com> Date: Tue, 7 Jul 2020 13:57:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200706125425.1671020-8-maz@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_085654_416041_FE0FC82E X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kernel-team@android.com, Suzuki K Poulose , Andre Przywara , Christoffer Dall , Dave Martin , George Cherian , James Morse , Andrew Scull , "Zengtao \(B\)" , Will Deacon , Jintack Lim , Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 7/6/20 1:54 PM, Marc Zyngier wrote: > Switch the hypervisor code to using ctxt_sys_reg/__vcpu_sys_reg instead > of raw sys_regs accesses. No intended functionnal change. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/kvm_host.h | 2 +- > arch/arm64/kvm/hyp/include/hyp/debug-sr.h | 4 +- > arch/arm64/kvm/hyp/include/hyp/switch.h | 7 +- > arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h | 110 ++++++++++----------- > arch/arm64/kvm/hyp/nvhe/switch.c | 4 +- > 5 files changed, 62 insertions(+), 65 deletions(-) Looks fine to me, checked that the correct function is used (either __vcpu_sys_reg, or ctxt_sys_reg), and that the registers names match. Also did a compile test to make extra sure I didn't miss anything: Reviewed-by: Alexandru Elisei Thanks, Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel