From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63DA2C43219 for ; Sat, 19 Nov 2022 12:59:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232544AbiKSM7D (ORCPT ); Sat, 19 Nov 2022 07:59:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbiKSM7A (ORCPT ); Sat, 19 Nov 2022 07:59:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B81C19E96E for ; Sat, 19 Nov 2022 04:57:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668862658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=grM0b1rhOZ7QNvsVUn5HC172wdCzsZ8WYGZE4EbRE1g=; b=TA2ZhypJkLttZrVDNgho5oqEY7iXodK8V59cy26JLeFRk9H7FsII0z7+LfuKQNPE4nqezR oW9fdXudPjHRRYlXLDpw/9cX/1V4Tc0HP7vIYwl2PrxGaVzPT56JJCo5WFLAL6Ed4RcC2o bOFQOT4DI/eDaUVY0u5xdwr/kMpAJsg= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-410-JDytsuWgPra4_pXQmCYtZA-1; Sat, 19 Nov 2022 07:57:35 -0500 X-MC-Unique: JDytsuWgPra4_pXQmCYtZA-1 Received: by mail-ed1-f71.google.com with SMTP id b13-20020a056402350d00b00464175c3f1eso4112800edd.11 for ; Sat, 19 Nov 2022 04:57:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=grM0b1rhOZ7QNvsVUn5HC172wdCzsZ8WYGZE4EbRE1g=; b=zv4oRE3VRkIltVnpcSqHQl0wHR3jOWr+i4aBtTTXgOhE0JJ+hal5NUQYpbVnubyi8I RYwg4bQAcpVcXHD5RX9l96fMFbbi/aeUvmBgKJPASSz/qEPdnEMIBUMGw3yWQy3p8azj PYyWPZOSDGpgst5FiucyR9QWNLqWEPMFMhqGaBH9YJ7zSWSRxlG3PhaHnqv8OnS6U+fd FqtKvllN+KW+finmwG0FVm/3VG7gmLoCm+Nag21bTaEbedS+Vy7iZjIK06DMBv6lqg5G mjO+GuM30IYTmyZwm3SY+Lb4FGxvmXaXibnIKAiSWDUHnWQBadGUDr8rNL4sEX3NxxLF 6+zg== X-Gm-Message-State: ANoB5pkfe+ahdbqmFjPiswCvg59+Z72Nhy0x3SO0QfHqMjZ2q71BGHAy 9tN9/iO7+wSoZF3qaRoVYfHV63gtSgBap6NQ+Rh4q3Tz14D5pkVANw1egzI7LaSG77R/uGbQSds tQh2rmUD8mnpJ8DT1q+2eE4Zb X-Received: by 2002:a05:6402:b1a:b0:469:15eb:71b5 with SMTP id bm26-20020a0564020b1a00b0046915eb71b5mr4800362edb.312.1668862654414; Sat, 19 Nov 2022 04:57:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf5IJAKQ8WPZChDMi40oyMPY0++sRl542avbymdZdHQ9tGoMVyhva9Ayksdzq9SX0awFf2h8tg== X-Received: by 2002:a05:6402:b1a:b0:469:15eb:71b5 with SMTP id bm26-20020a0564020b1a00b0046915eb71b5mr4800349edb.312.1668862654199; Sat, 19 Nov 2022 04:57:34 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id gq20-20020a170906e25400b007aece68483csm2830602ejb.193.2022.11.19.04.57.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 04:57:33 -0800 (PST) Message-ID: <1fb89e36-366b-b708-7b25-351286b75253@redhat.com> Date: Sat, 19 Nov 2022 13:57:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 241/606] Input: goodix - Convert to i2c's .probe_new() Content-Language: en-US, nl To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Bastien Nocera , Dmitry Torokhov Cc: linux-i2c@vger.kernel.org, kernel@pengutronix.de, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-242-uwe@kleine-koenig.org> From: Hans de Goede In-Reply-To: <20221118224540.619276-242-uwe@kleine-koenig.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/18/22 23:39, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/input/touchscreen/goodix.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c > index c281e49826c2..8a0a8078de8f 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -1282,8 +1282,7 @@ static void goodix_disable_regulators(void *arg) > regulator_disable(ts->avdd28); > } > > -static int goodix_ts_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int goodix_ts_probe(struct i2c_client *client) > { > struct goodix_ts_data *ts; > const char *cfg_name; > @@ -1537,7 +1536,7 @@ MODULE_DEVICE_TABLE(of, goodix_of_match); > #endif > > static struct i2c_driver goodix_ts_driver = { > - .probe = goodix_ts_probe, > + .probe_new = goodix_ts_probe, > .remove = goodix_ts_remove, > .id_table = goodix_ts_id, > .driver = {