All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: "Hervé Poussineau" <hpoussin@reactos.org>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] vvfat: allow spaces in file names
Date: Sun, 4 Sep 2022 15:45:58 +0200	[thread overview]
Message-ID: <1fcb4065-c490-2ab6-8951-4b39be243e75@amsat.org> (raw)
In-Reply-To: <20220903162302.3176003-3-hpoussin@reactos.org>

On 3/9/22 18:23, Hervé Poussineau wrote:
> In R/W mode, files with spaces were never created on host side.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1176
> Fixes: c79e243ed67683d6d06692bd7040f7394da178b0
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>   block/vvfat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 35057a51c67..9d877028573 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -499,7 +499,7 @@ static bool valid_filename(const unsigned char *name)
>                 (c >= 'A' && c <= 'Z') ||
>                 (c >= 'a' && c <= 'z') ||
>                 c > 127 ||
> -              strchr("$%'-_@~`!(){}^#&.+,;=[]", c) != NULL))
> +              strchr(" $%'-_@~`!(){}^#&.+,;=[]", c) != NULL))
>           {
>               return false;
>           }

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



  reply	other threads:[~2022-09-04 13:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-03 16:23 [PATCH 0/2] Fix some problems with vvfat in R/W mode Hervé Poussineau
2022-09-03 16:23 ` [PATCH 1/2] vvfat: allow some writes to bootsector Hervé Poussineau
2022-09-29 14:10   ` Kevin Wolf
2022-09-29 19:53     ` Hervé Poussineau
2022-09-30  9:57       ` Kevin Wolf
2022-09-03 16:23 ` [PATCH 2/2] vvfat: allow spaces in file names Hervé Poussineau
2022-09-04 13:45   ` Philippe Mathieu-Daudé via [this message]
2022-09-29 14:24   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fcb4065-c490-2ab6-8951-4b39be243e75@amsat.org \
    --to=qemu-devel@nongnu.org \
    --cc=f4bug@amsat.org \
    --cc=hpoussin@reactos.org \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.