From: Felix Kuehling <felix.kuehling@amd.com>
To: amd-gfx@lists.freedesktop.org, Yong Zhao <yong.zhao@amd.com>
Subject: Re: [PATCH] drm/amdkfd: Fix a compiling warning
Date: Fri, 10 Jan 2020 19:46:26 -0500 [thread overview]
Message-ID: <1fd13b0e-f2f7-75fc-7df6-01f1c023f6fa@amd.com> (raw)
In-Reply-To: <20200111004032.30224-1-Yong.Zhao@amd.com>
On 2020-01-10 7:40 p.m., Yong Zhao wrote:
> The warning was introduced in
>
> commit b4267f2e687ff5e0402ab915c9a4d47f9a4eb73e
> Author: Yong Zhao <Yong.Zhao@amd.com>
> Date: Fri Dec 13 11:31:48 2019 -0500
>
> drm/amdkfd: Improve function get_sdma_rlc_reg_offset()
>
> Change-Id: I87da4f1ad8a190327a4a71f0ff78812cb942d6e0
> Signed-off-by: Yong Zhao <Yong.Zhao@amd.com>
Instead of quoting the whole change description, the usual way to point
to a prior patch that you're fixing is with a tag
Fixes: <12 digits of sha1> ("commit title")
With that fixed, this patch is
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> index 2b26925623eb..f9011a07cb90 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> @@ -71,7 +71,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
> unsigned int engine_id,
> unsigned int queue_id)
> {
> - uint32_t sdma_engine_reg_base;
> + uint32_t sdma_engine_reg_base = 0;
> uint32_t sdma_rlc_reg_offset;
>
> switch (engine_id) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-01-11 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 0:40 [PATCH] drm/amdkfd: Fix a compiling warning Yong Zhao
2020-01-11 0:46 ` Felix Kuehling [this message]
2020-01-13 14:12 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fd13b0e-f2f7-75fc-7df6-01f1c023f6fa@amd.com \
--to=felix.kuehling@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=yong.zhao@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.