All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "hch@infradead.org" <hch@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 0/2] mm/mmap: Drop __SXXX/__PXXX macros from across platforms
Date: Thu, 16 Jun 2022 05:22:23 +0000	[thread overview]
Message-ID: <1fe37a32-f11b-fbc4-7fca-46dcc89b50c4@csgroup.eu> (raw)
In-Reply-To: <20220616040924.1022607-1-anshuman.khandual@arm.com>



Le 16/06/2022 à 06:09, Anshuman Khandual a écrit :
> __SXXX/__PXXX macros is an unnecessary abstraction layer in creating the
> generic protection_map[] array which is used for vm_get_page_prot(). This
> abstraction layer can be avoided, if the platforms just define the array
> protection_map[] for all possible vm_flags access permission combinations.
> 
> This series drops __SXXX/__PXXX macros from across platforms in the tree.
> First it makes protection_map[] array private (static) on platforms which
> enable ARCH_HAS_VM_GET_PAGE_PROT, later moves protection_map[] array into
> arch for all remaining platforms (!ARCH_HAS_VM_GET_PAGE_PROT), dropping
> the generic one. In the process __SXXX/__PXXX macros become redundant and
> thus get dropped off completely. I understand that the diff stat is large
> here, but please do suggest if there is a better way. This series applies
> on v5.19-rc1 and has been build tested for multiple platforms.

Maybe this patch could be split with one patch per architecture. All you 
have to do for that is to guard the generic protection_map declaration 
with #ifdef __S000 , then the architectures can be migrated one by one.

> 
> The CC list for this series has been reduced to just minimum, until there
> is some initial agreement.

Agreement with who if people don't know this series exists ?

I think you should keep the architecture lists in copy allthough you 
don't include individual maintainers/reviewers for now.

> 
> - Anshuman
> 
> Changes in V3:
> 
> - Fix build issues on powerpc and riscv
> 
> Changes in V2:

I guess V2 was only sent to linux-mm as well ? Too bad.

> 
> https://lore.kernel.org/all/20220613053354.553579-1-anshuman.khandual@arm.com/
> 
> - Add 'const' identifier to protection_map[] on powerpc
> - Dropped #ifndef CONFIG_ARCH_HAS_VM_GET_PAGE_PROT check from sparc 32
> - Dropped protection_map[] init from sparc 64
> - Dropped all new platform changes subscribing ARCH_HAS_VM_GET_PAGE_PROT
> - Added a second patch which moves generic protection_map[] array into
>    all remaining platforms (!ARCH_HAS_VM_GET_PAGE_PROT)
> 
> Changes in V1:
> 
> https://lore.kernel.org/linux-mm/20220603101411.488970-1-anshuman.khandual@arm.com/
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> 
> Anshuman Khandual (2):
>    mm/mmap: Restrict generic protection_map[] array visibility
>    mm/mmap: Drop generic protection_map[] array
> 
>   arch/alpha/include/asm/pgtable.h          | 17 -------
>   arch/alpha/mm/init.c                      | 21 +++++++++
>   arch/arc/include/asm/pgtable-bits-arcv2.h | 18 --------
>   arch/arc/mm/mmap.c                        | 19 ++++++++
>   arch/arm/include/asm/pgtable.h            | 17 -------
>   arch/arm/lib/uaccess_with_memcpy.c        |  2 +-
>   arch/arm/mm/mmu.c                         | 19 ++++++++
>   arch/arm64/include/asm/pgtable-prot.h     | 18 --------
>   arch/arm64/mm/mmap.c                      | 21 +++++++++
>   arch/csky/include/asm/pgtable.h           | 18 --------
>   arch/csky/mm/init.c                       | 19 ++++++++
>   arch/hexagon/include/asm/pgtable.h        | 27 ------------
>   arch/hexagon/mm/init.c                    | 41 +++++++++++++++++
>   arch/ia64/include/asm/pgtable.h           | 18 --------
>   arch/ia64/mm/init.c                       | 27 +++++++++++-
>   arch/loongarch/include/asm/pgtable-bits.h | 19 --------
>   arch/loongarch/mm/cache.c                 | 45 +++++++++++++++++++
>   arch/m68k/include/asm/mcf_pgtable.h       | 54 -----------------------
>   arch/m68k/include/asm/motorola_pgtable.h  | 22 ---------
>   arch/m68k/include/asm/sun3_pgtable.h      | 17 -------
>   arch/m68k/mm/mcfmmu.c                     | 54 +++++++++++++++++++++++
>   arch/m68k/mm/motorola.c                   | 19 ++++++++
>   arch/m68k/mm/sun3mmu.c                    | 19 ++++++++
>   arch/microblaze/include/asm/pgtable.h     | 17 -------
>   arch/microblaze/mm/init.c                 | 19 ++++++++
>   arch/mips/include/asm/pgtable.h           | 22 ---------
>   arch/mips/mm/cache.c                      |  2 +
>   arch/nios2/include/asm/pgtable.h          | 16 -------
>   arch/nios2/mm/init.c                      | 19 ++++++++
>   arch/openrisc/include/asm/pgtable.h       | 18 --------
>   arch/openrisc/mm/init.c                   | 19 ++++++++
>   arch/parisc/include/asm/pgtable.h         | 18 --------
>   arch/parisc/mm/init.c                     | 19 ++++++++
>   arch/powerpc/include/asm/pgtable.h        | 18 --------
>   arch/powerpc/mm/book3s64/pgtable.c        |  6 +++
>   arch/powerpc/mm/pgtable.c                 | 20 +++++++++
>   arch/riscv/include/asm/pgtable.h          | 20 ---------
>   arch/riscv/mm/init.c                      | 19 ++++++++
>   arch/s390/include/asm/pgtable.h           | 17 -------
>   arch/s390/mm/mmap.c                       | 19 ++++++++
>   arch/sh/include/asm/pgtable.h             | 17 -------
>   arch/sh/mm/mmap.c                         | 19 ++++++++
>   arch/sparc/include/asm/pgtable_32.h       | 19 --------
>   arch/sparc/include/asm/pgtable_64.h       | 19 --------
>   arch/sparc/mm/init_32.c                   | 19 ++++++++
>   arch/sparc/mm/init_64.c                   |  3 ++
>   arch/um/include/asm/pgtable.h             | 17 -------
>   arch/um/kernel/mem.c                      | 19 ++++++++
>   arch/x86/include/asm/pgtable_types.h      | 19 --------
>   arch/x86/mm/pgprot.c                      | 19 ++++++++
>   arch/x86/um/mem_32.c                      |  2 +-
>   arch/xtensa/include/asm/pgtable.h         | 18 --------
>   arch/xtensa/mm/init.c                     | 19 ++++++++
>   include/linux/mm.h                        |  2 +
>   mm/mmap.c                                 | 19 --------
>   55 files changed, 547 insertions(+), 522 deletions(-)
> 

  parent reply	other threads:[~2022-06-16  5:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  4:09 [PATCH V3 0/2] mm/mmap: Drop __SXXX/__PXXX macros from across platforms Anshuman Khandual
2022-06-16  4:09 ` [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility Anshuman Khandual
2022-06-16  5:35   ` Christophe Leroy
2022-06-20  5:16     ` Anshuman Khandual
2022-06-20  6:41       ` Christophe Leroy
2022-06-21  9:44         ` Anshuman Khandual
2022-06-16 12:44   ` kernel test robot
2022-06-20  4:45     ` Anshuman Khandual
2022-06-20  4:45       ` Anshuman Khandual
2022-06-20  5:55       ` Christoph Hellwig
2022-06-20  5:55         ` Christoph Hellwig
2022-06-20  6:43       ` Christophe Leroy
2022-06-20  6:43         ` Christophe Leroy
2022-06-16  4:09 ` [PATCH V3 2/2] mm/mmap: Drop generic protection_map[] array Anshuman Khandual
2022-06-16  5:27   ` Christophe Leroy
2022-06-16  6:10     ` hch
2022-06-17  3:46     ` Anshuman Khandual
2022-06-16  5:45   ` Christophe Leroy
2022-06-16  6:12     ` hch
2022-06-17  3:29       ` Anshuman Khandual
2022-06-17  5:48         ` Christophe Leroy
2022-06-17  8:00           ` hch
2022-06-20  4:14             ` Anshuman Khandual
2022-06-17  3:43     ` Anshuman Khandual
2022-06-17  5:40       ` Christophe Leroy
2022-06-16  5:22 ` Christophe Leroy [this message]
2022-06-16  6:13   ` [PATCH V3 0/2] mm/mmap: Drop __SXXX/__PXXX macros from across platforms hch
2022-06-17  3:07   ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fe37a32-f11b-fbc4-7fca-46dcc89b50c4@csgroup.eu \
    --to=christophe.leroy@csgroup.eu \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.