From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBD4C433FE for ; Sun, 10 Oct 2021 23:55:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46EDC60EE4 for ; Sun, 10 Oct 2021 23:55:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233285AbhJJX5f (ORCPT ); Sun, 10 Oct 2021 19:57:35 -0400 Received: from mx.socionext.com ([202.248.49.38]:24769 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231481AbhJJX5e (ORCPT ); Sun, 10 Oct 2021 19:57:34 -0400 Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 11 Oct 2021 08:55:34 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 331EB2058B40; Mon, 11 Oct 2021 08:55:34 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Mon, 11 Oct 2021 08:55:34 +0900 Received: from yuzu2.css.socionext.com (yuzu2 [172.31.9.57]) by kinkan2.css.socionext.com (Postfix) with ESMTP id BDCB8C1E11; Mon, 11 Oct 2021 08:55:33 +0900 (JST) Received: from [10.212.182.24] (unknown [10.212.182.24]) by yuzu2.css.socionext.com (Postfix) with ESMTP id 466E1B62B3; Mon, 11 Oct 2021 08:55:33 +0900 (JST) Subject: Re: [PATCH v2 4/5] dt-bindings: clock: uniphier: Add clock binding for SoC-glue To: Rob Herring Cc: Michael Turquette , Stephen Boyd , Masami Hiramatsu , linux-clk , devicetree@vger.kernel.org, linux-arm-kernel , linux-kernel@vger.kernel.org References: <1633518555-8195-1-git-send-email-hayashi.kunihiko@socionext.com> <1633518555-8195-5-git-send-email-hayashi.kunihiko@socionext.com> From: Kunihiko Hayashi Message-ID: <1fe99277-10e0-0149-cef5-e839bd2515bb@socionext.com> Date: Mon, 11 Oct 2021 08:55:33 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/10/09 4:20, Rob Herring wrote: > On Thu, Oct 7, 2021 at 3:50 AM Kunihiko Hayashi > wrote: >> >> Hi Rob, >> >> On 2021/10/07 4:49, Rob Herring wrote: >>> On Wed, Oct 06, 2021 at 08:09:14PM +0900, Kunihiko Hayashi wrote: >>>> Update binding document for clocks implemented in SoC-glue. >>>> >>>> Signed-off-by: Kunihiko Hayashi >>>> --- >>>> .../bindings/clock/socionext,uniphier-clock.yaml | 16 >>> ++++++++++++++++ >>>> 1 file changed, 16 insertions(+) >>>> >>>> diff --git >>> a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >>> b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >>>> index ee8d16a8019e..05a9d1f89756 100644 >>>> --- >>> a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >>>> +++ >>> b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >>>> @@ -46,6 +46,9 @@ properties: >>>> - socionext,uniphier-ld20-peri-clock >>>> - socionext,uniphier-pxs3-peri-clock >>>> - socionext,uniphier-nx1-peri-clock >>>> + - description: SoC-glue clock >>>> + enum: >>>> + - socionext,uniphier-pro4-sg-clock >>>> >>>> "#clock-cells": >>>> const: 1 >>>> @@ -95,3 +98,16 @@ examples: >>>> >>>> // other nodes ... >>>> }; >>>> + >>>> + - | >>>> + soc-glue@5f800000 { >>>> + compatible = "socionext,uniphier-sysctrl", "simple-mfd", >>> "syscon"; >>>> + reg = <0x5f800000 0x2000>; >>>> + >>>> + clock { >>>> + compatible = "socionext,uniphier-pro4-sg-clock"; >>>> + #clock-cells = <1>; >>>> + }; >>>> + >>>> + // other nodes ... >>>> + }; >>> >>> What's the value of this 2nd example? It's just a different compatible >>> string. >> Following the previous three examples in the document, it describes the >> difference between the parent nodes that place the clock. >> >> They are common to be child nodes of "syscon", and the definition of the >> parent node is not in this document. >> Should I put them together in a common example? > > I'd just drop the example. I see. I'd drop the example in next. Thank you, --- Best Regards Kunihiko Hayashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E66FC433F5 for ; Sun, 10 Oct 2021 23:58:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D454060EE4 for ; Sun, 10 Oct 2021 23:58:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D454060EE4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ilgLNw7w9WmDZ2vWL19HmGpstpQmXY9CLhEJcESaNC0=; b=VCCoc2tgR8Lo+N/oJ7zvEDcz8J CPn+wTidrMBJQBkAi/8Rrq/UiTgWbo7Dnf+9BIkh/MBclevhhpLm6gqLgCy7X2mwmRYP/aGIRqxzm jDKzHHF5JGcXbm6diRT2S+z8vRnewVq8izJONCiKRIsrdq6t52qyd1bqp0Kd+OvqSDToJE1iZB5l2 bp+hyL4LeTXkZkpraTQwWXIUPqGiOIPyAMVHg+vvWcHjsONMPznBQN97hkenAM7HIxfIY6o4nyj7V 120F5MUiK86ALZ+I/WbiE0n2uPF26RfWp2NTuiPghYC1tPke6B2K2R3Lua1RnlAflHn/1cS1pRzyX cJ0yg5Eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZifc-007UKt-22; Sun, 10 Oct 2021 23:55:56 +0000 Received: from mx.socionext.com ([202.248.49.38]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZifK-007UK8-5t for linux-arm-kernel@lists.infradead.org; Sun, 10 Oct 2021 23:55:39 +0000 Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 11 Oct 2021 08:55:34 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 331EB2058B40; Mon, 11 Oct 2021 08:55:34 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Mon, 11 Oct 2021 08:55:34 +0900 Received: from yuzu2.css.socionext.com (yuzu2 [172.31.9.57]) by kinkan2.css.socionext.com (Postfix) with ESMTP id BDCB8C1E11; Mon, 11 Oct 2021 08:55:33 +0900 (JST) Received: from [10.212.182.24] (unknown [10.212.182.24]) by yuzu2.css.socionext.com (Postfix) with ESMTP id 466E1B62B3; Mon, 11 Oct 2021 08:55:33 +0900 (JST) Subject: Re: [PATCH v2 4/5] dt-bindings: clock: uniphier: Add clock binding for SoC-glue To: Rob Herring Cc: Michael Turquette , Stephen Boyd , Masami Hiramatsu , linux-clk , devicetree@vger.kernel.org, linux-arm-kernel , linux-kernel@vger.kernel.org References: <1633518555-8195-1-git-send-email-hayashi.kunihiko@socionext.com> <1633518555-8195-5-git-send-email-hayashi.kunihiko@socionext.com> From: Kunihiko Hayashi Message-ID: <1fe99277-10e0-0149-cef5-e839bd2515bb@socionext.com> Date: Mon, 11 Oct 2021 08:55:33 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211010_165538_402158_DAD7CE48 X-CRM114-Status: GOOD ( 18.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/10/09 4:20, Rob Herring wrote: > On Thu, Oct 7, 2021 at 3:50 AM Kunihiko Hayashi > wrote: >> >> Hi Rob, >> >> On 2021/10/07 4:49, Rob Herring wrote: >>> On Wed, Oct 06, 2021 at 08:09:14PM +0900, Kunihiko Hayashi wrote: >>>> Update binding document for clocks implemented in SoC-glue. >>>> >>>> Signed-off-by: Kunihiko Hayashi >>>> --- >>>> .../bindings/clock/socionext,uniphier-clock.yaml | 16 >>> ++++++++++++++++ >>>> 1 file changed, 16 insertions(+) >>>> >>>> diff --git >>> a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >>> b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >>>> index ee8d16a8019e..05a9d1f89756 100644 >>>> --- >>> a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >>>> +++ >>> b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >>>> @@ -46,6 +46,9 @@ properties: >>>> - socionext,uniphier-ld20-peri-clock >>>> - socionext,uniphier-pxs3-peri-clock >>>> - socionext,uniphier-nx1-peri-clock >>>> + - description: SoC-glue clock >>>> + enum: >>>> + - socionext,uniphier-pro4-sg-clock >>>> >>>> "#clock-cells": >>>> const: 1 >>>> @@ -95,3 +98,16 @@ examples: >>>> >>>> // other nodes ... >>>> }; >>>> + >>>> + - | >>>> + soc-glue@5f800000 { >>>> + compatible = "socionext,uniphier-sysctrl", "simple-mfd", >>> "syscon"; >>>> + reg = <0x5f800000 0x2000>; >>>> + >>>> + clock { >>>> + compatible = "socionext,uniphier-pro4-sg-clock"; >>>> + #clock-cells = <1>; >>>> + }; >>>> + >>>> + // other nodes ... >>>> + }; >>> >>> What's the value of this 2nd example? It's just a different compatible >>> string. >> Following the previous three examples in the document, it describes the >> difference between the parent nodes that place the clock. >> >> They are common to be child nodes of "syscon", and the definition of the >> parent node is not in this document. >> Should I put them together in a common example? > > I'd just drop the example. I see. I'd drop the example in next. Thank you, --- Best Regards Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel