From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bNgRi-0003kC-V4
	for qemu-devel@nongnu.org; Thu, 14 Jul 2016 09:12:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bNgRh-0002gt-1i
	for qemu-devel@nongnu.org; Thu, 14 Jul 2016 09:12:53 -0400
References: <1468354426-837-1-git-send-email-sergey.fedorov@linaro.org>
	<1468354426-837-7-git-send-email-sergey.fedorov@linaro.org>
	<87oa604bzf.fsf@linaro.org> <57878CFA.4060604@gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <1ff282ad-39e6-76e7-e923-5db0229baf21@redhat.com>
Date: Thu, 14 Jul 2016 15:12:33 +0200
MIME-Version: 1.0
In-Reply-To: <57878CFA.4060604@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 06/11] tcg: Introduce tb_mark_invalid()
 and tb_is_invalid()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <serge.fdrv@gmail.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Sergey Fedorov <sergey.fedorov@linaro.org>
Cc: qemu-devel@nongnu.org, mttcg@greensocs.com, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com, rth@twiddle.net, patches@linaro.org, mark.burton@greensocs.com, jan.kiszka@siemens.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite <crosthwaite.peter@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Michael Walle <michael@walle.cc>, Aurelien Jarno <aurelien@aurel32.net>, Leon Alrae <leon.alrae@imgtec.com>, Anthony Green <green@moxielogic.com>, Jia Liu <proljc@gmail.com>, David Gibson <david@gibson.dropbear.id.au>, Alexander Graf <agraf@suse.de>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Max Filippov <jcmvbkbc@gmail.com>, qemu-arm@nongnu.org, qemu-ppc@nongnu.org



On 14/07/2016 15:00, Sergey Fedorov wrote:
> > > +}
> > > +
> > > +static inline bool tb_is_invalid(TranslationBlock *tb)
> > > +{
> > > +    return cpu_tb_cpu_state_is_invalidated(tb->pc, tb->cs_base, tb->flags);
> > > +}
> > Also why are we passing three pointers to parts of TranslationBlock? Why
> > not just pass tb directly and be done with it?
> 
> I'm not sure we want to include exec/exec-all.h in target-*/cpu.h

We don't, exec/exec-all.h is TCG-specific while cpu.h isn't.
Implementing tb_mark_invalid/tb_is_invalid in target-* without the
indirection would be possible, but it would require splitting that out
into a new header such as target-*/exec.h.

Paolo