From: William Zhang <william.zhang@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: "Brian Norris" <computersforpeace@gmail.com>,
"Kamal Dasu" <kamal.dasu@broadcom.com>,
linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2] mtd: rawnand: brcmnand: propagate init error -EPROBE_DEFER up
Date: Thu, 20 Jul 2023 17:15:30 -0700 [thread overview]
Message-ID: <1ff530dd-2d57-0ea2-c532-1c06afca44ba@broadcom.com> (raw)
In-Reply-To: <20230719084324.14799-1-zajec5@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1076 bytes --]
On 07/19/2023 01:43 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> MTD subsystem may return -EPROBE_DEFER if something isn't ready yet.
> It's important to pass that error up so device will get probed later.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> V2: Add of_node_put() - thanks Miquel!
> ---
> drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> index 39661e23d7d4..03764b589ec5 100644
> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> @@ -3245,6 +3245,10 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
>
> ret = brcmnand_init_cs(host, NULL);
> if (ret) {
> + if (ret == -EPROBE_DEFER) {
> + of_node_put(child);
> + goto err;
> + }
> devm_kfree(dev, host);
> continue; /* Try all chip-selects */
> }
>
Acked-by: William Zhang <william.zhang@broadcom.com>
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-07-21 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 8:43 [PATCH V2] mtd: rawnand: brcmnand: propagate init error -EPROBE_DEFER up Rafał Miłecki
2023-07-20 18:52 ` Florian Fainelli
2023-07-21 0:15 ` William Zhang [this message]
2023-07-27 15:18 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ff530dd-2d57-0ea2-c532-1c06afca44ba@broadcom.com \
--to=william.zhang@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=kamal.dasu@broadcom.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.