All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v1 0/3] ASoC: meson: Fix mixer-test issues
Date: Thu, 21 Apr 2022 15:02:54 +0200	[thread overview]
Message-ID: <1j1qxqzi7g.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20220421123803.292063-1-broonie@kernel.org>


On Thu 21 Apr 2022 at 13:38, Mark Brown <broonie@kernel.org> wrote:

> These patches fix event generation issues in the custom controls in the
> Meson drivers detected by mixer-test and by inspection once I saw the
> pattern in these drivers.

Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>

Thx !

> I'm also seeing other failures due to these
> controls having invalid values, eg:
>
> # # AIU ACODEC SRC.0 value 3 more than item count 3
>
> but without documentation I'm not sure how to interpret/fix these -
> either the value should be fixed up on startup or there should be an
> extra value there (disconnected possibly?).

Value 3 is an I2S input from a block we don't support.
If we did support it, it would be an hostless DPCM BE to BE link
I'm not sure how I would represent this in ASoC TBH :/

At the time, I thought it would be easier (for the users) to leave this
value out and not give the false impression that the path was somehow
supported.

I did not realize it was the reset value nor that it would be a problem.

I can add a element to the enum if you think it is better have it
regardless of the actual path support. What do you think ?

>
> Mark Brown (3):
>   ASoC: meson: Fix event generation for AUI ACODEC mux
>   ASoC: meson: Fix event generation for AUI CODEC mux
>   ASoC: meson: Fix event generation for G12A tohdmi mux
>
>  sound/soc/meson/aiu-acodec-ctrl.c | 2 +-
>  sound/soc/meson/aiu-codec-ctrl.c  | 2 +-
>  sound/soc/meson/g12a-tohdmitx.c   | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
>
> base-commit: 3123109284176b1532874591f7c81f3837bbdc17


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID
From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH v1 0/3] ASoC: meson: Fix mixer-test issues
Date: Thu, 21 Apr 2022 15:02:54 +0200	[thread overview]
Message-ID: <1j1qxqzi7g.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20220421123803.292063-1-broonie@kernel.org>


On Thu 21 Apr 2022 at 13:38, Mark Brown <broonie@kernel.org> wrote:

> These patches fix event generation issues in the custom controls in the
> Meson drivers detected by mixer-test and by inspection once I saw the
> pattern in these drivers.

Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>

Thx !

> I'm also seeing other failures due to these
> controls having invalid values, eg:
>
> # # AIU ACODEC SRC.0 value 3 more than item count 3
>
> but without documentation I'm not sure how to interpret/fix these -
> either the value should be fixed up on startup or there should be an
> extra value there (disconnected possibly?).

Value 3 is an I2S input from a block we don't support.
If we did support it, it would be an hostless DPCM BE to BE link
I'm not sure how I would represent this in ASoC TBH :/

At the time, I thought it would be easier (for the users) to leave this
value out and not give the false impression that the path was somehow
supported.

I did not realize it was the reset value nor that it would be a problem.

I can add a element to the enum if you think it is better have it
regardless of the actual path support. What do you think ?

>
> Mark Brown (3):
>   ASoC: meson: Fix event generation for AUI ACODEC mux
>   ASoC: meson: Fix event generation for AUI CODEC mux
>   ASoC: meson: Fix event generation for G12A tohdmi mux
>
>  sound/soc/meson/aiu-acodec-ctrl.c | 2 +-
>  sound/soc/meson/aiu-codec-ctrl.c  | 2 +-
>  sound/soc/meson/g12a-tohdmitx.c   | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
>
> base-commit: 3123109284176b1532874591f7c81f3837bbdc17


  parent reply	other threads:[~2022-04-21 13:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 12:38 Mark Brown
2022-04-21 12:38 ` Mark Brown
2022-04-21 12:38 ` [PATCH v1 1/3] ASoC: meson: Fix event generation for AUI ACODEC mux Mark Brown
2022-04-21 12:38   ` Mark Brown
2022-04-21 12:38 ` [PATCH v1 2/3] ASoC: meson: Fix event generation for AUI CODEC mux Mark Brown
2022-04-21 12:38   ` Mark Brown
2022-04-21 12:38 ` [PATCH v1 3/3] ASoC: meson: Fix event generation for G12A tohdmi mux Mark Brown
2022-04-21 12:38   ` Mark Brown
2022-04-21 13:02 ` Jerome Brunet [this message]
2022-04-21 13:02   ` [PATCH v1 0/3] ASoC: meson: Fix mixer-test issues Jerome Brunet
2022-04-21 13:39   ` Mark Brown
2022-04-21 13:39     ` Mark Brown
2022-04-21 17:24 ` Mark Brown
2022-04-21 17:24   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1j1qxqzi7g.fsf@starbuckisacylon.baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --subject='Re: [PATCH v1 0/3] ASoC: meson: Fix mixer-test issues' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.