From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C89DC433DF for ; Fri, 17 Jul 2020 08:44:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDBE32074B for ; Fri, 17 Jul 2020 08:44:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="CcrWH877" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726046AbgGQIok (ORCPT ); Fri, 17 Jul 2020 04:44:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725864AbgGQIoj (ORCPT ); Fri, 17 Jul 2020 04:44:39 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73190C061755 for ; Fri, 17 Jul 2020 01:44:39 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id a6so10152950wrm.4 for ; Fri, 17 Jul 2020 01:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=9x6fTHZjafmueEMmRdi+LdlMzC2EII5ZkFzc9Fwx204=; b=CcrWH877Ri20PNsFBMBPs4KP9jLSBxVMwMQejX+OakrhCpNGurKvg/YYuWyooyngHO PGII9nSP3QITVgwaA4IMlURWO0b7gngGMwk2tXW0Z30dsgpHUZLhxbzH/rTNZ6LaErsg 7bkbz0aMZlBSeE8sWKk1eu+xm6tMvSYt1dz3W5nHlHPy0+YrsvYM20RZqDXAcgy0hIFY IFcZv1BdkCGDXemcAcUKGgqaTS1rWgYSHbLZmWdaW+gVOH6Yvi9Ca51nI3rlF4f4cg4Q 4J6q5a2drV9N+LEkPNNOqAy8bOGoph8gzskNnKVVKah64U9qztXuUs/d7VCVkGxWUC63 2AiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=9x6fTHZjafmueEMmRdi+LdlMzC2EII5ZkFzc9Fwx204=; b=GjIwttUeIHcOTFbYFRD5w8iBY9mfA+yDrebq6VnLEd3Hmwm+ukhVUv9aP0CLj/XWu3 ebrjNv7ULA4KukMh0G9HoQykh2sO9KLvAYmZ0OdhDV51cA6ZmHAM8y6pmXp/hR1xDueK WeQTUh7T78qzaS9wmJTmF8qO+XH7yoJQr6KAndcmc+sgvxJ/GTbRvvuWo2TOFzEYCFrz Gg521owS0t09hdC2/sQ7UpYxFFc0BJ0kbQHOHy58nnhv5Kr7btrsCSoVDlVKY3XUuurp Kt15C+HK/GvQuz776M7LLUOwr3EZpbFxujcI/+ybXeTMLeC/UHYW3ukW3QONOCnV1N4+ aWFw== X-Gm-Message-State: AOAM531ZLS3lqCoyW8YKn430iA6P616zZ4RMmhTe/n1NDsS8OT1thcFe iw38ULr4XNDL+9YStxwNbYSwEQ== X-Google-Smtp-Source: ABdhPJyovxSTvHHpc7ZiBtlMV3klZ1rwvUq3jT7v0dWg3bOYRkcwggR2do8xcR8ffqqZT8dB2S5bOA== X-Received: by 2002:adf:f311:: with SMTP id i17mr9496093wro.237.1594975477992; Fri, 17 Jul 2020 01:44:37 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id k20sm12480834wmi.27.2020.07.17.01.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 01:44:35 -0700 (PDT) References: <20200717082242.130627-1-jingxiangfeng@huawei.com> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Jing Xiangfeng , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, khilman@baylibre.com, kuninori.morimoto.gx@renesas.com Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: meson: fixes the missed kfree() for axg_card_add_tdm_loopback In-reply-to: <20200717082242.130627-1-jingxiangfeng@huawei.com> Date: Fri, 17 Jul 2020 10:44:35 +0200 Message-ID: <1j7dv2sf7w.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 17 Jul 2020 at 10:22, Jing Xiangfeng wrote: > axg_card_add_tdm_loopback() misses to call kfree() in an error path. We > can use devm_kasprintf() to fix the issue, also improve maintainability. > So use it instead. > > Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style") > Signed-off-by: Jing Xiangfeng Reviewed-by: Jerome Brunet > --- > sound/soc/meson/axg-card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c > index 89f7f64747cd..47f2d93224fe 100644 > --- a/sound/soc/meson/axg-card.c > +++ b/sound/soc/meson/axg-card.c > @@ -116,7 +116,7 @@ static int axg_card_add_tdm_loopback(struct snd_soc_card *card, > > lb = &card->dai_link[*index + 1]; > > - lb->name = kasprintf(GFP_KERNEL, "%s-lb", pad->name); > + lb->name = devm_kasprintf(card->dev, GFP_KERNEL, "%s-lb", pad->name); > if (!lb->name) > return -ENOMEM; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9084C433E0 for ; Fri, 17 Jul 2020 08:45:42 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4265920691 for ; Fri, 17 Jul 2020 08:45:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="La8QCxvR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="CcrWH877" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4265920691 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CB8231669; Fri, 17 Jul 2020 10:44:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CB8231669 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594975540; bh=vSq04e1/E7kj+7kdOMfF5AM/SEwTr2XkFns/bQROang=; h=References:From:To:Subject:In-reply-to:Date:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=La8QCxvReFcXrTvNU2Fmd0GkXEWeLd0bP9VFOEzI1rjvWkx07PdjkqRMCFhMz9Ino jnbGc1bLmvjKNStuU1LTpeZfBLR4OmqgQYN99KBI2PKaep5TlcXwj5opVOP3mOHwA1 CcTC0RhBkg/8jcP0HilyRlaYgFD6rCPjYFpAy/s0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5B205F801D8; Fri, 17 Jul 2020 10:44:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4B70AF800E4; Fri, 17 Jul 2020 10:44:49 +0200 (CEST) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 29BEFF800E4 for ; Fri, 17 Jul 2020 10:44:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 29BEFF800E4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="CcrWH877" Received: by mail-wr1-x441.google.com with SMTP id k6so10160678wrn.3 for ; Fri, 17 Jul 2020 01:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=9x6fTHZjafmueEMmRdi+LdlMzC2EII5ZkFzc9Fwx204=; b=CcrWH877Ri20PNsFBMBPs4KP9jLSBxVMwMQejX+OakrhCpNGurKvg/YYuWyooyngHO PGII9nSP3QITVgwaA4IMlURWO0b7gngGMwk2tXW0Z30dsgpHUZLhxbzH/rTNZ6LaErsg 7bkbz0aMZlBSeE8sWKk1eu+xm6tMvSYt1dz3W5nHlHPy0+YrsvYM20RZqDXAcgy0hIFY IFcZv1BdkCGDXemcAcUKGgqaTS1rWgYSHbLZmWdaW+gVOH6Yvi9Ca51nI3rlF4f4cg4Q 4J6q5a2drV9N+LEkPNNOqAy8bOGoph8gzskNnKVVKah64U9qztXuUs/d7VCVkGxWUC63 2AiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=9x6fTHZjafmueEMmRdi+LdlMzC2EII5ZkFzc9Fwx204=; b=bUCjplEwL0tdNshrB/iZKAUEkI5dfBkYvTXYyW3SYGTe7dpr2GxIOXJxSPP9i669eh lI22CDjy6IKau2xMkmhWRspA8Hu6UXA+wg3feuWZXKlWdL36iEJNZhwGPmpFZo/A3GbU ikNW3YCq6VZ/KUK9JQmrBJt7QeYf+xUydf0Cz1HHnPfNHtqYGkQdscze61NloXJMXbBj NiAnyI6hzkIIDiADuy0VNFXKQ7cI5XQXx2jClybT5o3WCBWj4K5M2W1qupyrnyOWOm2K pNSw5W/c8vIn+nOBZ0geD6ROlsLO2ejuCpR1EWgmdy6P8UPe4LD3xhcWxgyGIgKI7Qlq SVJQ== X-Gm-Message-State: AOAM531+bnElT9hp7Fp3l0ICEjBTP0+dwcLGeFbzE9FjzG5zkucX0QF4 Q7YTHA+lUtNhK+U1MfBZi9otQQ== X-Google-Smtp-Source: ABdhPJyovxSTvHHpc7ZiBtlMV3klZ1rwvUq3jT7v0dWg3bOYRkcwggR2do8xcR8ffqqZT8dB2S5bOA== X-Received: by 2002:adf:f311:: with SMTP id i17mr9496093wro.237.1594975477992; Fri, 17 Jul 2020 01:44:37 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id k20sm12480834wmi.27.2020.07.17.01.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 01:44:35 -0700 (PDT) References: <20200717082242.130627-1-jingxiangfeng@huawei.com> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Jing Xiangfeng , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, khilman@baylibre.com, kuninori.morimoto.gx@renesas.com Subject: Re: [PATCH v2] ASoC: meson: fixes the missed kfree() for axg_card_add_tdm_loopback In-reply-to: <20200717082242.130627-1-jingxiangfeng@huawei.com> Date: Fri, 17 Jul 2020 10:44:35 +0200 Message-ID: <1j7dv2sf7w.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Cc: linux-amlogic@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri 17 Jul 2020 at 10:22, Jing Xiangfeng wrote: > axg_card_add_tdm_loopback() misses to call kfree() in an error path. We > can use devm_kasprintf() to fix the issue, also improve maintainability. > So use it instead. > > Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style") > Signed-off-by: Jing Xiangfeng Reviewed-by: Jerome Brunet > --- > sound/soc/meson/axg-card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c > index 89f7f64747cd..47f2d93224fe 100644 > --- a/sound/soc/meson/axg-card.c > +++ b/sound/soc/meson/axg-card.c > @@ -116,7 +116,7 @@ static int axg_card_add_tdm_loopback(struct snd_soc_card *card, > > lb = &card->dai_link[*index + 1]; > > - lb->name = kasprintf(GFP_KERNEL, "%s-lb", pad->name); > + lb->name = devm_kasprintf(card->dev, GFP_KERNEL, "%s-lb", pad->name); > if (!lb->name) > return -ENOMEM; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77139C433DF for ; Fri, 17 Jul 2020 08:46:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4158E206F4 for ; Fri, 17 Jul 2020 08:46:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SlsCDis7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="CcrWH877" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4158E206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c+OtwETskPffwaNC+HobkALp3jrND+JVUcpBQVitcyU=; b=SlsCDis7HnNhf+klgF7SE+k5w yd9ZG83jQobeyha4E3EN0+ReKqjtKRYMksgt+9jBQU+IO0kRv3Eg7mP+4XbOySkuABGjFnG2u6FmT r9+cT7K+qplsFprciLMKkpTFtVIlSAp9exazd4NhEoU+CmLdWoKTNadfn9dY/M/y8T8Fh6xnYG+cI A+wEkRzCjT9u3rRmzSNnRnXlvVhErlYIWGFr2D1PiGpUkgLWbkXwdlAQHx3jcNT4k5qOdNOLcSsTU UYKUYl3I3wG6NFUnhEbh+5cjtNsQ2f7yJdTqBYZp+kW7b/y/Wf24ZhyYlNCG8jo9r7MZj7km6lESG /jdYDiPCQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwLz2-0000bS-I6; Fri, 17 Jul 2020 08:44:44 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwLyz-0000a1-F6 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 08:44:42 +0000 Received: by mail-wr1-x442.google.com with SMTP id k6so10160676wrn.3 for ; Fri, 17 Jul 2020 01:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=9x6fTHZjafmueEMmRdi+LdlMzC2EII5ZkFzc9Fwx204=; b=CcrWH877Ri20PNsFBMBPs4KP9jLSBxVMwMQejX+OakrhCpNGurKvg/YYuWyooyngHO PGII9nSP3QITVgwaA4IMlURWO0b7gngGMwk2tXW0Z30dsgpHUZLhxbzH/rTNZ6LaErsg 7bkbz0aMZlBSeE8sWKk1eu+xm6tMvSYt1dz3W5nHlHPy0+YrsvYM20RZqDXAcgy0hIFY IFcZv1BdkCGDXemcAcUKGgqaTS1rWgYSHbLZmWdaW+gVOH6Yvi9Ca51nI3rlF4f4cg4Q 4J6q5a2drV9N+LEkPNNOqAy8bOGoph8gzskNnKVVKah64U9qztXuUs/d7VCVkGxWUC63 2AiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=9x6fTHZjafmueEMmRdi+LdlMzC2EII5ZkFzc9Fwx204=; b=D88GJOfD/JZ007cKjeQYGwvYVkA6V+197ulPwPAM/u6IYO3CXm8fucC7jaZDayER/z REHOGAUeTIJaIDP4ePee4fHV1yfR+Ucv9GkGrAjOYjwF18rmfyOmFPNSHUuVHZvIPm1d UU9RAdDENnaSE9VagfWYTyqr8navCc+sd54kZWRm74PV4wk8Qyn2CB9Kt8dnQZRYzyt+ sOpUubcSDFpWLqltx1AgfHbj3RUKGzcCunZB15FenpnCvknA5QnpImootTs97YOXsHE3 ErLltTVFc48ppKv/yh34NKakn+7pQDe76AEVpPVz7CCRf32woEsT80faUp+N7tR8QJpf E99g== X-Gm-Message-State: AOAM530j7rTnKgoWwoOYkPRBznkSx1BeDhTWhdNGq6orYbB8l5taA0tM OLETy/cX4dhvCl0xk2o+ONAG2w== X-Google-Smtp-Source: ABdhPJyovxSTvHHpc7ZiBtlMV3klZ1rwvUq3jT7v0dWg3bOYRkcwggR2do8xcR8ffqqZT8dB2S5bOA== X-Received: by 2002:adf:f311:: with SMTP id i17mr9496093wro.237.1594975477992; Fri, 17 Jul 2020 01:44:37 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id k20sm12480834wmi.27.2020.07.17.01.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 01:44:35 -0700 (PDT) References: <20200717082242.130627-1-jingxiangfeng@huawei.com> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Jing Xiangfeng , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, khilman@baylibre.com, kuninori.morimoto.gx@renesas.com Subject: Re: [PATCH v2] ASoC: meson: fixes the missed kfree() for axg_card_add_tdm_loopback In-reply-to: <20200717082242.130627-1-jingxiangfeng@huawei.com> Date: Fri, 17 Jul 2020 10:44:35 +0200 Message-ID: <1j7dv2sf7w.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_044441_614809_A18537E1 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 17 Jul 2020 at 10:22, Jing Xiangfeng wrote: > axg_card_add_tdm_loopback() misses to call kfree() in an error path. We > can use devm_kasprintf() to fix the issue, also improve maintainability. > So use it instead. > > Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style") > Signed-off-by: Jing Xiangfeng Reviewed-by: Jerome Brunet > --- > sound/soc/meson/axg-card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c > index 89f7f64747cd..47f2d93224fe 100644 > --- a/sound/soc/meson/axg-card.c > +++ b/sound/soc/meson/axg-card.c > @@ -116,7 +116,7 @@ static int axg_card_add_tdm_loopback(struct snd_soc_card *card, > > lb = &card->dai_link[*index + 1]; > > - lb->name = kasprintf(GFP_KERNEL, "%s-lb", pad->name); > + lb->name = devm_kasprintf(card->dev, GFP_KERNEL, "%s-lb", pad->name); > if (!lb->name) > return -ENOMEM; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EEA5C433E1 for ; Fri, 17 Jul 2020 08:44:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A9AC20691 for ; Fri, 17 Jul 2020 08:44:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="maKLATz4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="CcrWH877" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A9AC20691 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4Tn3vjO/zN05v1uWk/jpsA9F+QDQgcqUh3Ah3JXNbbk=; b=maKLATz4V9/Ui5yGnTigZ2v5t QRk6Nmd+YzHhNhFKgrasK5tamMfkBqpLM9h1UzPG1uiXg3WsGDgw3rnvA41iJ24WzxjysbSvUHUiT mZqRo4lPIIiGRhHvuJI1xCj8bDvhlHtf1LytOLe4u1zzN8d8WN4wByBDjd9mW6h0c3zXcgHLbpfmB lcDmpZG+U/0p2vTcwNLXN3TAQO/2iEc1GOFYao21YitRQVYtLnHqBWhtxx+3BFTHpifxLo8CxVGec z0dkk+gNTOwzpwB5acVlc6qXZ7+7P0yPecppnasJYGLdD7gDHSwNYH/qgdoiElqd8AJIwllvIci4U bLj3b4Q1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwLz1-0000bG-Le; Fri, 17 Jul 2020 08:44:43 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwLyz-0000a2-DY for linux-amlogic@lists.infradead.org; Fri, 17 Jul 2020 08:44:42 +0000 Received: by mail-wr1-x443.google.com with SMTP id f2so10119838wrp.7 for ; Fri, 17 Jul 2020 01:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=9x6fTHZjafmueEMmRdi+LdlMzC2EII5ZkFzc9Fwx204=; b=CcrWH877Ri20PNsFBMBPs4KP9jLSBxVMwMQejX+OakrhCpNGurKvg/YYuWyooyngHO PGII9nSP3QITVgwaA4IMlURWO0b7gngGMwk2tXW0Z30dsgpHUZLhxbzH/rTNZ6LaErsg 7bkbz0aMZlBSeE8sWKk1eu+xm6tMvSYt1dz3W5nHlHPy0+YrsvYM20RZqDXAcgy0hIFY IFcZv1BdkCGDXemcAcUKGgqaTS1rWgYSHbLZmWdaW+gVOH6Yvi9Ca51nI3rlF4f4cg4Q 4J6q5a2drV9N+LEkPNNOqAy8bOGoph8gzskNnKVVKah64U9qztXuUs/d7VCVkGxWUC63 2AiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=9x6fTHZjafmueEMmRdi+LdlMzC2EII5ZkFzc9Fwx204=; b=BtaKrYnUaqZSlS6nQ2nq70UD6VLm4sjGEfKaODOGKwzBdQJAGPMB50QVbCfOofxvZf diOv/9IlUTHB4KqH7OjTP74YfD6fQEMLjqhR2rwymKys6F1ygNaNh+r7RLMTvrwlMs/I Czb0qKMrQMiVrUfoGeEsxIhuBCd+eF5YY3dbKFo+jSvo8tfgSUKVh+Q5pjxa4T+0K66N +7uugVcPTDt/9hLS02pjo+9Dyd2mct20N4i/ytcTsn3oOpVJeJ1IDHcsnspNvZFyctIb /FxOkoyqMtcMIwV3ruKmDi/GBJj4O17H40ftnmD5fTyQBysbNx2cU7p7oiZPERRs/YsK g67w== X-Gm-Message-State: AOAM530rAeOk+GMNN4/uLZRc17ZUlbHqicIlrXdVh2TijvDM7bk25UrM xV1QnlkipQx5Oo/tpOiwhslZPw== X-Google-Smtp-Source: ABdhPJyovxSTvHHpc7ZiBtlMV3klZ1rwvUq3jT7v0dWg3bOYRkcwggR2do8xcR8ffqqZT8dB2S5bOA== X-Received: by 2002:adf:f311:: with SMTP id i17mr9496093wro.237.1594975477992; Fri, 17 Jul 2020 01:44:37 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id k20sm12480834wmi.27.2020.07.17.01.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 01:44:35 -0700 (PDT) References: <20200717082242.130627-1-jingxiangfeng@huawei.com> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Jing Xiangfeng , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, khilman@baylibre.com, kuninori.morimoto.gx@renesas.com Subject: Re: [PATCH v2] ASoC: meson: fixes the missed kfree() for axg_card_add_tdm_loopback In-reply-to: <20200717082242.130627-1-jingxiangfeng@huawei.com> Date: Fri, 17 Jul 2020 10:44:35 +0200 Message-ID: <1j7dv2sf7w.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_044441_611316_3ED49950 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri 17 Jul 2020 at 10:22, Jing Xiangfeng wrote: > axg_card_add_tdm_loopback() misses to call kfree() in an error path. We > can use devm_kasprintf() to fix the issue, also improve maintainability. > So use it instead. > > Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style") > Signed-off-by: Jing Xiangfeng Reviewed-by: Jerome Brunet > --- > sound/soc/meson/axg-card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c > index 89f7f64747cd..47f2d93224fe 100644 > --- a/sound/soc/meson/axg-card.c > +++ b/sound/soc/meson/axg-card.c > @@ -116,7 +116,7 @@ static int axg_card_add_tdm_loopback(struct snd_soc_card *card, > > lb = &card->dai_link[*index + 1]; > > - lb->name = kasprintf(GFP_KERNEL, "%s-lb", pad->name); > + lb->name = devm_kasprintf(card->dev, GFP_KERNEL, "%s-lb", pad->name); > if (!lb->name) > return -ENOMEM; _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic