From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06FC932C89 for ; Mon, 18 Mar 2024 10:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710758679; cv=none; b=lv2JIBVwkULKes3No4yE9Rxl2mwi0QWbSIe5atBm4AqFIum8XjKCN9rEzzefIfz9yta4/1ERuKxofM3c0mlSeqreqYcEBWWnCETQvmzEuNe91o4YSGhXPOBZ3rOGtvzKGaXyBGVEBTC0vg+Hc73BlMChkL0LmiSlO+ryMANtvNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710758679; c=relaxed/simple; bh=+SOG/JMXzSLzhcPXLSIqOGl5VMrpHzfQZrNkOx8y724=; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID: MIME-Version:Content-Type; b=tfDaB+sYvoPEFaMDGUywyWs6jIDTEP8e4x8G4HrqWyhIxTVt3vjmGwjGlsvt9ISnC2oGBFDjMoo0KH8TMd6V71FW1FHurAQv+gJpCbwOcyemMOa6xV7L6LrhRENNt9l8XQJR+PdmkwpPoNoiuVc5wjdoJrG6KZypPy9nRI9prQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=1cM11hDe; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="1cM11hDe" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-513d3746950so4964533e87.1 for ; Mon, 18 Mar 2024 03:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710758676; x=1711363476; darn=vger.kernel.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=KCGPrCwTOITqjTnhSele0x2XpulUBe47CHNWCd7XesU=; b=1cM11hDeSMTR9lFAQfTERjAzuRrCa3rqVEh8PZNzqy7eDhvjQWyz2Y2AL5sm5dsTje +7mG0i3XjWHnHUKnzcJJY3DoxefsHtBLvVXh8+ifZxU8Z7T0dywDnFYKbvrJqyDh2R19 qkquO0aTGqDWuTt2z/K/HinTLVZzcScfgDhd/mkiQDGUS9oCSfDx5v3nWjp/ZRwgW2Ut qSRCe46G/cPOUA4LtQfuzodZnBE9W22UwhqBQ37IPmmNaYbC5Fy6Z5nCrQtYndYpR4Fr GN6JDqT8wIJ2ymn2rxXh+ytzIklDaFm1PQLiB68BWuow9Whp8oKMDBD29i2C7KacOvEO pdzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710758676; x=1711363476; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KCGPrCwTOITqjTnhSele0x2XpulUBe47CHNWCd7XesU=; b=AZoNncM/SxV62jRbU59vutdXQ+cpiRZFIckEHTJVtzx+UK3xn/Kc9WmGUCgTmrUcfZ nlp4X/T6c8gASKpNDENCDbzXiBVthYK8BCDmyXD/Va5X1PHCIMoJvOvY/tGbKqVLiOqY wRlMwfOjd/Z5PhTlEYr0yOGyQHWx0gqU1MSva7+XuMv+q0vMj8VYXHg+0zj3RRe1Xue+ 2L6dlTlvhQ+4jkv/6c4y83ssLlWkDLJngrf73j6zQ+V3jsuK6aNJYk5qjSVmIjXgcrvh I5FiAi5A+8zjvUSdg8ziR+6oX3vTgEOokrmmI6mzpGlu3qB1GT4cKCg2tk/QiwIzo6gb 04RQ== X-Forwarded-Encrypted: i=1; AJvYcCVhPwu1jqrr3Il0nmIez0l0NzdkloC4d5ylaiSC9b8vyOdWC+3QvOP5K6QG2keMFrfshFF76CeqdaxKN7QNRNCQCSIrGrkPVzbncQ== X-Gm-Message-State: AOJu0Yw5AF3t0AOUSqyMSVCEx39VWKK5zZMTxDJ8GVvQ8mlZiu4JE3/F UNosOvzLKCIqEJ+0h9g1LMMrnzuAqom6VanaMr/Vzf8g6SmaQq8LtjUCnTAJyoI= X-Google-Smtp-Source: AGHT+IHrBhAsRVSFIOS45FQu5E9/DGiPnUOBufbspQxtJ2p2r6r0OzKNwEix9BKbpaZlbyfnUT+a6Q== X-Received: by 2002:ac2:494f:0:b0:513:c963:895e with SMTP id o15-20020ac2494f000000b00513c963895emr7169639lfi.42.1710758676166; Mon, 18 Mar 2024 03:44:36 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:e4d5:78c0:18b:ad85]) by smtp.gmail.com with ESMTPSA id m8-20020a05600c4f4800b00413ea26f942sm17214532wmq.14.2024.03.18.03.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 03:44:35 -0700 (PDT) References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-10-jan.dakinevich@salutedevices.com> <2a41e8b6-7e8a-4995-a1d7-c5d30e53c2d5@sirena.org.uk> <3ae535cf-9a89-4187-a761-8390d649b00b@salutedevices.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Jerome Brunet To: Jan Dakinevich Cc: Mark Brown , Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@salutedevices.com Subject: Re: [PATCH 09/25] ASoC: meson: g12a-toacodec: add support for A1 SoC family Date: Mon, 18 Mar 2024 11:42:20 +0100 In-reply-to: <3ae535cf-9a89-4187-a761-8390d649b00b@salutedevices.com> Message-ID: <1ja5mvhl9o.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Sun 17 Mar 2024 at 18:19, Jan Dakinevich wrote: > On 3/15/24 16:33, Mark Brown wrote: >> On Fri, Mar 15, 2024 at 02:21:45AM +0300, Jan Dakinevich wrote: >> >>> static const struct regmap_config g12a_toacodec_regmap_cfg = { >>> - .reg_bits = 32, >>> - .val_bits = 32, >>> - .reg_stride = 4, >>> + .reg_bits = 32, >>> + .val_bits = 32, >>> + .reg_stride = 4, >>> + .max_register = TOACODEC_CTRL0, >>> + .max_register_is_0 = true, >> >> If the maximum register is 0 how does the regmap have a stride? > > reg_stride inherited from existing code. Apparently, it was meaningless > even before my modifications (the hardware has single register > regardless of max_register declaration) and it should be dropped. But, > is it okay to remove it in the same commit? Yes it has a single register, for now. Still the stride is 4. And assuming the mmio region passed from DT is correct, I'm not sure the hunk is useful at all. -- Jerome From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 045FFC54E5D for ; Mon, 18 Mar 2024 10:44:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1CdSS7bZiFIVpqL3Ktnza2UGpFLghf2hYCD5wByZljM=; b=kdcdiHRMKMHSLF f+l6CkeULUHkfE6AmBZiY/Oq3MBzkwp5Oe9bn0489q0ptpdsuIivhJtoLO/zMSUefDCQ+bNOSjaNc Gt71RV4ZpcN/gCVCOTLZjmGCsQAy57kxOMp6WGOnRAJYytZ1xG8PIFuV/DP3i1rIFSRZStsXNTzhU hLcOIfIu6yFgXTsQ2Fdynb1TPDLn27fdOFwsSaJqjonyJ8mAfztdObK/1oAz0B5NGopi24glWjbBP IMIsvhuyc5us2J3bj1Vvao5M9n5rDTObiiRckf1YOOWjslO2YuiG8aWax+6oFUf4uwGrWPaoYtRiM DxHBmYx1ujq1bonxk2DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmATy-00000008CVP-0G72; Mon, 18 Mar 2024 10:44:42 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmATu-00000008CTb-0rsr for linux-amlogic@lists.infradead.org; Mon, 18 Mar 2024 10:44:39 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-513d717269fso4090987e87.0 for ; Mon, 18 Mar 2024 03:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710758676; x=1711363476; darn=lists.infradead.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=KCGPrCwTOITqjTnhSele0x2XpulUBe47CHNWCd7XesU=; b=Uu5vfr1P9IvE08CbuxWcpTCzVx5yb6ICXJh1EQI09BSFOJvrw5QFYbNbNdJDomHqDq 54w33YxELWz8VZKy6fJU8wTPdtPnztsRKixDNlW++6AQfD7mlQYnwcWclPHyaljACDSU i1WXJXM6k46h0DCVq9Yh2l/9c03HIlATOXO9m6XrVKDrBThY6FZmz45Rjv7AglRdjIk3 I2pPfv2WTpJKNOLHVBsS6RCVKA+SEJXLZ9qPGlStDzwIwIeLvSwPon9SxxAtN/a1xgZm 55wjntqnhhZ8pjZmAK91wAH0BwwROISUnR3Xi4j52wF5MFqcCYmTxqPfQvth9huRcj7x wxKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710758676; x=1711363476; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KCGPrCwTOITqjTnhSele0x2XpulUBe47CHNWCd7XesU=; b=GhlVX+OeKEOW+i4O3k19hEGqDVHEj0hquKsCKH9eC5plTIDZwS9zULNxCjbKch/RHj /ef9hHtzf0J8ppLEbNVYfBWsfp/vFizTtZ/pIjg6bKR33QoYLSF0P4UMU2+MJX1jYHlG m2COMPFXLoizhQ/4Sm2ZB9doQuWR+xBRI1wKWvdLAmfwkdq1zwGTxuBF+a9LFPvLhpkH rVhmX4wCinvBqstytCY9WOf/vgB8i/RI5CHdtuZbRPKs2P5ErHXSaiCXs4HTo0Qcg72I iAgAGHdWVf1y2g1LSooy6naXKO3I4OVCRiUx2yqv8Os5u1FeQAeivTg0seRR8CBz2AJI dcbw== X-Forwarded-Encrypted: i=1; AJvYcCUyTw6KNmdoR3OG4P955iQhc6PsrDJUrsbvYbFH7hDnpWm52+SppFNoiCstWhzovgfNUHuaoEMB5/0e/fsQmtPlSiH9UyMr72XxRHaJzFp3vo8= X-Gm-Message-State: AOJu0YxxN/kBxgTIS6TpGR/lRk7lf5cJzcnlv325YGdUI4N+th0Axhhv HzMyfwon3wWy62LZEmKCSjKDMgqDjkBKNCmMyzZqK6LIfrluvjIqN+JwDz7ifr4= X-Google-Smtp-Source: AGHT+IHrBhAsRVSFIOS45FQu5E9/DGiPnUOBufbspQxtJ2p2r6r0OzKNwEix9BKbpaZlbyfnUT+a6Q== X-Received: by 2002:ac2:494f:0:b0:513:c963:895e with SMTP id o15-20020ac2494f000000b00513c963895emr7169639lfi.42.1710758676166; Mon, 18 Mar 2024 03:44:36 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:e4d5:78c0:18b:ad85]) by smtp.gmail.com with ESMTPSA id m8-20020a05600c4f4800b00413ea26f942sm17214532wmq.14.2024.03.18.03.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 03:44:35 -0700 (PDT) References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-10-jan.dakinevich@salutedevices.com> <2a41e8b6-7e8a-4995-a1d7-c5d30e53c2d5@sirena.org.uk> <3ae535cf-9a89-4187-a761-8390d649b00b@salutedevices.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Jerome Brunet To: Jan Dakinevich Cc: Mark Brown , Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@salutedevices.com Subject: Re: [PATCH 09/25] ASoC: meson: g12a-toacodec: add support for A1 SoC family Date: Mon, 18 Mar 2024 11:42:20 +0100 In-reply-to: <3ae535cf-9a89-4187-a761-8390d649b00b@salutedevices.com> Message-ID: <1ja5mvhl9o.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_034438_300232_EFBFE906 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sun 17 Mar 2024 at 18:19, Jan Dakinevich wrote: > On 3/15/24 16:33, Mark Brown wrote: >> On Fri, Mar 15, 2024 at 02:21:45AM +0300, Jan Dakinevich wrote: >> >>> static const struct regmap_config g12a_toacodec_regmap_cfg = { >>> - .reg_bits = 32, >>> - .val_bits = 32, >>> - .reg_stride = 4, >>> + .reg_bits = 32, >>> + .val_bits = 32, >>> + .reg_stride = 4, >>> + .max_register = TOACODEC_CTRL0, >>> + .max_register_is_0 = true, >> >> If the maximum register is 0 how does the regmap have a stride? > > reg_stride inherited from existing code. Apparently, it was meaningless > even before my modifications (the hardware has single register > regardless of max_register declaration) and it should be dropped. But, > is it okay to remove it in the same commit? Yes it has a single register, for now. Still the stride is 4. And assuming the mmio region passed from DT is correct, I'm not sure the hunk is useful at all. -- Jerome _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 349FEC54E5D for ; Mon, 18 Mar 2024 10:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LmPbr85DBQ0ZBX9R+ZVDagxlGbK1tL7n7pQijN+QIh4=; b=iR0MDeHke+38/P 2xnONHiqoyF/8Fc6yfETwXVmeUWai6OOT4sUqcvLSvu4Nw9CvXWBVj4YzV9Lf9EreM3wF/oKonybE xvlZjkcXHS2WV3bKKVx0If6XckUfznVScPzwy23Wg5e2Sf5hX0TqnPhm1MTbQ+kDvYjGCRmufGxFt uzAbqz4EX/WY3iTP3m/PLz5n/jU8sVFi79/clbum+8tsCVL21kppZBfgOM4n1swuezELtyLaboD06 Y61iTpGjgJOdC5rayRFaXHZyVmDh8LjnfxN6UwmGy7xRW4wevgOhIXaBfFf2I3fDK255yQlGugE8f f/S2DLOlnFXLZipThinw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmATx-00000008CUs-12je; Mon, 18 Mar 2024 10:44:41 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmATu-00000008CTa-0rMG for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2024 10:44:39 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-512b3b04995so3695820e87.3 for ; Mon, 18 Mar 2024 03:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710758676; x=1711363476; darn=lists.infradead.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=KCGPrCwTOITqjTnhSele0x2XpulUBe47CHNWCd7XesU=; b=Uu5vfr1P9IvE08CbuxWcpTCzVx5yb6ICXJh1EQI09BSFOJvrw5QFYbNbNdJDomHqDq 54w33YxELWz8VZKy6fJU8wTPdtPnztsRKixDNlW++6AQfD7mlQYnwcWclPHyaljACDSU i1WXJXM6k46h0DCVq9Yh2l/9c03HIlATOXO9m6XrVKDrBThY6FZmz45Rjv7AglRdjIk3 I2pPfv2WTpJKNOLHVBsS6RCVKA+SEJXLZ9qPGlStDzwIwIeLvSwPon9SxxAtN/a1xgZm 55wjntqnhhZ8pjZmAK91wAH0BwwROISUnR3Xi4j52wF5MFqcCYmTxqPfQvth9huRcj7x wxKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710758676; x=1711363476; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KCGPrCwTOITqjTnhSele0x2XpulUBe47CHNWCd7XesU=; b=oL62ybC09ltxzBgZidPpV7HkW53Cbj5WwST/L05TfB4OgnzinASm+F9HMjrja/AxJv aUGgdNnMomxWOWVnaEsA0twUjOkY8069PAaqGy49yqR1TOOD8w6nHhtBQzlwrmD9v55L h5ddqGojFdQqIxg9QWMPV6f01kilqItCdZrSJn6qhEVzjRCmoR1em8FsU1gJgMUE1wL3 hygbG/rrnvQTEwioHguBi/tAsVKv4TVH9wNdZCWofw/0p7PrrTvJJFAWUL/gX6yyCDkr 52uSJzN5lTotuaOSf2WhgsdElpi8wai/gUwS6sFJzImtw8at9sMpUVoZ9hKEiVDDwi9j jXVA== X-Forwarded-Encrypted: i=1; AJvYcCXtbKNCV9PVhyuLsZPEuX6hZYWoKqAqLNNSqiVA/wL/kTRc0/Yt2YtRMY87s2DyNTB7IqylKqC+fW2OdePJXjIFJdv3UBj0PitQFniVifcKDcrwMP4= X-Gm-Message-State: AOJu0YwrMn74ZkrVI0//pZ3aIeZRkoFwtaSDOh/A3Qk4q5ilkfjB2/TQ jRHPf/FCMbQe5ho7/Z02cf8KyUz7UCScmanJZDLuNXExsRXqBo9zluRBYyYdDhM= X-Google-Smtp-Source: AGHT+IHrBhAsRVSFIOS45FQu5E9/DGiPnUOBufbspQxtJ2p2r6r0OzKNwEix9BKbpaZlbyfnUT+a6Q== X-Received: by 2002:ac2:494f:0:b0:513:c963:895e with SMTP id o15-20020ac2494f000000b00513c963895emr7169639lfi.42.1710758676166; Mon, 18 Mar 2024 03:44:36 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:e4d5:78c0:18b:ad85]) by smtp.gmail.com with ESMTPSA id m8-20020a05600c4f4800b00413ea26f942sm17214532wmq.14.2024.03.18.03.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 03:44:35 -0700 (PDT) References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-10-jan.dakinevich@salutedevices.com> <2a41e8b6-7e8a-4995-a1d7-c5d30e53c2d5@sirena.org.uk> <3ae535cf-9a89-4187-a761-8390d649b00b@salutedevices.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Jerome Brunet To: Jan Dakinevich Cc: Mark Brown , Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@salutedevices.com Subject: Re: [PATCH 09/25] ASoC: meson: g12a-toacodec: add support for A1 SoC family Date: Mon, 18 Mar 2024 11:42:20 +0100 In-reply-to: <3ae535cf-9a89-4187-a761-8390d649b00b@salutedevices.com> Message-ID: <1ja5mvhl9o.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_034438_277721_A06B4C62 X-CRM114-Status: GOOD ( 14.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun 17 Mar 2024 at 18:19, Jan Dakinevich wrote: > On 3/15/24 16:33, Mark Brown wrote: >> On Fri, Mar 15, 2024 at 02:21:45AM +0300, Jan Dakinevich wrote: >> >>> static const struct regmap_config g12a_toacodec_regmap_cfg = { >>> - .reg_bits = 32, >>> - .val_bits = 32, >>> - .reg_stride = 4, >>> + .reg_bits = 32, >>> + .val_bits = 32, >>> + .reg_stride = 4, >>> + .max_register = TOACODEC_CTRL0, >>> + .max_register_is_0 = true, >> >> If the maximum register is 0 how does the regmap have a stride? > > reg_stride inherited from existing code. Apparently, it was meaningless > even before my modifications (the hardware has single register > regardless of max_register declaration) and it should be dropped. But, > is it okay to remove it in the same commit? Yes it has a single register, for now. Still the stride is 4. And assuming the mmio region passed from DT is correct, I'm not sure the hunk is useful at all. -- Jerome _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel