From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECB35C2D0DA for ; Thu, 26 Dec 2019 09:25:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4382206CB for ; Thu, 26 Dec 2019 09:25:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="ZEXyS1Y8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbfLZJZk (ORCPT ); Thu, 26 Dec 2019 04:25:40 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36452 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbfLZJZk (ORCPT ); Thu, 26 Dec 2019 04:25:40 -0500 Received: by mail-wm1-f66.google.com with SMTP id p17so5683547wma.1 for ; Thu, 26 Dec 2019 01:25:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=peWpqXP+RCVG8au9sO9TuXZn9CWcw1T30FsYw+3LN6s=; b=ZEXyS1Y8ESURMqzSuFHNPIrsVEGjNsoIg+cpNWtfZBy4FxIDLl3CqHc2eDXN6i7PpG lRCN/a48sFrZR5kEaEkIDifXtlv8K+mGZ2RTRb3G3mVSpgYUkw3mJs+MC1+wi18+QT/A c/HgRtkgkrAkXnQ4gvdPS5diEYh5XQtxsf8PRmJ8UruJVVtkX2AzT1MnFv1KaRqzzAc4 bP7u+6W7N2Vh2Om+Fe5O/wcaj1bCdgCTAiCzrutywVRFFNUfyspUmW3G0y3jR+XszNid lU8QCkXyD9+OXrz6v9qkhee6Hl4xw0MGtZf7XL57kSXsNIy8ng748mNNLtZY+zNYhDMM 4i3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=peWpqXP+RCVG8au9sO9TuXZn9CWcw1T30FsYw+3LN6s=; b=pv2uyZP9sP1vceZiSBPO5d44BGj4o7pKgcaXBaq4NsPvDuvNXOF00ptt5GIqtGum5i Xbe5wrDq73uypUDCRB3zkNMmqRnNsdWciGspPXiWBvH01tfDROuXZLnjO3C79yVlVp8K EvjPyh5sPc8dmmtvKjI4+LqmQ2E4iwP5LcZXBq3qq9ojNEkyHMZyuDJVjubpRokpdS6i y3gZ1Cjim5GTvVDRYF/VYpzDgBN1n/OUsSsCBYe/h2uDznEK+2OwlAcTX27SVE6+1MCG FEWF+lSwkZCrAtP7eJQqPHPKpsZSJPXaTyPDMUYKPXZoTtN+9e5W+kvsAdctxh37xlUx 4xHw== X-Gm-Message-State: APjAAAWeINIjq50WHYA7KzdfNKAa6XPct6kATJ/EsJwnJCiY3HsAbSp1 2GNOz8NaJvuilkXoi3XVySN9DA== X-Google-Smtp-Source: APXvYqzeKUMLohPe7ZL5iXLvSW84mbmDd/bfOop/hvlmApB8+hKGKPint93OBSG2z4eTj6up8MfMvA== X-Received: by 2002:a1c:49c2:: with SMTP id w185mr12633724wma.138.1577352337049; Thu, 26 Dec 2019 01:25:37 -0800 (PST) Received: from localhost ([2a01:e0a:1a5:7ee0:1e09:f4bb:719a:3028]) by smtp.gmail.com with ESMTPSA id n3sm29822422wrs.8.2019.12.26.01.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2019 01:25:36 -0800 (PST) References: <20191223214529.20377-1-repk@triplefau.lt> <20191223214529.20377-2-repk@triplefau.lt> <20191224163049.GD7304@voidbox> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Remi Pommarel , Kishon Vijay Abraham I Cc: Yue Wang , Lorenzo Pieralisi , Andrew Murray , Kevin Hilman , Martin Blumenstingl , Neil Armstrong , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH v2 1/3] phy: amlogic: Add Amlogic AXG MIPI/PCIE PHY Driver In-reply-to: <20191224163049.GD7304@voidbox> Date: Thu, 26 Dec 2019 10:25:35 +0100 Message-ID: <1jfth7phf4.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 24 Dec 2019 at 17:30, Remi Pommarel wrote: > On Tue, Dec 24, 2019 at 03:40:20PM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On 24/12/19 3:15 AM, Remi Pommarel wrote: >> > This adds support for the MIPI PHY also needed for PCIE found in the >> > Amlogic AXG SoC Family. >> > >> > MIPI or PCIE selection is done by the #phy-cells, making the mode >> > static and exclusive. >> > >> > For now only PCIE fonctionality is supported. >> > >> > This PHY will be used to replace the mipi_enable clock gating logic >> > which was mistakenly added in the clock subsystem. This also activate >> > a non documented band gap bit in those registers that allows reliable >> > PCIE clock signal generation on AXG platforms. >> > >> > Signed-off-by: Remi Pommarel >> > --- >> > drivers/phy/amlogic/Kconfig | 11 ++ >> > drivers/phy/amlogic/Makefile | 1 + >> > drivers/phy/amlogic/phy-meson-axg-mipi-pcie.c | 176 ++++++++++++++++++ >> > 3 files changed, 188 insertions(+) >> > create mode 100644 drivers/phy/amlogic/phy-meson-axg-mipi-pcie.c >> > >> > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig >> > index af774ac2b934..1eeb75d018e3 100644 >> > --- a/drivers/phy/amlogic/Kconfig >> > +++ b/drivers/phy/amlogic/Kconfig >> > @@ -59,3 +59,14 @@ config PHY_MESON_G12A_USB3_PCIE >> > Enable this to support the Meson USB3 + PCIE Combo PHY found >> > in Meson G12A SoCs. >> > If unsure, say N. >> > + >> > +config PHY_MESON_AXG_MIPI_PCIE >> > + tristate "Meson AXG MIPI + PCIE PHY driver" >> > + default ARCH_MESON >> > + depends on OF && (ARCH_MESON || COMPILE_TEST) >> > + select GENERIC_PHY >> > + select MFD_SYSCON >> > + help >> > + Enable this to support the Meson MIPI + PCIE PHY found >> > + in Meson AXG SoCs. >> > + If unsure, say N. >> > diff --git a/drivers/phy/amlogic/Makefile b/drivers/phy/amlogic/Makefile >> > index 11d1c42ac2be..2167330a0ae8 100644 >> > --- a/drivers/phy/amlogic/Makefile >> > +++ b/drivers/phy/amlogic/Makefile >> > @@ -4,3 +4,4 @@ obj-$(CONFIG_PHY_MESON_GXL_USB2) += phy-meson-gxl-usb2.o >> > obj-$(CONFIG_PHY_MESON_G12A_USB2) += phy-meson-g12a-usb2.o >> > obj-$(CONFIG_PHY_MESON_GXL_USB3) += phy-meson-gxl-usb3.o >> > obj-$(CONFIG_PHY_MESON_G12A_USB3_PCIE) += phy-meson-g12a-usb3-pcie.o >> > +obj-$(CONFIG_PHY_MESON_AXG_MIPI_PCIE) += phy-meson-axg-mipi-pcie.o >> > diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie.c b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie.c >> > new file mode 100644 >> > index 000000000000..006aa8cdfc47 >> > --- /dev/null >> > +++ b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie.c >> > @@ -0,0 +1,176 @@ >> > +// SPDX-License-Identifier: GPL-2.0 >> > +/* >> > + * Amlogic AXG MIPI + PCIE PHY driver >> > + * >> > + * Copyright (C) 2019 Remi Pommarel >> > + */ >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > + >> > +#define HHI_MIPI_CNTL0 0x00 >> > +#define HHI_MIPI_CNTL0_COMMON_BLOCK GENMASK(31, 28) >> > +#define HHI_MIPI_CNTL0_ENABLE BIT(29) >> > +#define HHI_MIPI_CNTL0_BANDGAP BIT(26) >> > +#define HHI_MIPI_CNTL0_DECODE_TO_RTERM GENMASK(15, 12) >> > +#define HHI_MIPI_CNTL0_OUTPUT_EN BIT(3) >> > + >> > +#define HHI_MIPI_CNTL1 0x01 >> > +#define HHI_MIPI_CNTL1_CH0_CML_PDR_EN BIT(12) >> > +#define HHI_MIPI_CNTL1_LP_ABILITY GENMASK(5, 4) >> > +#define HHI_MIPI_CNTL1_LP_RESISTER BIT(3) >> > +#define HHI_MIPI_CNTL1_INPUT_SETTING BIT(2) >> > +#define HHI_MIPI_CNTL1_INPUT_SEL BIT(1) >> > +#define HHI_MIPI_CNTL1_PRBS7_EN BIT(0) >> > + >> > +#define HHI_MIPI_CNTL2 0x02 >> > +#define HHI_MIPI_CNTL2_CH_PU GENMASK(31, 25) >> > +#define HHI_MIPI_CNTL2_CH_CTL GENMASK(24, 19) >> > +#define HHI_MIPI_CNTL2_CH0_DIGDR_EN BIT(18) >> > +#define HHI_MIPI_CNTL2_CH_DIGDR_EN BIT(17) >> > +#define HHI_MIPI_CNTL2_LPULPS_EN BIT(16) >> > +#define HHI_MIPI_CNTL2_CH_EN(n) BIT(15 - (n)) >> > +#define HHI_MIPI_CNTL2_CH0_LP_CTL GENMASK(10, 1) >> > + >> > +struct phy_axg_mipi_pcie_priv { >> > + struct phy *phy; >> > + unsigned int mode; >> > + struct regmap *regmap; >> > +}; >> > + >> > +static const struct regmap_config phy_axg_mipi_pcie_regmap_conf = { >> > + .reg_bits = 8, >> > + .val_bits = 32, >> > + .reg_stride = 4, >> > + .max_register = HHI_MIPI_CNTL2, >> > +}; >> > + >> > +static int phy_axg_mipi_pcie_power_on(struct phy *phy) >> > +{ >> > + struct phy_axg_mipi_pcie_priv *priv = phy_get_drvdata(phy); >> > + >> > + /* MIPI not supported yet */ >> > + if (priv->mode != PHY_TYPE_PCIE) >> > + return 0; >> > + >> > + regmap_update_bits(priv->regmap, HHI_MIPI_CNTL0, >> > + HHI_MIPI_CNTL0_BANDGAP, HHI_MIPI_CNTL0_BANDGAP); >> > + >> > + regmap_update_bits(priv->regmap, HHI_MIPI_CNTL0, >> > + HHI_MIPI_CNTL0_ENABLE, HHI_MIPI_CNTL0_ENABLE); >> > + return 0; >> > +} >> > + >> > +static int phy_axg_mipi_pcie_power_off(struct phy *phy) >> > +{ >> > + struct phy_axg_mipi_pcie_priv *priv = phy_get_drvdata(phy); >> > + >> > + /* MIPI not supported yet */ >> > + if (priv->mode != PHY_TYPE_PCIE) >> > + return 0; >> > + >> > + regmap_update_bits(priv->regmap, HHI_MIPI_CNTL0, >> > + HHI_MIPI_CNTL0_BANDGAP, 0); >> > + regmap_update_bits(priv->regmap, HHI_MIPI_CNTL0, >> > + HHI_MIPI_CNTL0_ENABLE, 0); >> > + return 0; >> > +} >> > + >> > +static int phy_axg_mipi_pcie_init(struct phy *phy) >> > +{ >> > + return 0; >> > +} >> > + >> > +static int phy_axg_mipi_pcie_exit(struct phy *phy) >> > +{ >> > + return 0; >> > +} >> > + >> > +static const struct phy_ops phy_axg_mipi_pcie_ops = { >> > + .init = phy_axg_mipi_pcie_init, >> > + .exit = phy_axg_mipi_pcie_exit, >> > + .power_on = phy_axg_mipi_pcie_power_on, >> > + .power_off = phy_axg_mipi_pcie_power_off, >> > + .owner = THIS_MODULE, >> > +}; >> > + >> > +static struct phy *phy_axg_mipi_pcie_xlate(struct device *dev, >> > + struct of_phandle_args *args) >> > +{ >> > + struct phy_axg_mipi_pcie_priv *priv = dev_get_drvdata(dev); >> > + unsigned int mode; >> > + >> > + if (args->args_count != 1) { >> > + dev_err(dev, "invalid number of arguments\n"); >> > + return ERR_PTR(-EINVAL); >> > + } >> > + >> > + mode = args->args[0]; >> > + >> > + /* MIPI mode is not supported yet */ >> > + if (mode != PHY_TYPE_PCIE) { >> > + dev_err(dev, "invalid phy mode select argument\n"); >> > + return ERR_PTR(-EINVAL); >> > + } >> > + >> > + priv->mode = mode; >> > + return priv->phy; >> > +} >> > + >> > +static int phy_axg_mipi_pcie_probe(struct platform_device *pdev) >> > +{ >> > + struct phy_provider *pphy; >> > + struct device *dev = &pdev->dev; >> > + struct phy_axg_mipi_pcie_priv *priv; >> > + struct device_node *np = dev->of_node; >> > + int ret; >> > + >> > + priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); >> > + if (!priv) >> > + return -ENOMEM; >> > + >> > + /* Get the hhi system controller node */ >> > + priv->regmap = syscon_node_to_regmap(of_get_parent(dev->of_node)); >> > + if (IS_ERR(priv->regmap)) { >> > + dev_err(dev, "failed to get HHI regmap\n"); >> > + return PTR_ERR(priv->regmap); >> > + } >> > + >> > + priv->phy = devm_phy_create(dev, np, &phy_axg_mipi_pcie_ops); >> > + if (IS_ERR(priv->phy)) { >> > + ret = PTR_ERR(priv->phy); >> > + if (ret != -EPROBE_DEFER) >> > + dev_err(dev, "failed to create PHY\n"); >> > + return ret; >> > + } >> > + >> > + phy_set_drvdata(priv->phy, priv); >> > + dev_set_drvdata(dev, priv); >> > + pphy = devm_of_phy_provider_register(dev, phy_axg_mipi_pcie_xlate); >> > + >> > + return PTR_ERR_OR_ZERO(pphy); >> > +} >> > + >> > +static const struct of_device_id phy_axg_mipi_pcie_of_match[] = { >> > + { >> > + .compatible = "amlogic,axg-mipi-pcie-phy", >> >> Is there a dt-binding documentation for this? > > There is binding documentation updates for this whole serie but I thought > they were supposed to be sent in separate serie, which is not the case > apparently. Different patches, but same series is recommended ;) > > Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA15C2D0DA for ; Thu, 26 Dec 2019 09:25:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E15C206CB for ; Thu, 26 Dec 2019 09:25:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IYMxs5lz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="ZEXyS1Y8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E15C206CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=7nQQEzLHU1bkJ2g6QzhfUxgODogW217r4OQzO+Jl+RA=; b=IYMxs5lzDgDPZFYClf+xjaYHFo w1FoS6GR3bXADPx+F3Jusy42/e2uthjkbJab0yHf0gJupiQUgUTxUTu+3aAvIy0nv6xM+G0+KoUNJ UAcIhd/s34bwEwHC9hmBCQZOLBjPL3cp2RH8WySge/wTM6ri1Szy2F4+t2pJQa19Ez1jeOmmpZaj8 GvMQc/utMMkMiD04+Gf7cUIn0VMqJ12gW/p3l711XHZkKXx1kEPdoE20Ewfuazd9PTLs85/EV2O5L y+7n6N8/nw2t13RsC6gQh49VIP5DCtsxAquIJnI3FO81MdzF80JL8UVHir56LqAigSJlMAnTBL/VY JSdkzLgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ikPOo-0003XB-IZ; Thu, 26 Dec 2019 09:25:42 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ikPOl-0003Wc-5R for linux-amlogic@lists.infradead.org; Thu, 26 Dec 2019 09:25:41 +0000 Received: by mail-wm1-x343.google.com with SMTP id c127so4764200wme.1 for ; Thu, 26 Dec 2019 01:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=peWpqXP+RCVG8au9sO9TuXZn9CWcw1T30FsYw+3LN6s=; b=ZEXyS1Y8ESURMqzSuFHNPIrsVEGjNsoIg+cpNWtfZBy4FxIDLl3CqHc2eDXN6i7PpG lRCN/a48sFrZR5kEaEkIDifXtlv8K+mGZ2RTRb3G3mVSpgYUkw3mJs+MC1+wi18+QT/A c/HgRtkgkrAkXnQ4gvdPS5diEYh5XQtxsf8PRmJ8UruJVVtkX2AzT1MnFv1KaRqzzAc4 bP7u+6W7N2Vh2Om+Fe5O/wcaj1bCdgCTAiCzrutywVRFFNUfyspUmW3G0y3jR+XszNid lU8QCkXyD9+OXrz6v9qkhee6Hl4xw0MGtZf7XL57kSXsNIy8ng748mNNLtZY+zNYhDMM 4i3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=peWpqXP+RCVG8au9sO9TuXZn9CWcw1T30FsYw+3LN6s=; b=RDMZBJsy6pvVCJGjmCZp1us0wiOHaqAMN4drThRqzxN0qLYAqOFblU+FTqTH709jdr D3QxOWrS+JzpZy4f29vreM5eVCh6g4gVd4bzzZI70Ak/jhiLnJzdGxnfOgZaga7HIhHz WGtlOCZ4ziY5tFG7w9dms7hgeeSDy14MTZtXWVqYyLDOPhF4ruy1m5SI5YgovGnbcpFN fFCEk81g7oghykJvbVkbhYJeuCFUIsbJvYexw80NlWztYjspr9036zptgdbzC7DgQwVk 7XcYTCUihTuWKvfboFYnSHK4Q76X1n4cuQTjohv2xQjZvkbHt/PDUEYBy4B5dOaS28Iu siYw== X-Gm-Message-State: APjAAAXDDkghkvvQC7wlwiCTw9poxuIPOOnNLKyZqzcAHIjyuhr0ZB5k EgltN/pFNDQFRYPFrO2Ef3PaIA== X-Google-Smtp-Source: APXvYqzeKUMLohPe7ZL5iXLvSW84mbmDd/bfOop/hvlmApB8+hKGKPint93OBSG2z4eTj6up8MfMvA== X-Received: by 2002:a1c:49c2:: with SMTP id w185mr12633724wma.138.1577352337049; Thu, 26 Dec 2019 01:25:37 -0800 (PST) Received: from localhost ([2a01:e0a:1a5:7ee0:1e09:f4bb:719a:3028]) by smtp.gmail.com with ESMTPSA id n3sm29822422wrs.8.2019.12.26.01.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2019 01:25:36 -0800 (PST) References: <20191223214529.20377-1-repk@triplefau.lt> <20191223214529.20377-2-repk@triplefau.lt> <20191224163049.GD7304@voidbox> User-agent: mu4e 1.3.3; emacs 26.3 From: Jerome Brunet To: Remi Pommarel , Kishon Vijay Abraham I Subject: Re: [PATCH v2 1/3] phy: amlogic: Add Amlogic AXG MIPI/PCIE PHY Driver In-reply-to: <20191224163049.GD7304@voidbox> Date: Thu, 26 Dec 2019 10:25:35 +0100 Message-ID: <1jfth7phf4.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191226_012539_210224_B371AC12 X-CRM114-Status: GOOD ( 21.66 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , linux-kernel@vger.kernel.org, Yue Wang , linux-pci@vger.kernel.org, Andrew Murray , linux-amlogic@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue 24 Dec 2019 at 17:30, Remi Pommarel wrote: > On Tue, Dec 24, 2019 at 03:40:20PM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On 24/12/19 3:15 AM, Remi Pommarel wrote: >> > This adds support for the MIPI PHY also needed for PCIE found in the >> > Amlogic AXG SoC Family. >> > >> > MIPI or PCIE selection is done by the #phy-cells, making the mode >> > static and exclusive. >> > >> > For now only PCIE fonctionality is supported. >> > >> > This PHY will be used to replace the mipi_enable clock gating logic >> > which was mistakenly added in the clock subsystem. This also activate >> > a non documented band gap bit in those registers that allows reliable >> > PCIE clock signal generation on AXG platforms. >> > >> > Signed-off-by: Remi Pommarel >> > --- >> > drivers/phy/amlogic/Kconfig | 11 ++ >> > drivers/phy/amlogic/Makefile | 1 + >> > drivers/phy/amlogic/phy-meson-axg-mipi-pcie.c | 176 ++++++++++++++++++ >> > 3 files changed, 188 insertions(+) >> > create mode 100644 drivers/phy/amlogic/phy-meson-axg-mipi-pcie.c >> > >> > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig >> > index af774ac2b934..1eeb75d018e3 100644 >> > --- a/drivers/phy/amlogic/Kconfig >> > +++ b/drivers/phy/amlogic/Kconfig >> > @@ -59,3 +59,14 @@ config PHY_MESON_G12A_USB3_PCIE >> > Enable this to support the Meson USB3 + PCIE Combo PHY found >> > in Meson G12A SoCs. >> > If unsure, say N. >> > + >> > +config PHY_MESON_AXG_MIPI_PCIE >> > + tristate "Meson AXG MIPI + PCIE PHY driver" >> > + default ARCH_MESON >> > + depends on OF && (ARCH_MESON || COMPILE_TEST) >> > + select GENERIC_PHY >> > + select MFD_SYSCON >> > + help >> > + Enable this to support the Meson MIPI + PCIE PHY found >> > + in Meson AXG SoCs. >> > + If unsure, say N. >> > diff --git a/drivers/phy/amlogic/Makefile b/drivers/phy/amlogic/Makefile >> > index 11d1c42ac2be..2167330a0ae8 100644 >> > --- a/drivers/phy/amlogic/Makefile >> > +++ b/drivers/phy/amlogic/Makefile >> > @@ -4,3 +4,4 @@ obj-$(CONFIG_PHY_MESON_GXL_USB2) += phy-meson-gxl-usb2.o >> > obj-$(CONFIG_PHY_MESON_G12A_USB2) += phy-meson-g12a-usb2.o >> > obj-$(CONFIG_PHY_MESON_GXL_USB3) += phy-meson-gxl-usb3.o >> > obj-$(CONFIG_PHY_MESON_G12A_USB3_PCIE) += phy-meson-g12a-usb3-pcie.o >> > +obj-$(CONFIG_PHY_MESON_AXG_MIPI_PCIE) += phy-meson-axg-mipi-pcie.o >> > diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie.c b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie.c >> > new file mode 100644 >> > index 000000000000..006aa8cdfc47 >> > --- /dev/null >> > +++ b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie.c >> > @@ -0,0 +1,176 @@ >> > +// SPDX-License-Identifier: GPL-2.0 >> > +/* >> > + * Amlogic AXG MIPI + PCIE PHY driver >> > + * >> > + * Copyright (C) 2019 Remi Pommarel >> > + */ >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > + >> > +#define HHI_MIPI_CNTL0 0x00 >> > +#define HHI_MIPI_CNTL0_COMMON_BLOCK GENMASK(31, 28) >> > +#define HHI_MIPI_CNTL0_ENABLE BIT(29) >> > +#define HHI_MIPI_CNTL0_BANDGAP BIT(26) >> > +#define HHI_MIPI_CNTL0_DECODE_TO_RTERM GENMASK(15, 12) >> > +#define HHI_MIPI_CNTL0_OUTPUT_EN BIT(3) >> > + >> > +#define HHI_MIPI_CNTL1 0x01 >> > +#define HHI_MIPI_CNTL1_CH0_CML_PDR_EN BIT(12) >> > +#define HHI_MIPI_CNTL1_LP_ABILITY GENMASK(5, 4) >> > +#define HHI_MIPI_CNTL1_LP_RESISTER BIT(3) >> > +#define HHI_MIPI_CNTL1_INPUT_SETTING BIT(2) >> > +#define HHI_MIPI_CNTL1_INPUT_SEL BIT(1) >> > +#define HHI_MIPI_CNTL1_PRBS7_EN BIT(0) >> > + >> > +#define HHI_MIPI_CNTL2 0x02 >> > +#define HHI_MIPI_CNTL2_CH_PU GENMASK(31, 25) >> > +#define HHI_MIPI_CNTL2_CH_CTL GENMASK(24, 19) >> > +#define HHI_MIPI_CNTL2_CH0_DIGDR_EN BIT(18) >> > +#define HHI_MIPI_CNTL2_CH_DIGDR_EN BIT(17) >> > +#define HHI_MIPI_CNTL2_LPULPS_EN BIT(16) >> > +#define HHI_MIPI_CNTL2_CH_EN(n) BIT(15 - (n)) >> > +#define HHI_MIPI_CNTL2_CH0_LP_CTL GENMASK(10, 1) >> > + >> > +struct phy_axg_mipi_pcie_priv { >> > + struct phy *phy; >> > + unsigned int mode; >> > + struct regmap *regmap; >> > +}; >> > + >> > +static const struct regmap_config phy_axg_mipi_pcie_regmap_conf = { >> > + .reg_bits = 8, >> > + .val_bits = 32, >> > + .reg_stride = 4, >> > + .max_register = HHI_MIPI_CNTL2, >> > +}; >> > + >> > +static int phy_axg_mipi_pcie_power_on(struct phy *phy) >> > +{ >> > + struct phy_axg_mipi_pcie_priv *priv = phy_get_drvdata(phy); >> > + >> > + /* MIPI not supported yet */ >> > + if (priv->mode != PHY_TYPE_PCIE) >> > + return 0; >> > + >> > + regmap_update_bits(priv->regmap, HHI_MIPI_CNTL0, >> > + HHI_MIPI_CNTL0_BANDGAP, HHI_MIPI_CNTL0_BANDGAP); >> > + >> > + regmap_update_bits(priv->regmap, HHI_MIPI_CNTL0, >> > + HHI_MIPI_CNTL0_ENABLE, HHI_MIPI_CNTL0_ENABLE); >> > + return 0; >> > +} >> > + >> > +static int phy_axg_mipi_pcie_power_off(struct phy *phy) >> > +{ >> > + struct phy_axg_mipi_pcie_priv *priv = phy_get_drvdata(phy); >> > + >> > + /* MIPI not supported yet */ >> > + if (priv->mode != PHY_TYPE_PCIE) >> > + return 0; >> > + >> > + regmap_update_bits(priv->regmap, HHI_MIPI_CNTL0, >> > + HHI_MIPI_CNTL0_BANDGAP, 0); >> > + regmap_update_bits(priv->regmap, HHI_MIPI_CNTL0, >> > + HHI_MIPI_CNTL0_ENABLE, 0); >> > + return 0; >> > +} >> > + >> > +static int phy_axg_mipi_pcie_init(struct phy *phy) >> > +{ >> > + return 0; >> > +} >> > + >> > +static int phy_axg_mipi_pcie_exit(struct phy *phy) >> > +{ >> > + return 0; >> > +} >> > + >> > +static const struct phy_ops phy_axg_mipi_pcie_ops = { >> > + .init = phy_axg_mipi_pcie_init, >> > + .exit = phy_axg_mipi_pcie_exit, >> > + .power_on = phy_axg_mipi_pcie_power_on, >> > + .power_off = phy_axg_mipi_pcie_power_off, >> > + .owner = THIS_MODULE, >> > +}; >> > + >> > +static struct phy *phy_axg_mipi_pcie_xlate(struct device *dev, >> > + struct of_phandle_args *args) >> > +{ >> > + struct phy_axg_mipi_pcie_priv *priv = dev_get_drvdata(dev); >> > + unsigned int mode; >> > + >> > + if (args->args_count != 1) { >> > + dev_err(dev, "invalid number of arguments\n"); >> > + return ERR_PTR(-EINVAL); >> > + } >> > + >> > + mode = args->args[0]; >> > + >> > + /* MIPI mode is not supported yet */ >> > + if (mode != PHY_TYPE_PCIE) { >> > + dev_err(dev, "invalid phy mode select argument\n"); >> > + return ERR_PTR(-EINVAL); >> > + } >> > + >> > + priv->mode = mode; >> > + return priv->phy; >> > +} >> > + >> > +static int phy_axg_mipi_pcie_probe(struct platform_device *pdev) >> > +{ >> > + struct phy_provider *pphy; >> > + struct device *dev = &pdev->dev; >> > + struct phy_axg_mipi_pcie_priv *priv; >> > + struct device_node *np = dev->of_node; >> > + int ret; >> > + >> > + priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); >> > + if (!priv) >> > + return -ENOMEM; >> > + >> > + /* Get the hhi system controller node */ >> > + priv->regmap = syscon_node_to_regmap(of_get_parent(dev->of_node)); >> > + if (IS_ERR(priv->regmap)) { >> > + dev_err(dev, "failed to get HHI regmap\n"); >> > + return PTR_ERR(priv->regmap); >> > + } >> > + >> > + priv->phy = devm_phy_create(dev, np, &phy_axg_mipi_pcie_ops); >> > + if (IS_ERR(priv->phy)) { >> > + ret = PTR_ERR(priv->phy); >> > + if (ret != -EPROBE_DEFER) >> > + dev_err(dev, "failed to create PHY\n"); >> > + return ret; >> > + } >> > + >> > + phy_set_drvdata(priv->phy, priv); >> > + dev_set_drvdata(dev, priv); >> > + pphy = devm_of_phy_provider_register(dev, phy_axg_mipi_pcie_xlate); >> > + >> > + return PTR_ERR_OR_ZERO(pphy); >> > +} >> > + >> > +static const struct of_device_id phy_axg_mipi_pcie_of_match[] = { >> > + { >> > + .compatible = "amlogic,axg-mipi-pcie-phy", >> >> Is there a dt-binding documentation for this? > > There is binding documentation updates for this whole serie but I thought > they were supposed to be sent in separate serie, which is not the case > apparently. Different patches, but same series is recommended ;) > > Thanks, _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic