* [PATCH v2] arm64: dts: meson-a1: add I2C nodes
@ 2019-12-11 3:28 ` Jian Hu
0 siblings, 0 replies; 11+ messages in thread
From: Jian Hu @ 2019-12-11 3:28 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: Jian Hu, Kevin Hilman, Rob Herring, Martin Blumenstingl,
Michael Turquette, Wolfram Sang, Mark Rutland, Jianxin Pan,
linux-amlogic, linux-i2c, linux-arm-kernel, linux-kernel,
devicetree
There are four I2C controllers in A1 series,
Share the same comptible with AXG. Compared to AXG,
Drive strength feature is newly added in A1.
This patch depends on A1 clock driver.
Signed-off-by: Jian Hu <jian.hu@amlogic.com>
---
This patch depends on A1 clock patchset at[0]
Changes since v1 at [1]:
-change reg length to 0x20
-assign i2c bus alias in dts file
-add new feature note compared to AXG in changelog
[0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
[1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
---
---
.../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
2 files changed, 146 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
index 69c25c68c358..2d0457976233 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
@@ -13,6 +13,10 @@
aliases {
serial0 = &uart_AO_B;
+ i2c0 = &i2c0;
+ i2c1 = &i2c1;
+ i2c2 = &i2c2;
+ i2c3 = &i2c3;
};
chosen {
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index eab2ecd36aa8..66d5206a57de 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -117,6 +117,46 @@
};
};
+ i2c0: i2c@1400 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x1400 0x0 0x20>;
+ interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_A>;
+ status = "disabled";
+ };
+
+ i2c1: i2c@5c00 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x5c00 0x0 0x20>;
+ interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_B>;
+ status = "disabled";
+ };
+
+ i2c2: i2c@6800 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x6800 0x0 0x20>;
+ interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_C>;
+ status = "disabled";
+ };
+
+ i2c3: i2c@6c00 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x6c00 0x0 0x20>;
+ interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_D>;
+ status = "disabled";
+ };
+
uart_AO: serial@1c00 {
compatible = "amlogic,meson-gx-uart",
"amlogic,meson-ao-uart";
@@ -171,3 +211,105 @@
#clock-cells = <0>;
};
};
+
+&periphs_pinctrl {
+ i2c0_f11_pins:i2c0-f11 {
+ mux {
+ groups = "i2c0_sck_f11",
+ "i2c0_sda_f12";
+ function = "i2c0";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c0_f9_pins:i2c0-f9 {
+ mux {
+ groups = "i2c0_sck_f9",
+ "i2c0_sda_f10";
+ function = "i2c0";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c1_x_pins:i2c1-x {
+ mux {
+ groups = "i2c1_sck_x",
+ "i2c1_sda_x";
+ function = "i2c1";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c1_a_pins:i2c1-a {
+ mux {
+ groups = "i2c1_sck_a",
+ "i2c1_sda_a";
+ function = "i2c1";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_x0_pins:i2c2-x0 {
+ mux {
+ groups = "i2c2_sck_x0",
+ "i2c2_sda_x1";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_x15_pins:i2c2-x15 {
+ mux {
+ groups = "i2c2_sck_x15",
+ "i2c2_sda_x16";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_a4_pins:i2c2-a4 {
+ mux {
+ groups = "i2c2_sck_a4",
+ "i2c2_sda_a5";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_a8_pins:i2c2-a8 {
+ mux {
+ groups = "i2c2_sck_a8",
+ "i2c2_sda_a9";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c3_x_pins:i2c3-x {
+ mux {
+ groups = "i2c3_sck_x",
+ "i2c3_sda_x";
+ function = "i2c3";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c3_f_pins:i2c3-f {
+ mux {
+ groups = "i2c3_sck_f",
+ "i2c3_sda_f";
+ function = "i2c3";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+};
--
2.24.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2] arm64: dts: meson-a1: add I2C nodes
@ 2019-12-11 3:28 ` Jian Hu
0 siblings, 0 replies; 11+ messages in thread
From: Jian Hu @ 2019-12-11 3:28 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: Jian Hu, Kevin Hilman, Rob Herring, Martin Blumenstingl,
Michael Turquette, Wolfram Sang, Mark Rutland, Jianxin Pan,
linux-amlogic, linux-i2c, linux-arm-kernel, linux-kernel,
devicetree
There are four I2C controllers in A1 series,
Share the same comptible with AXG. Compared to AXG,
Drive strength feature is newly added in A1.
This patch depends on A1 clock driver.
Signed-off-by: Jian Hu <jian.hu@amlogic.com>
---
This patch depends on A1 clock patchset at[0]
Changes since v1 at [1]:
-change reg length to 0x20
-assign i2c bus alias in dts file
-add new feature note compared to AXG in changelog
[0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
[1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
---
---
.../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
2 files changed, 146 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
index 69c25c68c358..2d0457976233 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
@@ -13,6 +13,10 @@
aliases {
serial0 = &uart_AO_B;
+ i2c0 = &i2c0;
+ i2c1 = &i2c1;
+ i2c2 = &i2c2;
+ i2c3 = &i2c3;
};
chosen {
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index eab2ecd36aa8..66d5206a57de 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -117,6 +117,46 @@
};
};
+ i2c0: i2c@1400 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x1400 0x0 0x20>;
+ interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_A>;
+ status = "disabled";
+ };
+
+ i2c1: i2c@5c00 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x5c00 0x0 0x20>;
+ interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_B>;
+ status = "disabled";
+ };
+
+ i2c2: i2c@6800 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x6800 0x0 0x20>;
+ interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_C>;
+ status = "disabled";
+ };
+
+ i2c3: i2c@6c00 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x6c00 0x0 0x20>;
+ interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_D>;
+ status = "disabled";
+ };
+
uart_AO: serial@1c00 {
compatible = "amlogic,meson-gx-uart",
"amlogic,meson-ao-uart";
@@ -171,3 +211,105 @@
#clock-cells = <0>;
};
};
+
+&periphs_pinctrl {
+ i2c0_f11_pins:i2c0-f11 {
+ mux {
+ groups = "i2c0_sck_f11",
+ "i2c0_sda_f12";
+ function = "i2c0";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c0_f9_pins:i2c0-f9 {
+ mux {
+ groups = "i2c0_sck_f9",
+ "i2c0_sda_f10";
+ function = "i2c0";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c1_x_pins:i2c1-x {
+ mux {
+ groups = "i2c1_sck_x",
+ "i2c1_sda_x";
+ function = "i2c1";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c1_a_pins:i2c1-a {
+ mux {
+ groups = "i2c1_sck_a",
+ "i2c1_sda_a";
+ function = "i2c1";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_x0_pins:i2c2-x0 {
+ mux {
+ groups = "i2c2_sck_x0",
+ "i2c2_sda_x1";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_x15_pins:i2c2-x15 {
+ mux {
+ groups = "i2c2_sck_x15",
+ "i2c2_sda_x16";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_a4_pins:i2c2-a4 {
+ mux {
+ groups = "i2c2_sck_a4",
+ "i2c2_sda_a5";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_a8_pins:i2c2-a8 {
+ mux {
+ groups = "i2c2_sck_a8",
+ "i2c2_sda_a9";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c3_x_pins:i2c3-x {
+ mux {
+ groups = "i2c3_sck_x",
+ "i2c3_sda_x";
+ function = "i2c3";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c3_f_pins:i2c3-f {
+ mux {
+ groups = "i2c3_sck_f",
+ "i2c3_sda_f";
+ function = "i2c3";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+};
--
2.24.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2] arm64: dts: meson-a1: add I2C nodes
@ 2019-12-11 3:28 ` Jian Hu
0 siblings, 0 replies; 11+ messages in thread
From: Jian Hu @ 2019-12-11 3:28 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: Mark Rutland, Rob Herring, Jianxin Pan, Wolfram Sang,
Martin Blumenstingl, Kevin Hilman, Michael Turquette,
linux-kernel, devicetree, Jian Hu, linux-i2c, linux-amlogic,
linux-arm-kernel
There are four I2C controllers in A1 series,
Share the same comptible with AXG. Compared to AXG,
Drive strength feature is newly added in A1.
This patch depends on A1 clock driver.
Signed-off-by: Jian Hu <jian.hu@amlogic.com>
---
This patch depends on A1 clock patchset at[0]
Changes since v1 at [1]:
-change reg length to 0x20
-assign i2c bus alias in dts file
-add new feature note compared to AXG in changelog
[0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
[1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
---
---
.../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
2 files changed, 146 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
index 69c25c68c358..2d0457976233 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
@@ -13,6 +13,10 @@
aliases {
serial0 = &uart_AO_B;
+ i2c0 = &i2c0;
+ i2c1 = &i2c1;
+ i2c2 = &i2c2;
+ i2c3 = &i2c3;
};
chosen {
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index eab2ecd36aa8..66d5206a57de 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -117,6 +117,46 @@
};
};
+ i2c0: i2c@1400 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x1400 0x0 0x20>;
+ interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_A>;
+ status = "disabled";
+ };
+
+ i2c1: i2c@5c00 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x5c00 0x0 0x20>;
+ interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_B>;
+ status = "disabled";
+ };
+
+ i2c2: i2c@6800 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x6800 0x0 0x20>;
+ interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_C>;
+ status = "disabled";
+ };
+
+ i2c3: i2c@6c00 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x6c00 0x0 0x20>;
+ interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_D>;
+ status = "disabled";
+ };
+
uart_AO: serial@1c00 {
compatible = "amlogic,meson-gx-uart",
"amlogic,meson-ao-uart";
@@ -171,3 +211,105 @@
#clock-cells = <0>;
};
};
+
+&periphs_pinctrl {
+ i2c0_f11_pins:i2c0-f11 {
+ mux {
+ groups = "i2c0_sck_f11",
+ "i2c0_sda_f12";
+ function = "i2c0";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c0_f9_pins:i2c0-f9 {
+ mux {
+ groups = "i2c0_sck_f9",
+ "i2c0_sda_f10";
+ function = "i2c0";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c1_x_pins:i2c1-x {
+ mux {
+ groups = "i2c1_sck_x",
+ "i2c1_sda_x";
+ function = "i2c1";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c1_a_pins:i2c1-a {
+ mux {
+ groups = "i2c1_sck_a",
+ "i2c1_sda_a";
+ function = "i2c1";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_x0_pins:i2c2-x0 {
+ mux {
+ groups = "i2c2_sck_x0",
+ "i2c2_sda_x1";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_x15_pins:i2c2-x15 {
+ mux {
+ groups = "i2c2_sck_x15",
+ "i2c2_sda_x16";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_a4_pins:i2c2-a4 {
+ mux {
+ groups = "i2c2_sck_a4",
+ "i2c2_sda_a5";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_a8_pins:i2c2-a8 {
+ mux {
+ groups = "i2c2_sck_a8",
+ "i2c2_sda_a9";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c3_x_pins:i2c3-x {
+ mux {
+ groups = "i2c3_sck_x",
+ "i2c3_sda_x";
+ function = "i2c3";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c3_f_pins:i2c3-f {
+ mux {
+ groups = "i2c3_sck_f",
+ "i2c3_sda_f";
+ function = "i2c3";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+};
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2] arm64: dts: meson-a1: add I2C nodes
@ 2019-12-11 3:28 ` Jian Hu
0 siblings, 0 replies; 11+ messages in thread
From: Jian Hu @ 2019-12-11 3:28 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: Mark Rutland, Rob Herring, Jianxin Pan, Wolfram Sang,
Martin Blumenstingl, Kevin Hilman, Michael Turquette,
linux-kernel, devicetree, Jian Hu, linux-i2c, linux-amlogic,
linux-arm-kernel
There are four I2C controllers in A1 series,
Share the same comptible with AXG. Compared to AXG,
Drive strength feature is newly added in A1.
This patch depends on A1 clock driver.
Signed-off-by: Jian Hu <jian.hu@amlogic.com>
---
This patch depends on A1 clock patchset at[0]
Changes since v1 at [1]:
-change reg length to 0x20
-assign i2c bus alias in dts file
-add new feature note compared to AXG in changelog
[0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
[1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
---
---
.../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
2 files changed, 146 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
index 69c25c68c358..2d0457976233 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
@@ -13,6 +13,10 @@
aliases {
serial0 = &uart_AO_B;
+ i2c0 = &i2c0;
+ i2c1 = &i2c1;
+ i2c2 = &i2c2;
+ i2c3 = &i2c3;
};
chosen {
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index eab2ecd36aa8..66d5206a57de 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -117,6 +117,46 @@
};
};
+ i2c0: i2c@1400 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x1400 0x0 0x20>;
+ interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_A>;
+ status = "disabled";
+ };
+
+ i2c1: i2c@5c00 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x5c00 0x0 0x20>;
+ interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_B>;
+ status = "disabled";
+ };
+
+ i2c2: i2c@6800 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x6800 0x0 0x20>;
+ interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_C>;
+ status = "disabled";
+ };
+
+ i2c3: i2c@6c00 {
+ compatible = "amlogic,meson-axg-i2c";
+ reg = <0x0 0x6c00 0x0 0x20>;
+ interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&clkc_periphs CLKID_I2C_M_D>;
+ status = "disabled";
+ };
+
uart_AO: serial@1c00 {
compatible = "amlogic,meson-gx-uart",
"amlogic,meson-ao-uart";
@@ -171,3 +211,105 @@
#clock-cells = <0>;
};
};
+
+&periphs_pinctrl {
+ i2c0_f11_pins:i2c0-f11 {
+ mux {
+ groups = "i2c0_sck_f11",
+ "i2c0_sda_f12";
+ function = "i2c0";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c0_f9_pins:i2c0-f9 {
+ mux {
+ groups = "i2c0_sck_f9",
+ "i2c0_sda_f10";
+ function = "i2c0";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c1_x_pins:i2c1-x {
+ mux {
+ groups = "i2c1_sck_x",
+ "i2c1_sda_x";
+ function = "i2c1";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c1_a_pins:i2c1-a {
+ mux {
+ groups = "i2c1_sck_a",
+ "i2c1_sda_a";
+ function = "i2c1";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_x0_pins:i2c2-x0 {
+ mux {
+ groups = "i2c2_sck_x0",
+ "i2c2_sda_x1";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_x15_pins:i2c2-x15 {
+ mux {
+ groups = "i2c2_sck_x15",
+ "i2c2_sda_x16";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_a4_pins:i2c2-a4 {
+ mux {
+ groups = "i2c2_sck_a4",
+ "i2c2_sda_a5";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c2_a8_pins:i2c2-a8 {
+ mux {
+ groups = "i2c2_sck_a8",
+ "i2c2_sda_a9";
+ function = "i2c2";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c3_x_pins:i2c3-x {
+ mux {
+ groups = "i2c3_sck_x",
+ "i2c3_sda_x";
+ function = "i2c3";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+
+ i2c3_f_pins:i2c3-f {
+ mux {
+ groups = "i2c3_sck_f",
+ "i2c3_sda_f";
+ function = "i2c3";
+ bias-pull-up;
+ drive-strength-microamp = <3000>;
+ };
+ };
+};
--
2.24.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2] arm64: dts: meson-a1: add I2C nodes
2019-12-11 3:28 ` Jian Hu
(?)
@ 2019-12-11 9:34 ` Jerome Brunet
-1 siblings, 0 replies; 11+ messages in thread
From: Jerome Brunet @ 2019-12-11 9:34 UTC (permalink / raw)
To: Jian Hu, Neil Armstrong
Cc: Kevin Hilman, Rob Herring, Martin Blumenstingl,
Michael Turquette, Wolfram Sang, Mark Rutland, Jianxin Pan,
linux-amlogic, linux-i2c, linux-arm-kernel, linux-kernel,
devicetree
On Wed 11 Dec 2019 at 04:28, Jian Hu <jian.hu@amlogic.com> wrote:
> There are four I2C controllers in A1 series,
> Share the same comptible with AXG. Compared to AXG,
> Drive strength feature is newly added in A1.
Until here, OK
> This patch depends on A1 clock driver.
This last sentence is a valuable piece of information for the maintainer
but should not appear is the commit description as it is something we
want is the history
Please move this bellow the '---' *AND*
Add a link like " https://lkml.kernel.org/r/..." to help the maintainer
locate the related series
>
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>
> ---
> This patch depends on A1 clock patchset at[0]
>
> Changes since v1 at [1]:
> -change reg length to 0x20
> -assign i2c bus alias in dts file
> -add new feature note compared to AXG in changelog
>
> [0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
> [1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
> ---
> ---
> .../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
> 2 files changed, 146 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
> index 69c25c68c358..2d0457976233 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
> @@ -13,6 +13,10 @@
>
> aliases {
> serial0 = &uart_AO_B;
> + i2c0 = &i2c0;
> + i2c1 = &i2c1;
> + i2c2 = &i2c2;
> + i2c3 = &i2c3;
It is not necessary to define alias for all the possible buses,
especially it some won't be used on the platform.
Will this platform use all 4 busses ?
In any case, the aliases can added later, as needed when the related i2c
bus is enabled on the board
> };
>
> chosen {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index eab2ecd36aa8..66d5206a57de 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -117,6 +117,46 @@
> };
> };
>
> + i2c0: i2c@1400 {
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x1400 0x0 0x20>;
> + interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_A>;
> + status = "disabled";
> + };
> +
> + i2c1: i2c@5c00 {
Please order nodes by address when then have one.
The 3 following i2c busses should appear after the uarts
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x5c00 0x0 0x20>;
> + interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_B>;
> + status = "disabled";
> + };
> +
> + i2c2: i2c@6800 {
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x6800 0x0 0x20>;
> + interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_C>;
> + status = "disabled";
> + };
> +
> + i2c3: i2c@6c00 {
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x6c00 0x0 0x20>;
> + interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_D>;
> + status = "disabled";
> + };
> +
> uart_AO: serial@1c00 {
> compatible = "amlogic,meson-gx-uart",
> "amlogic,meson-ao-uart";
> @@ -171,3 +211,105 @@
> #clock-cells = <0>;
> };
> };
> +
> +&periphs_pinctrl {
> + i2c0_f11_pins:i2c0-f11 {
> + mux {
> + groups = "i2c0_sck_f11",
> + "i2c0_sda_f12";
> + function = "i2c0";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c0_f9_pins:i2c0-f9 {
When the nodes don't have an address, please order them
alpha-numerically by node name.
> + mux {
> + groups = "i2c0_sck_f9",
> + "i2c0_sda_f10";
> + function = "i2c0";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c1_x_pins:i2c1-x {
> + mux {
> + groups = "i2c1_sck_x",
> + "i2c1_sda_x";
> + function = "i2c1";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c1_a_pins:i2c1-a {
> + mux {
> + groups = "i2c1_sck_a",
> + "i2c1_sda_a";
> + function = "i2c1";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_x0_pins:i2c2-x0 {
> + mux {
> + groups = "i2c2_sck_x0",
> + "i2c2_sda_x1";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_x15_pins:i2c2-x15 {
> + mux {
> + groups = "i2c2_sck_x15",
> + "i2c2_sda_x16";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_a4_pins:i2c2-a4 {
> + mux {
> + groups = "i2c2_sck_a4",
> + "i2c2_sda_a5";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_a8_pins:i2c2-a8 {
> + mux {
> + groups = "i2c2_sck_a8",
> + "i2c2_sda_a9";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c3_x_pins:i2c3-x {
> + mux {
> + groups = "i2c3_sck_x",
> + "i2c3_sda_x";
> + function = "i2c3";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c3_f_pins:i2c3-f {
> + mux {
> + groups = "i2c3_sck_f",
> + "i2c3_sda_f";
> + function = "i2c3";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +};
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] arm64: dts: meson-a1: add I2C nodes
@ 2019-12-11 9:34 ` Jerome Brunet
0 siblings, 0 replies; 11+ messages in thread
From: Jerome Brunet @ 2019-12-11 9:34 UTC (permalink / raw)
To: Jian Hu, Neil Armstrong
Cc: Mark Rutland, Rob Herring, Jianxin Pan, Wolfram Sang,
Martin Blumenstingl, Kevin Hilman, Michael Turquette,
linux-kernel, devicetree, linux-i2c, linux-amlogic,
linux-arm-kernel
On Wed 11 Dec 2019 at 04:28, Jian Hu <jian.hu@amlogic.com> wrote:
> There are four I2C controllers in A1 series,
> Share the same comptible with AXG. Compared to AXG,
> Drive strength feature is newly added in A1.
Until here, OK
> This patch depends on A1 clock driver.
This last sentence is a valuable piece of information for the maintainer
but should not appear is the commit description as it is something we
want is the history
Please move this bellow the '---' *AND*
Add a link like " https://lkml.kernel.org/r/..." to help the maintainer
locate the related series
>
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>
> ---
> This patch depends on A1 clock patchset at[0]
>
> Changes since v1 at [1]:
> -change reg length to 0x20
> -assign i2c bus alias in dts file
> -add new feature note compared to AXG in changelog
>
> [0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
> [1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
> ---
> ---
> .../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
> 2 files changed, 146 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
> index 69c25c68c358..2d0457976233 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
> @@ -13,6 +13,10 @@
>
> aliases {
> serial0 = &uart_AO_B;
> + i2c0 = &i2c0;
> + i2c1 = &i2c1;
> + i2c2 = &i2c2;
> + i2c3 = &i2c3;
It is not necessary to define alias for all the possible buses,
especially it some won't be used on the platform.
Will this platform use all 4 busses ?
In any case, the aliases can added later, as needed when the related i2c
bus is enabled on the board
> };
>
> chosen {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index eab2ecd36aa8..66d5206a57de 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -117,6 +117,46 @@
> };
> };
>
> + i2c0: i2c@1400 {
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x1400 0x0 0x20>;
> + interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_A>;
> + status = "disabled";
> + };
> +
> + i2c1: i2c@5c00 {
Please order nodes by address when then have one.
The 3 following i2c busses should appear after the uarts
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x5c00 0x0 0x20>;
> + interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_B>;
> + status = "disabled";
> + };
> +
> + i2c2: i2c@6800 {
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x6800 0x0 0x20>;
> + interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_C>;
> + status = "disabled";
> + };
> +
> + i2c3: i2c@6c00 {
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x6c00 0x0 0x20>;
> + interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_D>;
> + status = "disabled";
> + };
> +
> uart_AO: serial@1c00 {
> compatible = "amlogic,meson-gx-uart",
> "amlogic,meson-ao-uart";
> @@ -171,3 +211,105 @@
> #clock-cells = <0>;
> };
> };
> +
> +&periphs_pinctrl {
> + i2c0_f11_pins:i2c0-f11 {
> + mux {
> + groups = "i2c0_sck_f11",
> + "i2c0_sda_f12";
> + function = "i2c0";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c0_f9_pins:i2c0-f9 {
When the nodes don't have an address, please order them
alpha-numerically by node name.
> + mux {
> + groups = "i2c0_sck_f9",
> + "i2c0_sda_f10";
> + function = "i2c0";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c1_x_pins:i2c1-x {
> + mux {
> + groups = "i2c1_sck_x",
> + "i2c1_sda_x";
> + function = "i2c1";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c1_a_pins:i2c1-a {
> + mux {
> + groups = "i2c1_sck_a",
> + "i2c1_sda_a";
> + function = "i2c1";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_x0_pins:i2c2-x0 {
> + mux {
> + groups = "i2c2_sck_x0",
> + "i2c2_sda_x1";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_x15_pins:i2c2-x15 {
> + mux {
> + groups = "i2c2_sck_x15",
> + "i2c2_sda_x16";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_a4_pins:i2c2-a4 {
> + mux {
> + groups = "i2c2_sck_a4",
> + "i2c2_sda_a5";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_a8_pins:i2c2-a8 {
> + mux {
> + groups = "i2c2_sck_a8",
> + "i2c2_sda_a9";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c3_x_pins:i2c3-x {
> + mux {
> + groups = "i2c3_sck_x",
> + "i2c3_sda_x";
> + function = "i2c3";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c3_f_pins:i2c3-f {
> + mux {
> + groups = "i2c3_sck_f",
> + "i2c3_sda_f";
> + function = "i2c3";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] arm64: dts: meson-a1: add I2C nodes
@ 2019-12-11 9:34 ` Jerome Brunet
0 siblings, 0 replies; 11+ messages in thread
From: Jerome Brunet @ 2019-12-11 9:34 UTC (permalink / raw)
To: Jian Hu, Neil Armstrong
Cc: Mark Rutland, Rob Herring, Jianxin Pan, Wolfram Sang,
Martin Blumenstingl, Kevin Hilman, Michael Turquette,
linux-kernel, devicetree, linux-i2c, linux-amlogic,
linux-arm-kernel
On Wed 11 Dec 2019 at 04:28, Jian Hu <jian.hu@amlogic.com> wrote:
> There are four I2C controllers in A1 series,
> Share the same comptible with AXG. Compared to AXG,
> Drive strength feature is newly added in A1.
Until here, OK
> This patch depends on A1 clock driver.
This last sentence is a valuable piece of information for the maintainer
but should not appear is the commit description as it is something we
want is the history
Please move this bellow the '---' *AND*
Add a link like " https://lkml.kernel.org/r/..." to help the maintainer
locate the related series
>
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>
> ---
> This patch depends on A1 clock patchset at[0]
>
> Changes since v1 at [1]:
> -change reg length to 0x20
> -assign i2c bus alias in dts file
> -add new feature note compared to AXG in changelog
>
> [0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
> [1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
> ---
> ---
> .../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
> 2 files changed, 146 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
> index 69c25c68c358..2d0457976233 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
> @@ -13,6 +13,10 @@
>
> aliases {
> serial0 = &uart_AO_B;
> + i2c0 = &i2c0;
> + i2c1 = &i2c1;
> + i2c2 = &i2c2;
> + i2c3 = &i2c3;
It is not necessary to define alias for all the possible buses,
especially it some won't be used on the platform.
Will this platform use all 4 busses ?
In any case, the aliases can added later, as needed when the related i2c
bus is enabled on the board
> };
>
> chosen {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index eab2ecd36aa8..66d5206a57de 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -117,6 +117,46 @@
> };
> };
>
> + i2c0: i2c@1400 {
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x1400 0x0 0x20>;
> + interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_A>;
> + status = "disabled";
> + };
> +
> + i2c1: i2c@5c00 {
Please order nodes by address when then have one.
The 3 following i2c busses should appear after the uarts
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x5c00 0x0 0x20>;
> + interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_B>;
> + status = "disabled";
> + };
> +
> + i2c2: i2c@6800 {
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x6800 0x0 0x20>;
> + interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_C>;
> + status = "disabled";
> + };
> +
> + i2c3: i2c@6c00 {
> + compatible = "amlogic,meson-axg-i2c";
> + reg = <0x0 0x6c00 0x0 0x20>;
> + interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&clkc_periphs CLKID_I2C_M_D>;
> + status = "disabled";
> + };
> +
> uart_AO: serial@1c00 {
> compatible = "amlogic,meson-gx-uart",
> "amlogic,meson-ao-uart";
> @@ -171,3 +211,105 @@
> #clock-cells = <0>;
> };
> };
> +
> +&periphs_pinctrl {
> + i2c0_f11_pins:i2c0-f11 {
> + mux {
> + groups = "i2c0_sck_f11",
> + "i2c0_sda_f12";
> + function = "i2c0";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c0_f9_pins:i2c0-f9 {
When the nodes don't have an address, please order them
alpha-numerically by node name.
> + mux {
> + groups = "i2c0_sck_f9",
> + "i2c0_sda_f10";
> + function = "i2c0";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c1_x_pins:i2c1-x {
> + mux {
> + groups = "i2c1_sck_x",
> + "i2c1_sda_x";
> + function = "i2c1";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c1_a_pins:i2c1-a {
> + mux {
> + groups = "i2c1_sck_a",
> + "i2c1_sda_a";
> + function = "i2c1";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_x0_pins:i2c2-x0 {
> + mux {
> + groups = "i2c2_sck_x0",
> + "i2c2_sda_x1";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_x15_pins:i2c2-x15 {
> + mux {
> + groups = "i2c2_sck_x15",
> + "i2c2_sda_x16";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_a4_pins:i2c2-a4 {
> + mux {
> + groups = "i2c2_sck_a4",
> + "i2c2_sda_a5";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c2_a8_pins:i2c2-a8 {
> + mux {
> + groups = "i2c2_sck_a8",
> + "i2c2_sda_a9";
> + function = "i2c2";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c3_x_pins:i2c3-x {
> + mux {
> + groups = "i2c3_sck_x",
> + "i2c3_sda_x";
> + function = "i2c3";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +
> + i2c3_f_pins:i2c3-f {
> + mux {
> + groups = "i2c3_sck_f",
> + "i2c3_sda_f";
> + function = "i2c3";
> + bias-pull-up;
> + drive-strength-microamp = <3000>;
> + };
> + };
> +};
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] arm64: dts: meson-a1: add I2C nodes
2019-12-11 9:34 ` Jerome Brunet
(?)
(?)
@ 2019-12-11 12:21 ` Jian Hu
-1 siblings, 0 replies; 11+ messages in thread
From: Jian Hu @ 2019-12-11 12:21 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: Kevin Hilman, Rob Herring, Martin Blumenstingl,
Michael Turquette, Wolfram Sang, Mark Rutland, Jianxin Pan,
linux-amlogic, linux-i2c, linux-arm-kernel, linux-kernel,
devicetree
On 2019/12/11 17:34, Jerome Brunet wrote:
>
> On Wed 11 Dec 2019 at 04:28, Jian Hu <jian.hu@amlogic.com> wrote:
>
>> There are four I2C controllers in A1 series,
>> Share the same comptible with AXG. Compared to AXG,
>> Drive strength feature is newly added in A1.
>
> Until here, OK
>
>> This patch depends on A1 clock driver.
>
> This last sentence is a valuable piece of information for the maintainer
> but should not appear is the commit description as it is something we
> want is the history
>
OK, I will remove the last sentence.
> Please move this bellow the '---' *AND*
> Add a link like " https://lkml.kernel.org/r/..." to help the maintainer
> locate the related series
>
OK, I have added the dependent patch link below.
>
>>
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>>
>> ---
>> This patch depends on A1 clock patchset at[0]
>>
>> Changes since v1 at [1]:
>> -change reg length to 0x20
>> -assign i2c bus alias in dts file
>> -add new feature note compared to AXG in changelog
>>
>> [0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
>> [1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
>> ---
>> ---
>> .../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
>> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
>> 2 files changed, 146 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> index 69c25c68c358..2d0457976233 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> @@ -13,6 +13,10 @@
>>
>> aliases {
>> serial0 = &uart_AO_B;
>> + i2c0 = &i2c0;
>> + i2c1 = &i2c1;
>> + i2c2 = &i2c2;
>> + i2c3 = &i2c3;
>
> It is not necessary to define alias for all the possible buses,
> especially it some won't be used on the platform.
>
> Will this platform use all 4 busses ?
>
it will not use all 4 busses.
> In any case, the aliases can added later, as needed when the related i2c
> bus is enabled on the board
OK, I will remove the i2c bus alias first. It will be added when used.
>
>> };
>>
>> chosen {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> index eab2ecd36aa8..66d5206a57de 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> @@ -117,6 +117,46 @@
>> };
>> };
>>
>> + i2c0: i2c@1400 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x1400 0x0 0x20>;
>> + interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_A>;
>> + status = "disabled";
>> + };
>> +
>> + i2c1: i2c@5c00 {
>
> Please order nodes by address when then have one.
> The 3 following i2c busses should appear after the uarts
OK, I will order them by address.
>
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x5c00 0x0 0x20>;
>> + interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_B>;
>> + status = "disabled";
>> + };
>> +
>> + i2c2: i2c@6800 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x6800 0x0 0x20>;
>> + interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_C>;
>> + status = "disabled";
>> + };
>> +
>> + i2c3: i2c@6c00 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x6c00 0x0 0x20>;
>> + interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_D>;
>> + status = "disabled";
>> + };
>> +
>> uart_AO: serial@1c00 {
>> compatible = "amlogic,meson-gx-uart",
>> "amlogic,meson-ao-uart";
>> @@ -171,3 +211,105 @@
>> #clock-cells = <0>;
>> };
>> };
>> +
>> +&periphs_pinctrl {
>> + i2c0_f11_pins:i2c0-f11 {
>> + mux {
>> + groups = "i2c0_sck_f11",
>> + "i2c0_sda_f12";
>> + function = "i2c0";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c0_f9_pins:i2c0-f9 {
>
> When the nodes don't have an address, please order them
> alpha-numerically by node name.
Ok, I will order the node alpha-numerically.
>
>> + mux {
>> + groups = "i2c0_sck_f9",
>> + "i2c0_sda_f10";
>> + function = "i2c0";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c1_x_pins:i2c1-x {
>> + mux {
>> + groups = "i2c1_sck_x",
>> + "i2c1_sda_x";
>> + function = "i2c1";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c1_a_pins:i2c1-a {
>> + mux {
>> + groups = "i2c1_sck_a",
>> + "i2c1_sda_a";
>> + function = "i2c1";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_x0_pins:i2c2-x0 {
>> + mux {
>> + groups = "i2c2_sck_x0",
>> + "i2c2_sda_x1";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_x15_pins:i2c2-x15 {
>> + mux {
>> + groups = "i2c2_sck_x15",
>> + "i2c2_sda_x16";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_a4_pins:i2c2-a4 {
>> + mux {
>> + groups = "i2c2_sck_a4",
>> + "i2c2_sda_a5";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_a8_pins:i2c2-a8 {
>> + mux {
>> + groups = "i2c2_sck_a8",
>> + "i2c2_sda_a9";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c3_x_pins:i2c3-x {
>> + mux {
>> + groups = "i2c3_sck_x",
>> + "i2c3_sda_x";
>> + function = "i2c3";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c3_f_pins:i2c3-f {
>> + mux {
>> + groups = "i2c3_sck_f",
>> + "i2c3_sda_f";
>> + function = "i2c3";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +};
>
> .
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] arm64: dts: meson-a1: add I2C nodes
@ 2019-12-11 12:21 ` Jian Hu
0 siblings, 0 replies; 11+ messages in thread
From: Jian Hu @ 2019-12-11 12:21 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: Kevin Hilman, Rob Herring, Martin Blumenstingl,
Michael Turquette, Wolfram Sang, Mark Rutland, Jianxin Pan,
linux-amlogic, linux-i2c, linux-arm-kernel, linux-kernel,
devicetree
On 2019/12/11 17:34, Jerome Brunet wrote:
>
> On Wed 11 Dec 2019 at 04:28, Jian Hu <jian.hu@amlogic.com> wrote:
>
>> There are four I2C controllers in A1 series,
>> Share the same comptible with AXG. Compared to AXG,
>> Drive strength feature is newly added in A1.
>
> Until here, OK
>
>> This patch depends on A1 clock driver.
>
> This last sentence is a valuable piece of information for the maintainer
> but should not appear is the commit description as it is something we
> want is the history
>
OK, I will remove the last sentence.
> Please move this bellow the '---' *AND*
> Add a link like " https://lkml.kernel.org/r/..." to help the maintainer
> locate the related series
>
OK, I have added the dependent patch link below.
>
>>
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>>
>> ---
>> This patch depends on A1 clock patchset at[0]
>>
>> Changes since v1 at [1]:
>> -change reg length to 0x20
>> -assign i2c bus alias in dts file
>> -add new feature note compared to AXG in changelog
>>
>> [0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
>> [1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
>> ---
>> ---
>> .../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
>> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
>> 2 files changed, 146 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> index 69c25c68c358..2d0457976233 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> @@ -13,6 +13,10 @@
>>
>> aliases {
>> serial0 = &uart_AO_B;
>> + i2c0 = &i2c0;
>> + i2c1 = &i2c1;
>> + i2c2 = &i2c2;
>> + i2c3 = &i2c3;
>
> It is not necessary to define alias for all the possible buses,
> especially it some won't be used on the platform.
>
> Will this platform use all 4 busses ?
>
it will not use all 4 busses.
> In any case, the aliases can added later, as needed when the related i2c
> bus is enabled on the board
OK, I will remove the i2c bus alias first. It will be added when used.
>
>> };
>>
>> chosen {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> index eab2ecd36aa8..66d5206a57de 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> @@ -117,6 +117,46 @@
>> };
>> };
>>
>> + i2c0: i2c@1400 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x1400 0x0 0x20>;
>> + interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_A>;
>> + status = "disabled";
>> + };
>> +
>> + i2c1: i2c@5c00 {
>
> Please order nodes by address when then have one.
> The 3 following i2c busses should appear after the uarts
OK, I will order them by address.
>
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x5c00 0x0 0x20>;
>> + interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_B>;
>> + status = "disabled";
>> + };
>> +
>> + i2c2: i2c@6800 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x6800 0x0 0x20>;
>> + interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_C>;
>> + status = "disabled";
>> + };
>> +
>> + i2c3: i2c@6c00 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x6c00 0x0 0x20>;
>> + interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_D>;
>> + status = "disabled";
>> + };
>> +
>> uart_AO: serial@1c00 {
>> compatible = "amlogic,meson-gx-uart",
>> "amlogic,meson-ao-uart";
>> @@ -171,3 +211,105 @@
>> #clock-cells = <0>;
>> };
>> };
>> +
>> +&periphs_pinctrl {
>> + i2c0_f11_pins:i2c0-f11 {
>> + mux {
>> + groups = "i2c0_sck_f11",
>> + "i2c0_sda_f12";
>> + function = "i2c0";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c0_f9_pins:i2c0-f9 {
>
> When the nodes don't have an address, please order them
> alpha-numerically by node name.
Ok, I will order the node alpha-numerically.
>
>> + mux {
>> + groups = "i2c0_sck_f9",
>> + "i2c0_sda_f10";
>> + function = "i2c0";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c1_x_pins:i2c1-x {
>> + mux {
>> + groups = "i2c1_sck_x",
>> + "i2c1_sda_x";
>> + function = "i2c1";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c1_a_pins:i2c1-a {
>> + mux {
>> + groups = "i2c1_sck_a",
>> + "i2c1_sda_a";
>> + function = "i2c1";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_x0_pins:i2c2-x0 {
>> + mux {
>> + groups = "i2c2_sck_x0",
>> + "i2c2_sda_x1";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_x15_pins:i2c2-x15 {
>> + mux {
>> + groups = "i2c2_sck_x15",
>> + "i2c2_sda_x16";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_a4_pins:i2c2-a4 {
>> + mux {
>> + groups = "i2c2_sck_a4",
>> + "i2c2_sda_a5";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_a8_pins:i2c2-a8 {
>> + mux {
>> + groups = "i2c2_sck_a8",
>> + "i2c2_sda_a9";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c3_x_pins:i2c3-x {
>> + mux {
>> + groups = "i2c3_sck_x",
>> + "i2c3_sda_x";
>> + function = "i2c3";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c3_f_pins:i2c3-f {
>> + mux {
>> + groups = "i2c3_sck_f",
>> + "i2c3_sda_f";
>> + function = "i2c3";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +};
>
> .
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] arm64: dts: meson-a1: add I2C nodes
@ 2019-12-11 12:21 ` Jian Hu
0 siblings, 0 replies; 11+ messages in thread
From: Jian Hu @ 2019-12-11 12:21 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: Mark Rutland, Rob Herring, Jianxin Pan, Wolfram Sang,
Martin Blumenstingl, Kevin Hilman, Michael Turquette,
linux-kernel, devicetree, linux-i2c, linux-amlogic,
linux-arm-kernel
On 2019/12/11 17:34, Jerome Brunet wrote:
>
> On Wed 11 Dec 2019 at 04:28, Jian Hu <jian.hu@amlogic.com> wrote:
>
>> There are four I2C controllers in A1 series,
>> Share the same comptible with AXG. Compared to AXG,
>> Drive strength feature is newly added in A1.
>
> Until here, OK
>
>> This patch depends on A1 clock driver.
>
> This last sentence is a valuable piece of information for the maintainer
> but should not appear is the commit description as it is something we
> want is the history
>
OK, I will remove the last sentence.
> Please move this bellow the '---' *AND*
> Add a link like " https://lkml.kernel.org/r/..." to help the maintainer
> locate the related series
>
OK, I have added the dependent patch link below.
>
>>
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>>
>> ---
>> This patch depends on A1 clock patchset at[0]
>>
>> Changes since v1 at [1]:
>> -change reg length to 0x20
>> -assign i2c bus alias in dts file
>> -add new feature note compared to AXG in changelog
>>
>> [0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
>> [1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
>> ---
>> ---
>> .../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
>> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
>> 2 files changed, 146 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> index 69c25c68c358..2d0457976233 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> @@ -13,6 +13,10 @@
>>
>> aliases {
>> serial0 = &uart_AO_B;
>> + i2c0 = &i2c0;
>> + i2c1 = &i2c1;
>> + i2c2 = &i2c2;
>> + i2c3 = &i2c3;
>
> It is not necessary to define alias for all the possible buses,
> especially it some won't be used on the platform.
>
> Will this platform use all 4 busses ?
>
it will not use all 4 busses.
> In any case, the aliases can added later, as needed when the related i2c
> bus is enabled on the board
OK, I will remove the i2c bus alias first. It will be added when used.
>
>> };
>>
>> chosen {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> index eab2ecd36aa8..66d5206a57de 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> @@ -117,6 +117,46 @@
>> };
>> };
>>
>> + i2c0: i2c@1400 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x1400 0x0 0x20>;
>> + interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_A>;
>> + status = "disabled";
>> + };
>> +
>> + i2c1: i2c@5c00 {
>
> Please order nodes by address when then have one.
> The 3 following i2c busses should appear after the uarts
OK, I will order them by address.
>
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x5c00 0x0 0x20>;
>> + interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_B>;
>> + status = "disabled";
>> + };
>> +
>> + i2c2: i2c@6800 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x6800 0x0 0x20>;
>> + interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_C>;
>> + status = "disabled";
>> + };
>> +
>> + i2c3: i2c@6c00 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x6c00 0x0 0x20>;
>> + interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_D>;
>> + status = "disabled";
>> + };
>> +
>> uart_AO: serial@1c00 {
>> compatible = "amlogic,meson-gx-uart",
>> "amlogic,meson-ao-uart";
>> @@ -171,3 +211,105 @@
>> #clock-cells = <0>;
>> };
>> };
>> +
>> +&periphs_pinctrl {
>> + i2c0_f11_pins:i2c0-f11 {
>> + mux {
>> + groups = "i2c0_sck_f11",
>> + "i2c0_sda_f12";
>> + function = "i2c0";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c0_f9_pins:i2c0-f9 {
>
> When the nodes don't have an address, please order them
> alpha-numerically by node name.
Ok, I will order the node alpha-numerically.
>
>> + mux {
>> + groups = "i2c0_sck_f9",
>> + "i2c0_sda_f10";
>> + function = "i2c0";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c1_x_pins:i2c1-x {
>> + mux {
>> + groups = "i2c1_sck_x",
>> + "i2c1_sda_x";
>> + function = "i2c1";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c1_a_pins:i2c1-a {
>> + mux {
>> + groups = "i2c1_sck_a",
>> + "i2c1_sda_a";
>> + function = "i2c1";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_x0_pins:i2c2-x0 {
>> + mux {
>> + groups = "i2c2_sck_x0",
>> + "i2c2_sda_x1";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_x15_pins:i2c2-x15 {
>> + mux {
>> + groups = "i2c2_sck_x15",
>> + "i2c2_sda_x16";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_a4_pins:i2c2-a4 {
>> + mux {
>> + groups = "i2c2_sck_a4",
>> + "i2c2_sda_a5";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_a8_pins:i2c2-a8 {
>> + mux {
>> + groups = "i2c2_sck_a8",
>> + "i2c2_sda_a9";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c3_x_pins:i2c3-x {
>> + mux {
>> + groups = "i2c3_sck_x",
>> + "i2c3_sda_x";
>> + function = "i2c3";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c3_f_pins:i2c3-f {
>> + mux {
>> + groups = "i2c3_sck_f",
>> + "i2c3_sda_f";
>> + function = "i2c3";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +};
>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] arm64: dts: meson-a1: add I2C nodes
@ 2019-12-11 12:21 ` Jian Hu
0 siblings, 0 replies; 11+ messages in thread
From: Jian Hu @ 2019-12-11 12:21 UTC (permalink / raw)
To: Jerome Brunet, Neil Armstrong
Cc: Mark Rutland, Rob Herring, Jianxin Pan, Wolfram Sang,
Martin Blumenstingl, Kevin Hilman, Michael Turquette,
linux-kernel, devicetree, linux-i2c, linux-amlogic,
linux-arm-kernel
On 2019/12/11 17:34, Jerome Brunet wrote:
>
> On Wed 11 Dec 2019 at 04:28, Jian Hu <jian.hu@amlogic.com> wrote:
>
>> There are four I2C controllers in A1 series,
>> Share the same comptible with AXG. Compared to AXG,
>> Drive strength feature is newly added in A1.
>
> Until here, OK
>
>> This patch depends on A1 clock driver.
>
> This last sentence is a valuable piece of information for the maintainer
> but should not appear is the commit description as it is something we
> want is the history
>
OK, I will remove the last sentence.
> Please move this bellow the '---' *AND*
> Add a link like " https://lkml.kernel.org/r/..." to help the maintainer
> locate the related series
>
OK, I have added the dependent patch link below.
>
>>
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>>
>> ---
>> This patch depends on A1 clock patchset at[0]
>>
>> Changes since v1 at [1]:
>> -change reg length to 0x20
>> -assign i2c bus alias in dts file
>> -add new feature note compared to AXG in changelog
>>
>> [0] https://lkml.kernel.org/r/20191206074052.15557-1-jian.hu@amlogic.com
>> [1] https://lkml.kernel.org/r/20191202111253.94872-1-jian.hu@amlogic.com
>> ---
>> ---
>> .../arm64/boot/dts/amlogic/meson-a1-ad401.dts | 4 +
>> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 142 ++++++++++++++++++
>> 2 files changed, 146 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> index 69c25c68c358..2d0457976233 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad401.dts
>> @@ -13,6 +13,10 @@
>>
>> aliases {
>> serial0 = &uart_AO_B;
>> + i2c0 = &i2c0;
>> + i2c1 = &i2c1;
>> + i2c2 = &i2c2;
>> + i2c3 = &i2c3;
>
> It is not necessary to define alias for all the possible buses,
> especially it some won't be used on the platform.
>
> Will this platform use all 4 busses ?
>
it will not use all 4 busses.
> In any case, the aliases can added later, as needed when the related i2c
> bus is enabled on the board
OK, I will remove the i2c bus alias first. It will be added when used.
>
>> };
>>
>> chosen {
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> index eab2ecd36aa8..66d5206a57de 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
>> @@ -117,6 +117,46 @@
>> };
>> };
>>
>> + i2c0: i2c@1400 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x1400 0x0 0x20>;
>> + interrupts = <GIC_SPI 32 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_A>;
>> + status = "disabled";
>> + };
>> +
>> + i2c1: i2c@5c00 {
>
> Please order nodes by address when then have one.
> The 3 following i2c busses should appear after the uarts
OK, I will order them by address.
>
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x5c00 0x0 0x20>;
>> + interrupts = <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_B>;
>> + status = "disabled";
>> + };
>> +
>> + i2c2: i2c@6800 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x6800 0x0 0x20>;
>> + interrupts = <GIC_SPI 76 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_C>;
>> + status = "disabled";
>> + };
>> +
>> + i2c3: i2c@6c00 {
>> + compatible = "amlogic,meson-axg-i2c";
>> + reg = <0x0 0x6c00 0x0 0x20>;
>> + interrupts = <GIC_SPI 78 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clocks = <&clkc_periphs CLKID_I2C_M_D>;
>> + status = "disabled";
>> + };
>> +
>> uart_AO: serial@1c00 {
>> compatible = "amlogic,meson-gx-uart",
>> "amlogic,meson-ao-uart";
>> @@ -171,3 +211,105 @@
>> #clock-cells = <0>;
>> };
>> };
>> +
>> +&periphs_pinctrl {
>> + i2c0_f11_pins:i2c0-f11 {
>> + mux {
>> + groups = "i2c0_sck_f11",
>> + "i2c0_sda_f12";
>> + function = "i2c0";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c0_f9_pins:i2c0-f9 {
>
> When the nodes don't have an address, please order them
> alpha-numerically by node name.
Ok, I will order the node alpha-numerically.
>
>> + mux {
>> + groups = "i2c0_sck_f9",
>> + "i2c0_sda_f10";
>> + function = "i2c0";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c1_x_pins:i2c1-x {
>> + mux {
>> + groups = "i2c1_sck_x",
>> + "i2c1_sda_x";
>> + function = "i2c1";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c1_a_pins:i2c1-a {
>> + mux {
>> + groups = "i2c1_sck_a",
>> + "i2c1_sda_a";
>> + function = "i2c1";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_x0_pins:i2c2-x0 {
>> + mux {
>> + groups = "i2c2_sck_x0",
>> + "i2c2_sda_x1";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_x15_pins:i2c2-x15 {
>> + mux {
>> + groups = "i2c2_sck_x15",
>> + "i2c2_sda_x16";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_a4_pins:i2c2-a4 {
>> + mux {
>> + groups = "i2c2_sck_a4",
>> + "i2c2_sda_a5";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c2_a8_pins:i2c2-a8 {
>> + mux {
>> + groups = "i2c2_sck_a8",
>> + "i2c2_sda_a9";
>> + function = "i2c2";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c3_x_pins:i2c3-x {
>> + mux {
>> + groups = "i2c3_sck_x",
>> + "i2c3_sda_x";
>> + function = "i2c3";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +
>> + i2c3_f_pins:i2c3-f {
>> + mux {
>> + groups = "i2c3_sck_f",
>> + "i2c3_sda_f";
>> + function = "i2c3";
>> + bias-pull-up;
>> + drive-strength-microamp = <3000>;
>> + };
>> + };
>> +};
>
> .
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-12-11 12:21 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 3:28 [PATCH v2] arm64: dts: meson-a1: add I2C nodes Jian Hu
2019-12-11 3:28 ` Jian Hu
2019-12-11 3:28 ` Jian Hu
2019-12-11 3:28 ` Jian Hu
2019-12-11 9:34 ` Jerome Brunet
2019-12-11 9:34 ` Jerome Brunet
2019-12-11 9:34 ` Jerome Brunet
2019-12-11 12:21 ` Jian Hu
2019-12-11 12:21 ` Jian Hu
2019-12-11 12:21 ` Jian Hu
2019-12-11 12:21 ` Jian Hu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.