Re: [RFC/PATCH] Force using Tcl/Tk 8.4 on Mac OS X

[lists@haller-berlin.de (Stefan Haller)]

Daniel A. Steffen <das@users.sourceforge.net> wrote:

> On Sep 6, 2010, at 10:07 AM, Stefan Haller wrote:
> 
> > When using Git Gui.app on a Snow Leopard system with Tcl/Tk 8.5,
> > there are two problems:
> > 
> > 1) Menu commands that open a dialog (e.g. "Push" or "Revert changes")
> >   don't work when invoked via their keyboard shortcuts. You get a
> >   dialog without a title bar, and the application then hangs without
> >   further responding to any user input; you need to kill it. Invoking
> >   the same commands with the mouse by choosing from the menu works fine.
> 
> first time I hear of this (or see this myself, and I use git gui every day
> on Mac OS X); in part this may be due to the fact that many of the menu
> shortcuts assigned by git gui conflict with existing OS X shortcuts and
> don't work anyway e.g. cmd-A (esp if a text widget is in focus)...
> 
> personally I would hate for my git gui to be downgraded to Tk 8.4 and
> Carbon because of this small issue, and I'm unlikely to be alone.

It's not a small issue for me, but I agree that downgrading to 8.4 is
the wrong solution.

> An effective small workaround for the problem appears to be to turn off
> the menu accelerators for the affected commands (the key shortcuts will
> still work, since the actual key bindings are independent of the menu
> accelerators), see below.

This does indeed solve the problem, but at a high price; having the menu
accelerators not visible in the menu is not a satisfactory solution.
(For me personally it's ok, but not for new users.)

Is there no other way to work around this in git gui, like maybe
deferring the command invocation with a one-shot timer or something?

> Is there a complete list of menu shortcuts that bring up a dialog?

As far as I can see, it's

    Branch/Create
    Branch/Checkout
    Commit/Revert Changes
    Merge/Local Merge
    Remote/Push

> Ultimately the right way to address this issue is to fix it in Tk, please
> report this in the Tk bug tracker if you haven't already, a quick glance
> in the debugger shows a hang in recursive event loop invocation such as
> used by tk_dialog when called from a menu accelerator callback.

Will do, thanks.

> > 2) The colored pane headers (red, green, yellow) are all grey.
> 
> this is intentional and triggered by the use of ttk, there is a config
> setting to turn it off (gui.usettk)

I'm not sure I understand. On a Windows system with Tk 8.5 and ttk on,
the pane headers are still colored.  Why is it desirable to have them
grey on Mac?

-Stefan


-- 
Stefan Haller
Berlin, Germany
http://www.haller-berlin.de/