From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A4E18021 for ; Fri, 15 Mar 2024 10:01:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710496888; cv=none; b=eB/hA5SOa/4o7RZzqDXhVC+Ny/uh10OSOgsHacLHnjXdc8zc8HNa7D87EK1Phd65CoTdLHPLQaHBi/+Y7oN6h6xSlqJ4HnZBjmuo7DQRLqfsC3JdHpaz7DldS6lKrD5N+9w/BbmCIWDauZphw2hzDWPuZoDWWzOHsLXtPyFgqkY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710496888; c=relaxed/simple; bh=gacD0vR1r8l6qYGtakyqNg/sNRdABilWR9geZMBzIqY=; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID: MIME-Version:Content-Type; b=I/ofFlYAZvxvpEA3UZ2vYRClGK5qkFT9jhEIIPsBKv/d2CRjtpfOtZvizznNnzCetQvu2CpnGw7r6B+Bav+XANbZEkTP84IrgV3WyhhPTIh2o3TJGb8Q/QZ0gnKwFsnMb5vRY08poUfpVty+gkbbW3wuDOCHC0mkreIS+Zj9WZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=nlK5bv2i; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="nlK5bv2i" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-414008713beso2728065e9.1 for ; Fri, 15 Mar 2024 03:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710496884; x=1711101684; darn=vger.kernel.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=fWhlUz33vWZPgCe1jVxjs/Yq8Zn8UQqggbMUOeu+zYA=; b=nlK5bv2iZIs6DLhQbcorkDWWig6i2Zs//yFuBtTGg0hivLi5rY3PgbpZ8tmV9/kteP 0EdssU1VXeyowlgHtDNYqxEMbO9m17j9T1Mgj0xT9H+xqlZinLy3cVraYw04ravkyc2C g2dkIQkRGH0EmcEUaORHZ2eG3uPfKI++sqaAwgTFQrsP5PNr6FuUfC6ri6Oxls3sJpR5 p4HuyZHA9Z1DglfgQOinEzNhWyhneuklWQKgO41ES4E8+UK+9tHwCxm3I0VuCG84JOZw xZUsshVdq2qSC5bBekn/7Iand7YMrKopHZ0HTd7v3KTIpa0nXfKapUE4bGVorimqPb98 4HpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710496884; x=1711101684; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fWhlUz33vWZPgCe1jVxjs/Yq8Zn8UQqggbMUOeu+zYA=; b=lm9Y2NuXWJOFL8j/vJRQVoGEN0lfoRzyiM0c88tDMwFvyD15orLOzC9EBQkoH1VXi+ VBnRANK9CU7tsgJzbhMP37VR2kHfZPhRMJDYQu2g82Wl2fvyhRry0aeEkYy/80KH54O2 J/D+nXaNvrYsR+iIjed+3rjcTD8Q+w69RenRucyl7Ma2myUIhv6xFNAf7RvC1Aubg0ot OB+8FQGacNKPjt7FDbVyFY2cIqd8CP3NQ07nuxO6NIFccum3PpdPks8a8I/25ecIegSo 2tfL+4Fj89wJNikAFhWgzvAjGG9SJh1QfCDQgqJA5kC5slymGsc2+4EWqOm4BC4VJhG+ bbfg== X-Forwarded-Encrypted: i=1; AJvYcCWZhi5cDejj71siYdXRjdFuri7XoJLOSqjSUxNXuWyPsGHje8IW3v1oXzr6t6tKAX73VtSRi2CHq19O6QTRaPF2A3SMvkTQaWgorg== X-Gm-Message-State: AOJu0Yx0Rd+7zFXuPKGsn/lvY6QTypcTrrkRv5+QLI8CxcAqYUH8oav5 lLXmI2xfIX0tVhwyo56zybLgCiB1Txq3D0XqGO5JDS6wSiknStQNCVLhELZ1MFk= X-Google-Smtp-Source: AGHT+IEcDrisOCqCMJOmaLRgZQyAaHTXXz8anuBHbakkxYTiPreghhV1D06Sq2gYrDwj1MifnJt7yg== X-Received: by 2002:a05:600c:4706:b0:413:25c6:1981 with SMTP id v6-20020a05600c470600b0041325c61981mr3480578wmo.20.1710496884073; Fri, 15 Mar 2024 03:01:24 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:8151:4d0a:14d8:1124]) by smtp.gmail.com with ESMTPSA id h17-20020a05600c315100b00413f76fe7b0sm3887726wmo.21.2024.03.15.03.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 03:01:23 -0700 (PDT) References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-7-jan.dakinevich@salutedevices.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Jerome Brunet To: Jan Dakinevich Cc: Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Mark Brown , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@salutedevices.com Subject: Re: [PATCH 06/25] ASoC: meson: g12a-toacodec: fix "Lane Select" width Date: Fri, 15 Mar 2024 11:00:35 +0100 In-reply-to: <20240314232201.2102178-7-jan.dakinevich@salutedevices.com> Message-ID: <1jzfuzhkzw.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri 15 Mar 2024 at 02:21, Jan Dakinevich wrote: > For both G12A and SM1 the width of "Lane Select" should be 2, not 3. > Otherwise, it overlaps with "Source". > > Signed-off-by: Jan Dakinevich Missing a Fixes tag. Ideally fixes should be sent first in a series - or even separately in this case > --- > sound/soc/meson/g12a-toacodec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/meson/g12a-toacodec.c b/sound/soc/meson/g12a-toacodec.c > index 531bb8707a3e..b92de2235627 100644 > --- a/sound/soc/meson/g12a-toacodec.c > +++ b/sound/soc/meson/g12a-toacodec.c > @@ -229,11 +229,11 @@ static const struct snd_soc_dapm_route g12a_toacodec_routes[] = { > }; > > static const struct snd_kcontrol_new g12a_toacodec_controls[] = { > - SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL, 3, 0), > + SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL, 2, 0), > }; > > static const struct snd_kcontrol_new sm1_toacodec_controls[] = { > - SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 3, 0), > + SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 2, 0), > }; > > static const struct snd_soc_component_driver g12a_toacodec_component_drv = { -- Jerome From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2168C54E69 for ; Fri, 15 Mar 2024 10:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X4gD0gr1eClaGXRuEhXrPOPMFb93NNcgYN1O1EBaONI=; b=0oZIPjJwKXmKDL TeZ+vG6NnP8NtDt6bnS0hJ7jQH8I82crJF5GxQ5fBzKPPnkxsaQjydBte0Xg3/wh/pDrL6gSbBIGM aFwWIVYzcQR6cg5IgYvqAt3Gxw9RIzlm1haCs8IWNIQ+0wMBjMbxS7tnSzBvHSny7bwBlYr1tOxET L5Awnl/IpVyYMoCn40BTJPKhQYmfJn1N8NMkmNfYJgpPxyCl/36xaq7qTChpDO1cwt43+1j6RsYZ8 2ko0Lh4eXOTPN9qClNKlybgC4SD4uXqzHpwlQ0XdEDHiYORkEdX+NibZcoQhTFobDps9vZbwkwRuL hvSW8zQze7SP5+xpQrqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rl4NV-0000000HOL2-3aBV; Fri, 15 Mar 2024 10:01:29 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rl4NR-0000000HOK6-3Vsp for linux-amlogic@lists.infradead.org; Fri, 15 Mar 2024 10:01:28 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-413eee86528so12606635e9.3 for ; Fri, 15 Mar 2024 03:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710496884; x=1711101684; darn=lists.infradead.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=fWhlUz33vWZPgCe1jVxjs/Yq8Zn8UQqggbMUOeu+zYA=; b=Ef+FYpJQutBflkYikNZ5m/RY/XLfD/g5z3qPMLs3VJRY8ABkj4GiWR0IkYI3/zpvvU KYdThqtTO449IT48d6YEkmj/h00tD3rEt5F6s6c4L8VOgxVVrHysR82/6mzHSQ6fOoR/ BUlFzhov+ayXKiF0AOq4oZkFYveYrHVeCQImK0JtfGA3nRP+XrdXqHjuNyjf2fYnQBVc +3WV34+cvIsNj2x1yJgeyhEgjyts1DWqfEj3y5yvmTciROe+7mjUebJ7Uvzvlr1g+ArL 2hzYiZMA6BA8vJpzp8Ho1V92gvZVkqv7o7bddgIxQLAr1n70LLij0594DHum6/WSQSyi IBBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710496884; x=1711101684; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fWhlUz33vWZPgCe1jVxjs/Yq8Zn8UQqggbMUOeu+zYA=; b=wGBfBOQSrQ1+KBlNSQgDM2YKYnPjp/U58PrE9FSvdWgIXQRY09wizACmTtFV7S0Ipy oATliZ0sR1U6+jFV+Tbbab4AG5CXOgG+DM6U75ItXxLX5nJNyHXpfbVEKOACdrozlgDT BqxvKV914KOoGFvOvoh/gcH2wkBgaF8SVs/Vqxwd36Ts+oOjxh5IQGvCpUd9QajZu6ka 0F8n7/MXe0tviP+YRMCwzB95eC3nYP1swh6P8O/KVy2UbdmIX+ewAr+MLibYg5eiSfnm yiFLlDRiAS7NjF2pDbmvNXl2kvfylbkNAHxWgdS15b0cBfaqIG9oGe3mnIyh4s1KDYSc mCBA== X-Forwarded-Encrypted: i=1; AJvYcCVNTtT4KqPTQfZI4j5BdN2SKGj6UKdEdpcDn+iN2MuccEMu+QKuHkjg2PySgoN9Q8FHtSej4Vku6L9oA4DmDb5il89Lrl9LH5idmtlkMGW3PAs= X-Gm-Message-State: AOJu0Yzj52njFJ3zmG/RSNh/q1nfRE8lUxyl1BYfAXX8ZYtVAdDzVZEW rGCiw7uXUX+cOTGuIuRd8h8PC9zDqbfnIsjf3KnLVt71v+fNPVUkYNRm8We/Tz4= X-Google-Smtp-Source: AGHT+IEcDrisOCqCMJOmaLRgZQyAaHTXXz8anuBHbakkxYTiPreghhV1D06Sq2gYrDwj1MifnJt7yg== X-Received: by 2002:a05:600c:4706:b0:413:25c6:1981 with SMTP id v6-20020a05600c470600b0041325c61981mr3480578wmo.20.1710496884073; Fri, 15 Mar 2024 03:01:24 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:8151:4d0a:14d8:1124]) by smtp.gmail.com with ESMTPSA id h17-20020a05600c315100b00413f76fe7b0sm3887726wmo.21.2024.03.15.03.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 03:01:23 -0700 (PDT) References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-7-jan.dakinevich@salutedevices.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Jerome Brunet To: Jan Dakinevich Cc: Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Mark Brown , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@salutedevices.com Subject: Re: [PATCH 06/25] ASoC: meson: g12a-toacodec: fix "Lane Select" width Date: Fri, 15 Mar 2024 11:00:35 +0100 In-reply-to: <20240314232201.2102178-7-jan.dakinevich@salutedevices.com> Message-ID: <1jzfuzhkzw.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240315_030125_906739_18B5D19F X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri 15 Mar 2024 at 02:21, Jan Dakinevich wrote: > For both G12A and SM1 the width of "Lane Select" should be 2, not 3. > Otherwise, it overlaps with "Source". > > Signed-off-by: Jan Dakinevich Missing a Fixes tag. Ideally fixes should be sent first in a series - or even separately in this case > --- > sound/soc/meson/g12a-toacodec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/meson/g12a-toacodec.c b/sound/soc/meson/g12a-toacodec.c > index 531bb8707a3e..b92de2235627 100644 > --- a/sound/soc/meson/g12a-toacodec.c > +++ b/sound/soc/meson/g12a-toacodec.c > @@ -229,11 +229,11 @@ static const struct snd_soc_dapm_route g12a_toacodec_routes[] = { > }; > > static const struct snd_kcontrol_new g12a_toacodec_controls[] = { > - SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL, 3, 0), > + SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL, 2, 0), > }; > > static const struct snd_kcontrol_new sm1_toacodec_controls[] = { > - SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 3, 0), > + SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 2, 0), > }; > > static const struct snd_soc_component_driver g12a_toacodec_component_drv = { -- Jerome _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D643EC54E58 for ; Fri, 15 Mar 2024 10:01:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w2T4dVNl7DVclCaPIRoRrGM0T8pfTPEByXra1viHt0E=; b=XarpqiwpHisrGt neT/C799CcW38ZJttxzNZfTALnSlmCRxBGpLqfj6N/4V2gLBeNP9qrG0h2Aa6EvMV/u2YogsepPJy hxkSd7NAZmn5iIfStDtp8IPwjEFclw+cwQHb/+0pOUUHAZtXe1ixW2lJqiMGyFiQRaErd3hvfI66R 2Ll0Y9MsOs+gnEXYkSzH2CBQvQDHRXvs9o03ZX+LyNrzTYRhZ3aW5tUmfwXLBboa3wW2TRqARBK4T Sew/cefO0+nnKH/0AvbcsTJsYcScm5Plra8nRcNojqFFDgtjcqKWmjaczWslnNoRG3JnhTcwFj5de EpbbiFS0X8BxvIHKNbfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rl4NW-0000000HOL8-10EH; Fri, 15 Mar 2024 10:01:30 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rl4NS-0000000HOK7-0fkY for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2024 10:01:28 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-413f1853bf3so10609065e9.0 for ; Fri, 15 Mar 2024 03:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710496884; x=1711101684; darn=lists.infradead.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=fWhlUz33vWZPgCe1jVxjs/Yq8Zn8UQqggbMUOeu+zYA=; b=Ef+FYpJQutBflkYikNZ5m/RY/XLfD/g5z3qPMLs3VJRY8ABkj4GiWR0IkYI3/zpvvU KYdThqtTO449IT48d6YEkmj/h00tD3rEt5F6s6c4L8VOgxVVrHysR82/6mzHSQ6fOoR/ BUlFzhov+ayXKiF0AOq4oZkFYveYrHVeCQImK0JtfGA3nRP+XrdXqHjuNyjf2fYnQBVc +3WV34+cvIsNj2x1yJgeyhEgjyts1DWqfEj3y5yvmTciROe+7mjUebJ7Uvzvlr1g+ArL 2hzYiZMA6BA8vJpzp8Ho1V92gvZVkqv7o7bddgIxQLAr1n70LLij0594DHum6/WSQSyi IBBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710496884; x=1711101684; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fWhlUz33vWZPgCe1jVxjs/Yq8Zn8UQqggbMUOeu+zYA=; b=LUoE/UkAAV1ySmUP0/j36CEWtfX1Q5gXZNXQ86hX4Tgrb+gcUaygmSQ+F+oKmicYJu HVR8pQohDA0LTHlEBt7foRKQDLtL2i8bFZ3FTTQ44Xc6RvjG5sS0+sw+OKLk4nYJF5hn lJDMVLeR+NQymi0F10+IFwKctBmbSQE+ArbaoStFJymnJ85lrTnKh2Dk7K6Uz8XtyIP9 UW3bbqIPFvYw05xCcA9qgn6fXhr6mPEr6yifS3ZmCIp6ue/+3BMMPA7A7XHb+zRaBEs7 uz/PaKvK8pqW4XXfmbnymaKl1yH4d5ZOfbCMvxuvNldhZ+lm0VsgafV4gPboEfO6sCV1 n3Sg== X-Forwarded-Encrypted: i=1; AJvYcCUKwmoK+NOl1m/EdiNgfJmH6vINPn/TD4aQZIHkshESP6eDTtioaqacZBwidCHu1tGIBM2TqIjymAshlBFKZb0i9BVd0WwhqH/VEJGG8vZBk5c2Je4= X-Gm-Message-State: AOJu0YyUxtnnNOfHb91riCr8vxfS4Q3TMwLk9NLeyBQhowcrNI4MtRfF pubhN15MRZ8/FRhcjswdZvzse6lfYa2YZ9QdFow+HRPtN4l7AUYeb28tSenE0Ko= X-Google-Smtp-Source: AGHT+IEcDrisOCqCMJOmaLRgZQyAaHTXXz8anuBHbakkxYTiPreghhV1D06Sq2gYrDwj1MifnJt7yg== X-Received: by 2002:a05:600c:4706:b0:413:25c6:1981 with SMTP id v6-20020a05600c470600b0041325c61981mr3480578wmo.20.1710496884073; Fri, 15 Mar 2024 03:01:24 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:8151:4d0a:14d8:1124]) by smtp.gmail.com with ESMTPSA id h17-20020a05600c315100b00413f76fe7b0sm3887726wmo.21.2024.03.15.03.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 03:01:23 -0700 (PDT) References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-7-jan.dakinevich@salutedevices.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Jerome Brunet To: Jan Dakinevich Cc: Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Mark Brown , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@salutedevices.com Subject: Re: [PATCH 06/25] ASoC: meson: g12a-toacodec: fix "Lane Select" width Date: Fri, 15 Mar 2024 11:00:35 +0100 In-reply-to: <20240314232201.2102178-7-jan.dakinevich@salutedevices.com> Message-ID: <1jzfuzhkzw.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240315_030126_209233_E13D1B2F X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 15 Mar 2024 at 02:21, Jan Dakinevich wrote: > For both G12A and SM1 the width of "Lane Select" should be 2, not 3. > Otherwise, it overlaps with "Source". > > Signed-off-by: Jan Dakinevich Missing a Fixes tag. Ideally fixes should be sent first in a series - or even separately in this case > --- > sound/soc/meson/g12a-toacodec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/meson/g12a-toacodec.c b/sound/soc/meson/g12a-toacodec.c > index 531bb8707a3e..b92de2235627 100644 > --- a/sound/soc/meson/g12a-toacodec.c > +++ b/sound/soc/meson/g12a-toacodec.c > @@ -229,11 +229,11 @@ static const struct snd_soc_dapm_route g12a_toacodec_routes[] = { > }; > > static const struct snd_kcontrol_new g12a_toacodec_controls[] = { > - SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL, 3, 0), > + SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL, 2, 0), > }; > > static const struct snd_kcontrol_new sm1_toacodec_controls[] = { > - SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 3, 0), > + SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 2, 0), > }; > > static const struct snd_soc_component_driver g12a_toacodec_component_drv = { -- Jerome _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel