From mboxrd@z Thu Jan  1 00:00:00 1970
From: mwilck@suse.com (Martin Wilck)
Date: Fri, 20 Jul 2018 16:50:06 +0200
Subject: [PATCH] nvme: register ns_id attributes as default sysfs groups
In-Reply-To: <b7314028-d878-a667-968f-fcabf30f65fd@suse.de>
References: <20180716103721.96363-1-hare@suse.de>
 <20180717131239.GA13582@lst.de>
 <b7314028-d878-a667-968f-fcabf30f65fd@suse.de>
Message-ID: <2000865cfb5da244b9e5e3e3405c3db6d133e63a.camel@suse.com>

On Tue, 2018-07-17@15:20 +0200, Hannes Reinecke wrote:
> On 07/17/2018 03:12 PM, Christoph Hellwig wrote:
> > On Mon, Jul 16, 2018@12:37:21PM +0200, Hannes Reinecke wrote:
> > > We should be registering the ns_id attributes as default sysfs
> > > groups,
> > > otherwise we have a race condition between nvme_mpath_add_disk()
> > > and
> > > nvme_mpath_remove_disk() which will lead to a kobject warning
> > > during
> > > rapid connect/disconnect cycles.
> > > 
> > > Reported-by: James Smart <james.smart at broadcom.com>
> > > Signed-off-by: Hannes Reinecke <hare at suse.com>
> > > ---
> > 
> > Didn't Martin Wilck habe a patch to pass the default attribute
> > group to an add_disk variant?  We've been waiting for him to just
> > clean it up a bit, and it would be a lot less ugly than opencoding
> > the device model details in the callers.
> > 
> 
> Since you mention it, indeed, there was something.
> I'll see to resurrect his patches.
> 
> Or poke him directly...

Right, it has been on my list for some time, didn't get down to it.
I'll see what I can do next week.

Martin

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)