From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: aio_fsync Date: Wed, 6 Nov 2002 15:23:16 +0000 Sender: owner-linux-aio@kvack.org Message-ID: <20021106152316.B23697@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org Return-path: To: Benjamin LaHaise Content-Disposition: inline List-Id: linux-fsdevel.vger.kernel.org Ben, do you have patches in hand to convert users to aio_fsync? Currently we have no users in-tree (grepping 2.5.46 for aio_fsync finds some hpux syscalls, two places you would call it if it were set and the prototype for it). It's not covered in Documentation/filesystems/Locking, nor vfs.txt. The main problem with converting seems to be nfsd. kiocb has a struct file *, but nfsd doesn't have one in nfsd_sync_dir(). We could change the signature of aio_fsync() to take an inode pointer too (nobody actually uses the dentry). But that doesn't seem worth doing. Alternatives? Add a struct inode to kiocb? Bleugh. Make nfsd use struct file in various places? Bleugh. Should we just remove the aio_fsync pointer from fops until this problem is solved? Right now it's just taking up space. -- Revolutions do not require corporate support. -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/