From: Dominik Brodowski <linux@brodo.de>
To: Dave Jones <davej@codemonkey.org.uk>,
Matt Reppert <repp0017@tc.umn.edu>,
linux-kernel@vger.kernel.org
Subject: Re: Linux v2.6.0-test1
Date: Tue, 15 Jul 2003 19:38:44 +0200 [thread overview]
Message-ID: <20030715173844.GB1950@brodo.de> (raw)
In-Reply-To: <20030715105657.GA13879@suse.de>
On Tue, Jul 15, 2003 at 11:56:57AM +0100, Dave Jones wrote:
> On Tue, Jul 15, 2003 at 12:11:32AM -0400, Matt Reppert wrote:
> > I need this to build on powerpc (plus the patch by Jasper Spaans already posted).
>
> > * cpufreq_parse_policy - parse a policy string
> > diff -NruX /home/arashi/kdontdiff linux-2.6.0-test1-orig/include/linux/notifier.h linux-2.6.0-test1/include/linux/notifier.h
> > --- linux-2.6.0-test1-orig/include/linux/notifier.h 2003-07-13 23:30:36.000000000 -0400
> > +++ linux-2.6.0-test1/include/linux/notifier.h 2003-07-14 23:41:56.000000000 -0400
> > @@ -65,6 +65,7 @@
> > #define CPU_UP_CANCELED 0x0004 /* CPU (unsigned)v NOT coming up */
> > #define CPU_OFFLINE 0x0005 /* CPU (unsigned)v offline (still scheduling) */
> > #define CPU_DEAD 0x0006 /* CPU (unsigned)v dead */
> > +#define CPUFREQ_ALL_CPUS ((NR_CPUS))
> >
> > #endif /* __KERNEL__ */
> > #endif /* _LINUX_NOTIFIER_H */
>
> include/linux/cpufreq.h seems a more natural place to put this.
> Can you confirm that works ok on PPC? I lack hardware to test.
No, please don't do this. There is no function at all in the cpufreq core
which may be called with CPUFREQ_ALL_CPUS as arguments. Well, there had
been, many months ago. But it really shall not be defined or used anywhere
outside the 2.4. proc-intf any more.
Now, wrt the ppc-cpufreq driver: benh's 2.5. tree includes a much more
updated version than plain 2.6.0-test1 -- Ben, can you push that to Linus,
please? Also, please change the line
freqs.cpu = CPUFREQ_ALL_CPUS;
in do_set_cpu_speed() to
freqs.cpu = 0;
which is the way it should be done now.
Dominik
next prev parent reply other threads:[~2003-07-15 17:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-14 3:59 Linux v2.6.0-test1 Linus Torvalds
2003-07-14 11:30 ` [trivial] " Jasper Spaans
2003-07-14 15:07 ` 2.6.0-test, how to test it? [Was: Linux v2.6.0-test1] Antonio Vargas
2003-07-14 20:08 ` Linux v2.6.0-test1 (compile stats) John Cherry
2003-07-15 4:11 ` Linux v2.6.0-test1 Matt Reppert
2003-07-15 10:56 ` Dave Jones
2003-07-15 17:38 ` Dominik Brodowski [this message]
2003-07-15 18:11 ` Dave Jones
2003-07-16 1:29 ` Hotplug Oops " Mike Fedyk
2003-07-16 1:37 ` Greg KH
2003-07-16 1:46 ` Mike Fedyk
2003-07-16 2:31 ` Greg KH
2003-07-16 20:15 ` Mike Fedyk
2003-07-16 20:26 ` Mike Fedyk
2003-07-18 2:31 ` Greg KH
2003-07-18 18:45 ` Mike Fedyk
2003-07-29 18:02 ` Mike Fedyk
2003-07-29 19:00 ` Mike Fedyk
-- strict thread matches above, loose matches on Subject: below --
2003-07-15 7:52 Dirk Meul
2003-07-16 6:32 ` Martin Schlemmer
2003-07-14 11:50 John Bradford
2003-07-14 11:53 ` Dave Jones
2003-07-14 12:00 ` William Lee Irwin III
2003-07-14 12:39 ` Alan Cox
2003-07-14 12:47 ` William Lee Irwin III
2003-07-14 12:47 ` Alan Cox
2003-07-14 12:40 ` Alan Cox
2003-07-14 16:55 ` Kurt Wall
2003-07-14 11:39 John Bradford
2003-07-14 11:33 ` Alan Cox
2003-07-14 13:56 ` Marcelo Tosatti
2003-07-14 15:07 ` Alan Cox
2003-07-14 16:44 ` Marcelo Tosatti
2003-07-14 11:01 John Bradford
2003-07-14 11:15 ` Alan Cox
2003-05-22 20:12 DMA gone on ALI 1533 Peter
2003-07-14 7:26 ` Linux v2.6.0-test1 Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030715173844.GB1950@brodo.de \
--to=linux@brodo.de \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=repp0017@tc.umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.