From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S271016AbTGPR5k (ORCPT ); Wed, 16 Jul 2003 13:57:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270974AbTGPRxo (ORCPT ); Wed, 16 Jul 2003 13:53:44 -0400 Received: from genius.impure.org.uk ([195.82.120.210]:1428 "EHLO genius.impure.org.uk") by vger.kernel.org with ESMTP id S271001AbTGPRv3 (ORCPT ); Wed, 16 Jul 2003 13:51:29 -0400 Date: Wed, 16 Jul 2003 19:05:35 +0100 From: Dave Jones To: John Levon Cc: "Pallipadi, Venkatesh" , torvalds@osdl.org, linux-kernel@vger.kernel.org, "Mallick, Asit K" Subject: Re: [PATCH] Use of Performance Monitoring Counters based on Model number Message-ID: <20030716180535.GB26192@suse.de> Mail-Followup-To: Dave Jones , John Levon , "Pallipadi, Venkatesh" , torvalds@osdl.org, linux-kernel@vger.kernel.org, "Mallick, Asit K" References: <20030716171956.GC19910@compsoc.man.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030716171956.GC19910@compsoc.man.ac.uk> User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 16, 2003 at 06:19:56PM +0100, John Levon wrote: > > Attached is a small patch to make Linux kernel use of performance > > monitoring MSRs based on known processor models. Future processor > > implementation models may not support the same MSR layout. > If you're going to do this you should fix up arch/i386/oprofile/ to > error out similarly at least It'd also be nice to let the user know why things aren't working instead of silent failure. A simple printk (KERN_INFO "Performance counter support for this CPU not yet added.\n"); Should do the trick. Dave