All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: schlicht@uni-mannheim.de, ricardo.b@zmail.pt,
	linux-kernel@vger.kernel.org
Subject: Re: SET_MODULE_OWNER
Date: Thu, 17 Jul 2003 13:19:02 -0700	[thread overview]
Message-ID: <20030717131902.76c68c56.davem@redhat.com> (raw)
In-Reply-To: <3F170589.50005@pobox.com>

On Thu, 17 Jul 2003 16:22:33 -0400
Jeff Garzik <jgarzik@pobox.com> wrote:

> This change is a major behavior change.  The whole point of removing a 
> module is knowing its gone ;-)  And that is completely changed now. 
> Modules are very often used by developers in a "modprobe ; test ; rmmod" 
> cycle, and that's now impossible (you don't know when the net device, 
> and thus your code, is really gone).  It's already breaking userland, 
> which does sweeps for zero-refcount modules among other things.
> 
> I can't believe I missed this.

Umm, Jeff, for years if you rmmod netfilter it very will
do this for you even if you have firewall rules installed.
This behavior exists in all of 2.4.x

People who do modprobe -r in their crontabs are asking
for trouble, losing their netdevice is the least of their
trouble especially if they have firewall rules installed.

Module reference counting added complications to net device
handling, and once I killed it off we could begin addressing
all of the real bugs that exist with network devices.  For example,
now that we're foreced to make net devices dynamic memory in all
cases we can deal with dangling procfs/sysfs references to the device
sanely.  Fixing that was not possible with module refcounting.


  reply	other threads:[~2003-07-17 20:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-17 12:56 SET_MODULE_OWNER Ricardo Bugalho
2003-07-17 15:32 ` SET_MODULE_OWNER Jeff Garzik
2003-07-17 15:56   ` SET_MODULE_OWNER Thomas Schlichter
2003-07-17 16:00     ` SET_MODULE_OWNER Jeff Garzik
2003-07-17 19:59       ` SET_MODULE_OWNER David S. Miller
2003-07-17 20:22         ` SET_MODULE_OWNER Jeff Garzik
2003-07-17 20:19           ` David S. Miller [this message]
2003-07-17 20:48             ` SET_MODULE_OWNER Jeff Garzik
2003-07-17 21:34               ` SET_MODULE_OWNER David S. Miller
2003-07-18  9:48             ` SET_MODULE_OWNER Roman Zippel
2003-07-18  7:31           ` SET_MODULE_OWNER Duncan Sands
2003-07-18  9:05             ` SET_MODULE_OWNER Martin Diehl
2003-07-18 10:12               ` SET_MODULE_OWNER Duncan Sands
2003-07-18 12:46                 ` SET_MODULE_OWNER Martin Diehl
2003-07-17 21:36         ` SET_MODULE_OWNER Ricardo Bugalho
2003-07-17 21:40           ` SET_MODULE_OWNER David S. Miller
2003-07-17 22:23             ` SET_MODULE_OWNER Ricardo Bugalho
2003-07-17 22:16               ` SET_MODULE_OWNER David S. Miller
2003-07-18  0:49                 ` SET_MODULE_OWNER Ricardo Bugalho
2003-07-18  2:27             ` SET_MODULE_OWNER James H. Cloos Jr.
2003-07-18  5:26               ` SET_MODULE_OWNER David S. Miller
2003-07-20  2:10                 ` SET_MODULE_OWNER James H. Cloos Jr.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030717131902.76c68c56.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricardo.b@zmail.pt \
    --cc=schlicht@uni-mannheim.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.