All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamie Wellnitz <Jamie.Wellnitz@emulex.com>
To: Arjan van de Ven <arjanv@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Andrew Vasquez <andrew.vasquez@qlogic.com>,
	Linux-Kernel <linux-kernel@vger.kernel.org>,
	Linux-SCSI <linux-scsi@vger.kernel.org>
Subject: Re: [ANNOUNCE] QLogic qla2xxx driver update available (v8.00.00b4 ).
Date: Fri, 18 Jul 2003 10:03:42 -0400	[thread overview]
Message-ID: <20030718140342.GA32615@ma.emulex.com> (raw)
In-Reply-To: <1058536002.5950.3.camel@laptop.fenrus.com>

On Fri, Jul 18, 2003 at 09:46:42AM -0400, Arjan van de Ven wrote:
> On Fri, 2003-07-18 at 13:23, Christoph Hellwig wrote:
> >  
> >  - qla2x00_intr_handler should use spin_lock, not spin_lock_irqsave
> 
> possibly correct; on x86 irq handlers run with interrupts enabled for
> example; just too dangerous to do this esp if error recovery and similar
> code calls this from process context as well (iirc a few places do)

Is this true?  Do irq handlers _always_ run with interrupts enabled?
I thought the driver could control this behavior with the SA_INTERRUPT
flag.

This code in handle_IRQ_event seems to turn interrupts back on
(apparently someone has turned them off), but only if SA_INTERRUPT is
not set.

   if (!(action->flags & SA_INTERRUPT))
                 __sti();
 
Thanks,
Jamie Wellnitz
Jamie.Wellnitz@emulex.com

  reply	other threads:[~2003-07-18 13:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-17 23:40 [ANNOUNCE] QLogic qla2xxx driver update available (v8.00.00b4) Andrew Vasquez
2003-07-18 10:48 ` Christoph Hellwig
2003-07-18 11:23 ` Christoph Hellwig
2003-07-18 12:12   ` Lars Marowsky-Bree
2003-07-18 12:13     ` Christoph Hellwig
2003-07-18 12:26       ` Lars Marowsky-Bree
2003-07-18 12:26         ` Lars Marowsky-Bree
2003-07-18 12:34         ` Christoph Hellwig
2003-07-18 12:41           ` Lars Marowsky-Bree
2003-07-18 12:41             ` Lars Marowsky-Bree
2003-07-18 12:46             ` Christoph Hellwig
2003-07-18 13:46   ` Arjan van de Ven
2003-07-18 14:03     ` Jamie Wellnitz [this message]
2003-07-18 19:12     ` Christoph Hellwig
2003-07-18 19:12       ` Christoph Hellwig
2003-07-18 19:10   ` Christoph Hellwig
2003-07-18 21:15 Andrew Vasquez
2003-07-18 21:46 Andrew Vasquez
2003-07-18 21:53 Andrew Vasquez
2003-07-19  1:05 Manfred Spraul
2005-01-14 20:24 Eric Pesciotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030718140342.GA32615@ma.emulex.com \
    --to=jamie.wellnitz@emulex.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=arjanv@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.