* [U-Boot-Users] [PATCH] fixed reset command on mpc8xx
@ 2003-07-19 2:27 Andreas Oberritter
2003-07-19 19:12 ` Wolfgang Denk
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Oberritter @ 2003-07-19 2:27 UTC (permalink / raw)
To: u-boot
This patch does reset on 8xx like the linux kernel does it. Works
without crashing u-boot unlike the previous version. Tested on mpc823.
Changelog:
Patch by Andreas Oberritter, 19 July 03
- fixed reset command on mpc8xx
-------------- next part --------------
A non-text attachment was scrubbed...
Name: u-boot-0.4.0-reset.diff
Type: text/x-patch
Size: 675 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20030719/25a178d1/attachment.bin
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot-Users] [PATCH] fixed reset command on mpc8xx
2003-07-19 2:27 [U-Boot-Users] [PATCH] fixed reset command on mpc8xx Andreas Oberritter
@ 2003-07-19 19:12 ` Wolfgang Denk
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2003-07-19 19:12 UTC (permalink / raw)
To: u-boot
Dear Andreas,
in message <1058581655.1560.31.camel@localhost> you wrote:
>
> This patch does reset on 8xx like the linux kernel does it. Works
> without crashing u-boot unlike the previous version. Tested on mpc823.
There is no problem with U-Boots implementation of the "reset"
command when you configure your board correctly. Therefore I see no
need to "fix" anything. I reject this patch.
> + dummy = immap->im_clkrst.res[0];
> +
I know that the Linux kernel uses this implementation, but it is IMHO
a very bad idea to rely on the behaviour when writing to a reserved
area in the dual ported RAM. The next version of 8xx processors might
use this area for something.
If you feel the current implementation needs improvment, please feel
free to implement what we use for the 8260 in our Linux kernel source
tree:
- Get base address mapped by BR0/OR0
- Enable CheckStop Reset
- Invalidate BR0 mapping
- Set MSR and cause reset by attemting to access the base address
formerly mapped by BR0/OR0
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd at denx.de
"There is nothing new under the sun, but there are lots of old things
we don't know yet." - Ambrose Bierce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-07-19 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-19 2:27 [U-Boot-Users] [PATCH] fixed reset command on mpc8xx Andreas Oberritter
2003-07-19 19:12 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.