From: Pavel Machek <pavel@ucw.cz>
To: linux-kernel@vger.kernel.org, torvalds@osdl.com
Subject: Re: [PATCH] Compile fix for suspend.c
Date: Sun, 20 Jul 2003 21:17:33 +0200 [thread overview]
Message-ID: <20030720191733.GA292@elf.ucw.cz> (raw)
In-Reply-To: <20030720092314.GA11395@himi.org>
Hi!
> kernel/suspend.c fails to build as of a bk pull at about 08:00 UTC,
> with redefinitions of _text.
You were right; I can see the error, too. And your fix is right, since
current suspend.c no longer uses these sections. (It still uses
__nosave_begin/_end, through).
Pavel
> ===== kernel/suspend.c 1.42 vs edited =====
> --- 1.42/kernel/suspend.c Sat May 3 04:16:11 2003
> +++ edited/kernel/suspend.c Sun Jul 20 19:14:48 2003
> @@ -83,7 +83,6 @@
> #define ADDRESS2(x) __ADDRESS(__pa(x)) /* Needed for x86-64 where some pages are in m
> emory twice */
>
> /* References to section boundaries */
> -extern char _text, _etext, _edata, __bss_start, _end;
> extern char __nosave_begin, __nosave_end;
>
> extern int is_head_of_free_region(struct page *);
>
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
prev parent reply other threads:[~2003-07-20 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-20 9:23 [PATCH] Compile fix for suspend.c Simon Fowler
2003-07-20 11:33 ` Pavel Machek
2003-07-20 13:20 ` Simon Fowler
2003-07-20 19:17 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030720191733.GA292@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.