All of lore.kernel.org
 help / color / mirror / Atom feed
From: Georg Nikodym <georgn@somanetworks.com>
To: linux-kernel@vger.kernel.org
Cc: torvalds@osdl.org
Subject: [PATCH] compilation failure in kernel/suspend.c
Date: Mon, 21 Jul 2003 11:24:05 -0400	[thread overview]
Message-ID: <20030721112405.6be4f4e3.georgn@somanetworks.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

Apologies if you've heard this one before.

>From the latest 2.5 (2.6.0-test1) bk, I get:

  CC      kernel/suspend.o
kernel/suspend.c:293: warning: #warning This might be broken. We need to somehow wait for data to reach the disk
kernel/suspend.c:86: conflicting types for `_text'
include/asm-generic/sections.h:6: previous declaration of `_text'
kernel/suspend.c:86: conflicting types for `_etext'
include/asm-generic/sections.h:6: previous declaration of `_etext'
kernel/suspend.c:86: conflicting types for `_edata'
include/asm-generic/sections.h:7: previous declaration of `_edata'
kernel/suspend.c:86: conflicting types for `__bss_start'
include/asm-generic/sections.h:8: previous declaration of `__bss_start'
make[1]: *** [kernel/suspend.o] Error 1
make: *** [kernel] Error 2

sections.h defines things like "extern char _text[]" whereas suspend.c
defines "extern char _text"

Since the _text, _etext, etc symbols are not even used in suspend.c,
removing them seems the correct thing to do.

--- 1.42/kernel/suspend.c	Fri May  2 14:16:11 2003
+++ edited/suspend.c	Mon Jul 21 11:20:14 2003
@@ -83,7 +83,6 @@
 #define ADDRESS2(x) __ADDRESS(__pa(x))		/* Needed for x86-64 where some pages are in memory twice */
 
 /* References to section boundaries */
-extern char _text, _etext, _edata, __bss_start, _end;
 extern char __nosave_begin, __nosave_end;
 
 extern int is_head_of_free_region(struct page *);

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

                 reply	other threads:[~2003-07-21 15:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030721112405.6be4f4e3.georgn@somanetworks.com \
    --to=georgn@somanetworks.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.