All of
 help / color / mirror / Atom feed
From: Georg Nikodym <>
Cc: Andrew Morton <>,,,
	Tom Sightler <>
Subject: Re: [BUG REPORT 2.6.0] cisco airo_cs scheduling while atomic
Date: Mon, 21 Jul 2003 13:15:47 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1058619536.752.19.camel@localhost>

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On 19 Jul 2003 22:58:57 +1000
Sven Dowideit <> wrote:

> @@ -4838,7 +4850,7 @@
>         readCapabilityRid(local, &cap_rid);
>         dwrq->length = sizeof(struct iw_range);
> -       memset(range, 0, sizeof(*range));
> +       memset(range, 0, sizeof(range));
>         range->min_nwid = 0x0000;
>         range->max_nwid = 0x0000;
>         range->num_channels = 14;

I suspect that this part of the patch to airo.c is incorrect.  The
intent seems to be to clear a section of memory pointed to by range that
contains (or will soon contain) a struct iw_range.  The sizeof(*range)
is equivalent of the sizeof(struct iw_range) above.  The patch reduces
the size of the memset to the size of the pointer (which I'm assuming is
smaller than the structure [/me goes and looks]).

Of course, the range pointer is derived from the char *extra
parameter...  this could mean that we're actually getting a pre-filled
iw_range and the memset is only supposed to clear the first member.  If
that's the case, I would hope that the author could come up with a
cleaner way of expressing that.


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2003-07-21 17:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-19 12:58 [BUG REPORT 2.6.0] cisco airo_cs scheduling while atomic Sven Dowideit
2003-07-21 17:15 ` Georg Nikodym [this message]
2003-07-21 19:52   ` Tom Sightler
  -- strict thread matches above, loose matches on Subject: below --
2003-07-19 12:17 Daniel Ritz
2003-07-18 13:03 James Bourne
2003-07-18 21:04 ` Andrew Morton
2003-07-19  2:46   ` James Bourne
2003-07-19  3:00     ` Andrew Morton
2003-07-19  4:36       ` Tom Sightler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.