From: Matthew Wilcox <willy@debian.org>
To: Alan Cox <alan@redhat.com>
Cc: Matthew Wilcox <willy@debian.org>,
Tomita Haruo <haruo.tomita@toshiba.co.jp>,
atulm@lsil.com, Matt Domsch <Matt_Domsch@dell.com>,
linux-megaraid-devel@dell.com, linux-scsi@vger.kernel.org,
Tomita Haruo <htomita@pcs.pc.ome.toshiba.co.jp>
Subject: Re: I have modified the megaraid driver v2.00.5 from kernel 2.6 t o 2 .4.22-prex-ac1
Date: Thu, 24 Jul 2003 14:47:54 +0100 [thread overview]
Message-ID: <20030724134754.GG1485@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200307241309.h6OD9dg06659@devserv.devel.redhat.com>
On Thu, Jul 24, 2003 at 09:09:39AM -0400, Alan Cox wrote:
> > No, not at all. I'm criticising the original code here, not your patch.
> > In my opinion, we should simply delete these lines:
>
> That would be a bad idea. Some of the devices share the same non subsys id
> with non megaraid cards (INTEL I960) and the result is that megaraid cards
> fall out with some other stuff.
Then the comment needs to be fixed -- we shouldn't be rejecting cards
for non-PCI-200X compliance; we should be rejecting them because another
driver wants them. Yuck.
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
next prev parent reply other threads:[~2003-07-24 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-24 5:05 I have modified the megaraid driver v2.00.5 from kernel 2.6 t o 2 .4.22-prex-ac1 Tomita, Haruo
2003-07-24 11:41 ` Matthew Wilcox
2003-07-24 13:09 ` Alan Cox
2003-07-24 13:47 ` Matthew Wilcox [this message]
2003-07-25 4:39 Tomita, Haruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030724134754.GG1485@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=Matt_Domsch@dell.com \
--cc=alan@redhat.com \
--cc=atulm@lsil.com \
--cc=haruo.tomita@toshiba.co.jp \
--cc=htomita@pcs.pc.ome.toshiba.co.jp \
--cc=linux-megaraid-devel@dell.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.