All of lore.kernel.org
 help / color / mirror / Atom feed
From: shivaken <shivaken@antshell.org>
To: alsa-devel@lists.sourceforge.net
Subject: Patch: for Maestro3 on SMP
Date: Fri, 25 Jul 2003 02:35:43 +0900	[thread overview]
Message-ID: <200307250236.05453.shivaken@antshell.org> (raw)
In-Reply-To: <E19fjn6-0006Fx-00@sc8-sf-list2.sourceforge.net>

Hi,

Maestro3 driver of linux-2.6.0-test1 (and may be before) has a problem with 
SMP. 
# cannot record properly and sometimes interrupted to play.

Here is a patch.
It worked fine. But I'm new for alsa.
So please test and check alsa-driver's maestro3.c

--- linux-2.6.0-test1/sound/pci/maestro3.c.orig	2003-07-14 12:34:50 +0900
+++ linux-2.6.0-test1/sound/pci/maestro3.c	2003-07-25 02:13:47 +0900
@@ -1526,9 +1526,15 @@
 snd_m3_pcm_pointer(snd_pcm_substream_t * subs)
 {
 	m3_t *chip = snd_pcm_substream_chip(subs);
+        size_t ptr;
+  
+        spin_lock(&chip->reg_lock);
 	m3_dma_t *s = (m3_dma_t*)subs->runtime->private_data;
 	snd_assert(s != NULL, return 0);
-	return bytes_to_frames(subs->runtime, snd_m3_get_pointer(chip, s, subs));
+        ptr = bytes_to_frames(subs->runtime, snd_m3_get_pointer(chip, s, 
subs));
+        spin_unlock(&chip->reg_lock);
+
+	return ptr;
 }

-- 
-- shivaken
antshell: Ant command line front end
http://www.antshell.org


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01

       reply	other threads:[~2003-07-24 17:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E19fjn6-0006Fx-00@sc8-sf-list2.sourceforge.net>
2003-07-24 17:35 ` shivaken [this message]
2003-07-24 19:06   ` Patch: for Maestro3 on SMP Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200307250236.05453.shivaken@antshell.org \
    --to=shivaken@antshell.org \
    --cc=alsa-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.