From: Pavel Machek <pavel@suse.cz>
To: David Woodhouse <dwmw2@infradead.org>, Patrick Mochel <mochel@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [pm] Re: JFFS2 swsusp / signal cleanup.
Date: Thu, 9 Oct 2003 02:23:18 +0200 [thread overview]
Message-ID: <20031009002318.GB219@elf.ucw.cz> (raw)
In-Reply-To: <1065384453.3157.149.camel@imladris.demon.co.uk>
Hi!
> > Should I do recalc_sigpending() instead of flush_signals(current)?
>
> Yes. You can do that unconditionally, too -- no need to do it depending
> on an argument from the caller.
Yes, and it actually works that way. Good.
[Patrick, this patch is probably good idea, flush_signals has
potential to loose some signal].
[flag argument can be killed, but I guess its bad idea to do it now].
Pavel
--- tmp/linux/kernel/power/process.c 2003-08-27 12:00:53.000000000 +0200
+++ linux/kernel/power/process.c 2003-10-05 21:15:21.000000000 +0200
@@ -49,10 +49,7 @@
pr_debug("%s entered refrigerator\n", current->comm);
printk("=");
current->flags &= ~PF_FREEZE;
- if (flag)
- flush_signals(current); /* We have signaled a kernel thread, which isn't normal behaviour
- and that may lead to 100%CPU sucking because those threads
- just don't manage signals. */
+ recalc_sigpending(); /* We sent fake signal, clean it up */
current->flags |= PF_FROZEN;
while (current->flags & PF_FROZEN)
schedule();
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-10-09 0:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-04 11:25 JFFS2 swsusp / signal cleanup David Woodhouse
2003-10-05 16:11 ` Pavel Machek
2003-10-05 16:19 ` Russell King
2003-10-05 19:13 ` Pavel Machek
2003-10-05 20:07 ` David Woodhouse
2003-10-09 0:23 ` Pavel Machek [this message]
2003-10-09 0:29 ` [pm] " David Woodhouse
2003-10-09 9:24 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031009002318.GB219@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.