From: Andi Kleen <ak@colin2.muc.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andi Kleen <ak@muc.de>,
akpm@osdl.org, linux-kernel@vger.kernel.org, bos@serpentine.com
Subject: Re: [PATCH] Fix mlockall for PROT_NONE mappings
Date: 9 Oct 2003 17:12:12 +0200
Date: Thu, 9 Oct 2003 17:12:12 +0200 [thread overview]
Message-ID: <20031009151212.GA54555@colin2.muc.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0310090754280.1694-100000@home.osdl.org>
On Thu, Oct 09, 2003 at 07:56:07AM -0700, Linus Torvalds wrote:
>
> On 9 Oct 2003, Andi Kleen wrote:
> >
> > That is exactly what the patch is doing.
>
> No it's not.
>
> What I'm asking for is a simple
>
> if (vma->vm_flags & VM_READ)
> make_pages_readable();
>
> kind of thing. A couple of one-liners in the _callers_, not a horribly
> ugly change way down the stack.
Ok. But what is with mappings that have MAY_READ not set ?
[not 100% this cannot happen]
Without the changes make_pages_present didn't call get_user_pages
with the "force" argument. And changing it unconditionally would
change the behaviour for everybody.
Also there is still the problem that it will fail early for SIGBUS
that happens for other reasons (e.g. a hardware driver not being
able to mmap everything)
-Andi
next prev parent reply other threads:[~2003-10-09 15:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-09 10:42 [PATCH] Fix mlockall for PROT_NONE mappings Andi Kleen
2003-10-09 10:49 ` Muli Ben-Yehuda
2003-10-09 11:22 ` Andi Kleen
2003-10-09 11:24 ` Muli Ben-Yehuda
2003-10-09 11:31 ` Andi Kleen
2003-10-09 14:44 ` Linus Torvalds
2003-10-09 14:52 ` Andi Kleen
2003-10-09 14:56 ` Linus Torvalds
2003-10-09 15:12 ` Andi Kleen [this message]
2003-10-09 15:17 ` Linus Torvalds
2003-10-09 15:33 ` Andi Kleen
2003-10-09 15:40 ` Linus Torvalds
2003-10-09 16:34 ` Andi Kleen
2003-10-09 17:28 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031009151212.GA54555@colin2.muc.de \
--to=ak@colin2.muc.de \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=bos@serpentine.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.