All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <willy@w.ods.org>
To: Eyal Lebedinsky <eyal@eyal.emu.id.au>
Cc: "list, linux-kernel" <linux-kernel@vger.kernel.org>,
	"Tosatti, Marcelo" <marcelo@conectiva.com.br>
Subject: Re: 2.4.23-pre7 build problems
Date: Fri, 10 Oct 2003 14:48:50 +0200	[thread overview]
Message-ID: <20031010124850.GA7202@alpha.home.local> (raw)
In-Reply-To: <3F869BD4.ADB4D648@eyal.emu.id.au>

Hi !

> megaraid2.c: In function `mega_find_card':
> megaraid2.c:403: structure has no member named `lock'
> make[2]: *** [megaraid2.o] Error 1
> make[2]: Leaving directory
> `/data2/usr/local/src/linux-2.4-pre/drivers/scsi'

wouldn't this patch fix it ? : megaraid-2009-wo-hostlock.patch


diff -Naur megaraid-2009/megaraid2.c megaraid-2009-wo-hostlock/megaraid2.c
--- megaraid-2009/megaraid2.c	2003-09-09 15:31:43.000000000 -0400
+++ megaraid-2009-wo-hostlock/megaraid2.c	2003-09-09 15:32:03.000000000 -0400
@@ -398,9 +398,7 @@
 		// replace adapter->lock with io_request_lock for kernels w/o
 		// per host lock and delete the line which tries to initialize
 		// the lock in host structure.
-		adapter->host_lock = &adapter->lock;
-
-		host->lock = adapter->host_lock;
+		adapter->host_lock = &io_request_lock;
 
 		host->cmd_per_lun = max_cmd_per_lun;
 		host->max_sectors = max_sectors_per_io;

> In file included from nsp32.c:56:
> nsp32.h:645: redefinition of `irqreturn_t'
> /data2/usr/local/src/linux-2.4-pre/include/linux/interrupt.h:16:
> `irqreturn_t' previously declared here
> make[2]: *** [nsp32.o] Error 1
> make[2]: Leaving directory
> `/data2/usr/local/src/linux-2.4-pre/drivers/scsi'

looking though pre6-pre7 changes, it seems as other drivers backported from 2.5
might be affected too :
  - qla1280 (typedef)
  - net2280 (#define)

The clear should be to simply remove the local definition from the driver.
Willy


  reply	other threads:[~2003-10-10 12:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-10 11:45 2.4.23-pre7 build problems Eyal Lebedinsky
2003-10-10 12:48 ` Willy Tarreau [this message]
2003-10-11 14:47 ` Marcelo Tosatti
2003-10-11 15:13   ` Matt Domsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031010124850.GA7202@alpha.home.local \
    --to=willy@w.ods.org \
    --cc=eyal@eyal.emu.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.