All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Eyal Lebedinsky <eyal@eyal.emu.id.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test7: saa7134 breaks on gcc 2.95
Date: Tue, 14 Oct 2003 17:59:38 -0700	[thread overview]
Message-ID: <20031014175938.04d94087.akpm@osdl.org> (raw)
In-Reply-To: <3F8C9705.26CA0B63@eyal.emu.id.au>

Eyal Lebedinsky <eyal@eyal.emu.id.au> wrote:
>
> This compiler does not like dangling comma in funcs, so this patch
>  is needed. For:
> 
>  #define dprintk(fmt, arg...)    if (core_debug) \
>  	printk(KERN_DEBUG "%s/core: " fmt, dev->name, ## arg)
> 
>  Lines like this:
> 
>  	dprintk("hwinit1\n");
> 
>  should be hacked like this:
> 
>  	dprintk("hwinit1\n", "");

I couldn't find a sane way.  Ended up doing this:

diff -puN drivers/media/video/saa7134/saa7134-core.c~saa7134-build-fix drivers/media/video/saa7134/saa7134-core.c
--- 25/drivers/media/video/saa7134/saa7134-core.c~saa7134-build-fix	2003-10-13 22:43:15.000000000 -0700
+++ 25-akpm/drivers/media/video/saa7134/saa7134-core.c	2003-10-13 22:43:15.000000000 -0700
@@ -94,8 +94,13 @@ MODULE_PARM_DESC(latency,"pci latency ti
 struct list_head  saa7134_devlist;
 unsigned int      saa7134_devcount;
 
-#define dprintk(fmt, arg...)	if (core_debug) \
-	printk(KERN_DEBUG "%s/core: " fmt, dev->name, ## arg)
+#define dprintk(fmt, arg...)						\
+	do {								\
+		if (core_debug) {					\
+			printk(KERN_DEBUG "%s/core: ", dev->name);	\
+			printk(fmt, ## arg);				\
+		}							\
+	} while (0)
 
 /* ------------------------------------------------------------------ */
 /* debug help functions                                               */

_


  reply	other threads:[~2003-10-15  0:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-15  0:38 2.6.0-test7: saa7134 breaks on gcc 2.95 Eyal Lebedinsky
2003-10-15  0:59 ` Andrew Morton [this message]
2003-10-15  5:16   ` Ingo Oeser
2003-10-15  5:34     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031014175938.04d94087.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=eyal@eyal.emu.id.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.