From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45184)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bDuS9-0005KX-67
	for qemu-devel@nongnu.org; Fri, 17 Jun 2016 10:08:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bDuS7-0006m0-7o
	for qemu-devel@nongnu.org; Fri, 17 Jun 2016 10:08:56 -0400
References: <1466169069-29375-1-git-send-email-real@ispras.ru>
	<1466169069-29375-13-git-send-email-real@ispras.ru>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <20035902-32a1-f036-a617-9d407a7ff8cc@redhat.com>
Date: Fri, 17 Jun 2016 16:08:41 +0200
MIME-Version: 1.0
In-Reply-To: <1466169069-29375-13-git-send-email-real@ispras.ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 12/13] MC146818 RTC: add GPIO access to
 output IRQ
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Efimov Vasily <real@ispras.ru>, qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Kirill Batuzov <batuzovk@ispras.ru>



On 17/06/2016 15:11, Efimov Vasily wrote:
>      qdev_init_nofail(dev);
>      if (intercept_irq) {
> -        s->irq = intercept_irq;
> +        qdev_connect_gpio_out(dev, 0, intercept_irq);
>      } else {
>          isa_init_irq(isadev, &s->irq, RTC_ISA_IRQ);
>      }

Please introduce a wrapper isa_connect_gpio_out so that you can do

    if (intercept_irq) {
        qdev_connect_gpio_out(dev, 0, intercept_irq);
    } else {
        isa_connect_gpio_out(isadev, 0, RTC_ISA_IRQ);
    }

Thanks,

Paolo