From: Jeff Garzik <jgarzik@pobox.com>
To: Mickael Marchand <marchand@kde.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
"B. Gajdos" <brian@chem.sk>
Subject: Re: [PATCH] Update : Silicon Image 3114, 4 ports support
Date: Sun, 4 Jan 2004 14:20:48 -0500 [thread overview]
Message-ID: <20040104192048.GA17638@gtf.org> (raw)
In-Reply-To: <200401041413.20573.marchand@kde.org>
On Sun, Jan 04, 2004 at 02:12:56PM +0100, Mickael Marchand wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> Thanks to the info Brian provided, I was able to set up the 4 ports of the
> sil3114.
> Attached is the patch for sata_sil.c, tested on a 2.6.1-rc1-mm1 and tested by
> Brian too.
>
> I used
> if (ent->driver_data == sil_3114) { ... }
>
> to ensure the 4 ports are probed only for sil3114 , I am not sure this is the
> correct way to do it (so that sil3112 support is not broken). I guess Jeff
> will review that :)
Yeah, your patch looks good. I assume you tested ports 3 and 4?
Jeff
next prev parent reply other threads:[~2004-01-04 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-04 13:12 [PATCH] Update : Silicon Image 3114, 4 ports support Mickael Marchand
2004-01-04 19:20 ` Jeff Garzik [this message]
2004-01-04 19:24 ` Mickael Marchand
2004-01-06 9:32 ` [PATCH] libata update Jeff Garzik
2004-01-06 16:33 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040104192048.GA17638@gtf.org \
--to=jgarzik@pobox.com \
--cc=brian@chem.sk \
--cc=linux-kernel@vger.kernel.org \
--cc=marchand@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.