Re: PATCH: (as141) Unaligned scatter-gather buffers and usb-storage

From: Jens Axboe <axboe@suse.de>
To: "Alan Stern" <stern@rowland.harvard.edu>,
	"Kai Mäkisara" <kai.makisara@kolumbus.fi>,
	"Douglas Gilbert" <dougg@torque.net>,
	"James Bottomley" <James.Bottomley@steeleye.com>,
	"Patrick Mansfield" <patmans@us.ibm.com>,
	"Oliver Neukum" <oliver@neukum.org>,
	"SCSI development list" <linux-scsi@vger.kernel.org>,
	"USB development list" <linux-usb-devel@lists.sourceforge.net>
Subject: Re: PATCH: (as141) Unaligned scatter-gather buffers and usb-storage
Date: Mon, 5 Jan 2004 11:08:24 +0100	[thread overview]
Message-ID: <20040105100824.GC3079@suse.de> (raw)
In-Reply-To: <20040105004158.GA30408@one-eyed-alien.net>

On Sun, Jan 04 2004, Matthew Dharm wrote:
> Is there any indication that the SCSI parts of this patch will get
> accepted?

I'm fine with the patch, FWIW, just move it to scsi_alloc_queue()
instead?

> > ===== scsi_scan.c 1.52 vs edited =====
> > --- 1.52/drivers/scsi/scsi_scan.c	Fri Oct 24 14:53:37 2003
> > +++ edited/drivers/scsi/scsi_scan.c	Fri Nov 21 12:34:00 2003
> > @@ -231,6 +231,15 @@
> >  	sdev->request_queue->queuedata = sdev;
> >  	scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun);
> >  
> > +	/*
> > +	 * Set the queue's mask to require a mere 8-byte alignment for
> > +	 * DMA buffers, rather than the default 512.  This shouldn't
> > +	 * inconvenience any user programs and should be okay for most
> > +	 * host adapters.  A host driver can alter this mask in its
> > +	 * slave_alloc() or slave_configure() callback if necessary.
> > +	 */
> > +	blk_queue_dma_alignment(sdev->request_queue, (8 - 1));
> > +
> >  	if (shost->hostt->slave_alloc) {
> >  		if (shost->hostt->slave_alloc(sdev))
> >  			goto out_free_queue;

-- 
Jens Axboe

-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel