All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: sparclinux@vger.kernel.org
Subject: Re: [SPARC32] Fix BUG-on-swapout
Date: Tue, 06 Jan 2004 04:55:44 +0000	[thread overview]
Message-ID: <20040106045544.GA26852@devserv.devel.redhat.com> (raw)
In-Reply-To: <20040106040805.GA13026@foobazco.org>

On Mon, Jan 05, 2004 at 08:08:05PM -0800, Keith M Wesolowski wrote:
> 
> This fixes BUG-on-swapout for srmmu-based systems.  The problem is
> caused by kmap_atomic_to_page being fed an aliased (pagetable) address
> and returning bogons.  This also adjusts the pkmap and fixmap base
> addresses so they cannot overlap.

Go, Keith!

> --- 2.5-sparc/arch/sparc/mm/fault.c	Sat Jan  3 02:08:08 2004
> +++ 2.5-sparc-smp/arch/sparc/mm/fault.c	Sat Jan  3 02:11:02 2004
> @@ -36,7 +36,7 @@
>  
>  #define ELEMENTS(arr) (sizeof (arr)/sizeof (arr[0]))
>  
> -extern struct sparc_phys_banks sp_banks[SPARC_PHYS_BANKS];
> +extern struct sparc_phys_banks sp_banks[SPARC_PHYS_BANKS+1];
>  extern int prom_node_root;
>  
>  /* At boot time we determine these two values necessary for setting

> --- 2.5-sparc/include/asm-sparc/page.h	Sat Jan  3 02:08:30 2004
> +++ 2.5-sparc-smp/include/asm-sparc/page.h	Sat Jan  3 02:11:28 2004
> @@ -54,7 +54,7 @@
>  
>  #define SPARC_PHYS_BANKS 32
>  
> -extern struct sparc_phys_banks sp_banks[SPARC_PHYS_BANKS];
> +extern struct sparc_phys_banks sp_banks[SPARC_PHYS_BANKS+1];
>  
>  /* Cache alias structure.  Entry is valid if context != -1. */
>  struct cache_palias {

Seems that the first one can be just removed altogether,
since you're on it.

> --- 2.5-sparc/include/asm-sparc/kmap_types.h	Sat Jan  3 02:08:30 2004
> +++ 2.5-sparc-smp/include/asm-sparc/kmap_types.h	Sat Jan  3 02:11:28 2004
> @@ -11,6 +11,7 @@
>  	KM_BIO_DST_IRQ,
>  	KM_PTE0,
>  	KM_PTE1,
> +	KM_PTE2,
>  	KM_IRQ0,
>  	KM_IRQ1,
>  	KM_SOFTIRQ0,

Is this needed for anything?

-- Pete

  parent reply	other threads:[~2004-01-06  4:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-06  4:08 [SPARC32] Fix BUG-on-swapout Keith M Wesolowski
2004-01-06  4:14 ` David S. Miller
2004-01-06  4:55 ` Pete Zaitcev [this message]
2004-01-06  5:24 ` Keith M Wesolowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040106045544.GA26852@devserv.devel.redhat.com \
    --to=zaitcev@redhat.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.