From: Christophe Saout <christophe@saout.de>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Possibly wrong BIO usage in ide_multwrite
Date: Tue, 6 Jan 2004 12:33:30 +0100 [thread overview]
Message-ID: <20040106113330.GA5827@leto.cs.pocnet.net> (raw)
In-Reply-To: <200401060059.52833.bzolnier@elka.pw.edu.pl>
On Tue, Jan 06, 2004 at 12:59:52AM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Monday 05 of January 2004 23:51, Christophe Saout wrote:
> > Remember? Can bio be NULL somewhere? Or what do you mean? It's our
> > scratchpad and ide_multwrite never puts a NULL bio on it.
>
> After last sector of the whole transfer is processed ide_multwrite() will set
> it to NULL.
No, it doesn't.
> /* end early early we ran out of requests */
> if (!bio) {
> mcount = 0;
> } else {
> rq->bio = bio;
> rq->nr_cbio_segments = bio_segments(bio);
> rq->current_nr_sectors = bio_cur_sectors(bio);
> rq->hard_cur_sectors = rq->current_nr_sectors;
> }
rq->bio is only set if bio is not NULL.
> Next IRQ is only ACK of previous datablock, no transfer happens.
You're right, the bi_idx resetting might be redundant but since bio is
never NULL an additional check is superfluous.
> Move it before the comment.
Ok. I will repost when the issue above is worked out.
next prev parent reply other threads:[~2004-01-06 11:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-01 17:18 Possibly wrong BIO usage in ide_multwrite Christophe Saout
2004-01-01 11:27 ` Bartlomiej Zolnierkiewicz
2004-01-02 3:20 ` Christophe Saout
2004-01-02 4:43 ` CPRM ?? " Andre Hedrick
2004-01-02 11:30 ` Jens Axboe
2004-01-03 7:53 ` Andre Hedrick
2004-01-03 10:57 ` Jens Axboe
2004-01-03 19:55 ` Andre Hedrick
2004-01-04 10:42 ` Jens Axboe
2004-01-04 22:02 ` Andre Hedrick
2004-01-05 10:17 ` Jens Axboe
2004-01-02 12:45 ` Christophe Saout
2004-01-03 7:51 ` Andre Hedrick
2004-01-03 22:02 ` Bartlomiej Zolnierkiewicz
2004-01-04 17:30 ` Christophe Saout
2004-01-05 16:12 ` Bartlomiej Zolnierkiewicz
2004-01-05 16:48 ` Christophe Saout
2004-01-05 19:37 ` Frederik Deweerdt
2004-01-05 20:13 ` Bartlomiej Zolnierkiewicz
2004-01-05 3:52 ` Christophe Saout
2004-01-05 17:08 ` Bartlomiej Zolnierkiewicz
2004-01-05 22:51 ` Christophe Saout
2004-01-05 23:59 ` Bartlomiej Zolnierkiewicz
2004-01-06 11:33 ` Christophe Saout [this message]
2004-01-06 14:38 ` Bartlomiej Zolnierkiewicz
2004-01-06 15:21 ` Christophe Saout
2004-01-05 4:03 ` Christophe Saout
2004-01-05 16:47 ` Bartlomiej Zolnierkiewicz
2004-01-05 16:49 ` Jens Axboe
2004-01-05 17:13 ` Bartlomiej Zolnierkiewicz
2004-01-05 18:16 ` Jens Axboe
2004-01-05 18:27 ` Bartlomiej Zolnierkiewicz
2004-01-01 23:02 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040106113330.GA5827@leto.cs.pocnet.net \
--to=christophe@saout.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.