From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266170AbUAGKGF (ORCPT ); Wed, 7 Jan 2004 05:06:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266178AbUAGKGF (ORCPT ); Wed, 7 Jan 2004 05:06:05 -0500 Received: from linuxhacker.ru ([217.76.32.60]:37514 "EHLO shrek.linuxhacker.ru") by vger.kernel.org with ESMTP id S266170AbUAGKF5 (ORCPT ); Wed, 7 Jan 2004 05:05:57 -0500 Date: Wed, 7 Jan 2004 12:01:13 +0200 From: Oleg Drokin To: Hans Reiser Cc: linux-kernel@vger.kernel.org, mfedyk@matchmail.com, Jesper Juhl Subject: Re: Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) related to sector_t being unsigned, advice requested Message-ID: <20040107100113.GE415627@linuxhacker.ru> References: <3FFA7717.7080808@namesys.com> <20040106174650.GD1882@matchmail.com> <200401062135.i06LZAOY005429@car.linuxhacker.ru> <3FFB46B0.9060101@namesys.com> <20040106235335.GC415627@linuxhacker.ru> <3FFBD0B1.50909@namesys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FFBD0B1.50909@namesys.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hello! On Wed, Jan 07, 2004 at 12:26:09PM +0300, Hans Reiser wrote: > >As for why gcc is finding this, but scripts (e.g. smatch) do not is because > >scripts generally know nothing about variable types, so they cannot tell > >this comparison was always false (and since gcc can do this for long time > >already, there is no point in implementing it in scripts anyway). > can we get gcc to issue us a warning? there might be other stuff > lurking around also.... If you add -W switch to CFLAGS, you'd get A LOT of more warnings. Also just reading manpage on gcc around description of that flag will give you a list of options to individually turn on certain check types. Also gcc 3.3 have this sort of " unsigned < 0 | unsigned > 0" checks on by default, I think. Bye, Oleg