All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart De Schuymer <bdschuym@pandora.be>
To: Luke Gorrie <luke@member.fsf.org>
Cc: bridge@osdl.org, Jason Lunz <lunz@falooley.org>
Subject: Re: [Bridge] Bridge and PACKET-socket
Date: Tue, 13 Jan 2004 20:35:26 +0100	[thread overview]
Message-ID: <200401132035.26330.bdschuym@pandora.be> (raw)
In-Reply-To: <lhwu7wyful.fsf@dodo.bluetail.com>

On Monday 12 January 2004 23:14, Luke Gorrie wrote:
> I agree that dev.c is not confusing, but the PACKET(7) interface
> is. If you bind to ETH_P_ALL you will receive every packet, but if you
> bind to any other protocol you will only receive packets the bridge
> doesn't take. The manpage doesn't say anything about this, and one
> might actually want different semantics (as in my case). IMO it would
> be nicer to have an interface that treats "what protocol do I want to
> see" and "do I want bridged packets" as orthogonal.

Reading the man page is indeed confusing for a user, w.r.t. bridge ports.
I think it would be more logical if all PF_PACKETsockets see the frames before 
the bridge code.
How about placing the call to __handle_bridge() right after the second 
list_for_each? If I'm not mistaken the relevant pt_pre->func that would deal 
with the packet will not have been executed yet, while those PF_PACKET 
functions will already have been called...

If you want the opinion of someone more knowledgeable than my humble self, the 
network guru's are located at netdev@oss.sgi.com.

cheers,
Bart


  reply	other threads:[~2004-01-13 19:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-05 22:33 [Bridge] Bridge and PACKET-socket Luke Gorrie
2004-01-05 23:13 ` Bart De Schuymer
2004-01-05 23:50   ` Luke Gorrie
2004-01-08 16:34     ` Jason Lunz
2004-01-12 21:02       ` Luke Gorrie
2004-01-12 21:47         ` Bart De Schuymer
2004-01-12 22:14           ` Luke Gorrie
2004-01-13 19:35             ` Bart De Schuymer [this message]
2004-01-12 22:24         ` [Bridge] " Jason Lunz
2004-02-02 16:50 [Bridge] " Eble, Dan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200401132035.26330.bdschuym@pandora.be \
    --to=bdschuym@pandora.be \
    --cc=bridge@osdl.org \
    --cc=luke@member.fsf.org \
    --cc=lunz@falooley.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.