From: "David S. Miller" <davem@redhat.com>
To: Krishna Kumar <krkumar@us.ibm.com>
Cc: netdev@oss.sgi.com, krkumar@us.ibm.com
Subject: Re: [PATCH 4/5] xfrm_state_construct doesn't set tunnel state
Date: Tue, 13 Jan 2004 23:25:24 -0800 [thread overview]
Message-ID: <20040113232524.6ca5b0fe.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0401131323410.25742-100000@linux-udp14999547uds>
On Tue, 13 Jan 2004 13:24:23 -0800 (PST)
Krishna Kumar <krkumar@us.ibm.com> wrote:
> xfrm_state_construct doesn't set x->km.state to XFRM_STATE_DEAD. This can lead
> to the BUG_TRAP in __xfrm_state_destroy when xfrm_state_put() finds this is
> the last reference. This was reported as one of the symptoms of [Bug 1754]
> some time back.
Smells just like the nearly identical case in ipcomp :-)
Patch applied, thanks.
next prev parent reply other threads:[~2004-01-14 7:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-10 18:33 [PATCH] Bugs in xfrm Krishna Kumar
2004-01-10 20:11 ` David S. Miller
2004-01-13 21:21 ` [PATCH 1/5] ipcomp_tunnel_create doesn't set tunnel state Krishna Kumar
2004-01-13 21:22 ` [PATCH 2/5] Bad dereference of xfrm_state in pf_key Krishna Kumar
2004-01-14 7:21 ` David S. Miller
2004-01-13 21:23 ` [PATCH 3/5] xfrm_lookup bugs Krishna Kumar
2004-01-14 7:23 ` David S. Miller
2004-01-13 21:24 ` [PATCH 4/5] xfrm_state_construct doesn't set tunnel state Krishna Kumar
2004-01-14 7:25 ` David S. Miller [this message]
2004-01-13 21:26 ` [PATCH 5/5] schedule() bug in xfrm_lookup() Krishna Kumar
2004-01-14 7:27 ` David S. Miller
2004-01-14 7:20 ` [PATCH 1/5] ipcomp_tunnel_create doesn't set tunnel state David S. Miller
2004-03-09 21:36 ` [PATCH] Trivial kmalloc failure checks Krishna Kumar
2004-03-09 23:24 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040113232524.6ca5b0fe.davem@redhat.com \
--to=davem@redhat.com \
--cc=krkumar@us.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.