All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Stekloff <dsteklof@us.ibm.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/2] sdev_printk - scsi_device helper macro
Date: Mon, 19 Apr 2004 11:46:20 -0700	[thread overview]
Message-ID: <200404191146.21093.dsteklof@us.ibm.com> (raw)
In-Reply-To: <1080758108.1804.18.camel@mulgrave>

On Wednesday 31 March 2004 10:35 am, James Bottomley wrote:
> On Tue, 2003-10-07 at 16:18, Daniel Stekloff wrote:
> > +#define sdev_printk(level, sdev, format, arg...) \
> > +	printk(level "scsi <%s>: " format , (sdev)->sdev_gendev.bus_id , ##
> > arg) +
>
> OK, after six months, I've reconsidered on this one.
>
> Make it #define to dev_printk() and it can go in.
>
> James


Hi James,

I really don't think it's worth putting in sdev_printk() if it points to 
dev_printk(). As you have seen recently:

http://marc.theaimsgroup.com/?l=linux-scsi&m=108189253319586&w=2

dev_printk() is only useful when a driver is bound to the specific device. 
This would make sdev_printk() useless really except for upper level drivers. 
It can't safely be used in the mid-layer. If you're interested in cleaning up 
some of the printks in the midlayer and identifying messages with consistant 
scsi information, I would suggest using the sdev_printk() as I had submitted 
it. 

Thanks,

Dan



      parent reply	other threads:[~2004-04-19 18:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-07 20:18 [PATCH 1/2] sdev_printk - scsi_device helper macro Daniel Stekloff
2003-10-09  2:03 ` Hironobu Ishii
2003-10-09 17:24   ` Daniel Stekloff
2003-10-09 21:42     ` Patrick Mansfield
2004-03-31 18:35 ` James Bottomley
2004-03-31 19:23   ` Daniel Stekloff
2004-03-31 19:29     ` James Bottomley
2004-04-19 18:46   ` Daniel Stekloff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200404191146.21093.dsteklof@us.ibm.com \
    --to=dsteklof@us.ibm.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.